Thread: What's wrong?

Hi. My program in end stopped working. She showed me the error.

My program:

public class Authors2 {
 
	int authors03;
	String authors;
	private Scanner scan;
	private Scanner scan2;
	private Scanner scan3;
	String [] books2;
 
	public void Authors(){
		scan = new Scanner(System.in);
 
		System.out.println("Please write the author: ");
		authors = scan.nextLine();
		}
		//scan.close();
		public void Authorsandbooks(){
			scan2 = new Scanner(System.in);
 
			System.out.println("Please write how much author books you want to write: " + authors);
			authors03 = scan2.nextInt();
			scan2.nextLine();
		}
		//scan2.close();
		public void Books(){
			scan3 = new Scanner(System.in);
 
			for(int i = 0; i < authors03; i++){
 
			System.out.println("Please write author books: " + authors);
			books2[i] = scan3.nextLine();
		}
		//scan3.close();
		}
		public void Result(){
			System.out.println("You have writed the author: " + authors);
			System.out.println("You have entered these author books: " + books2);
		}
	public void Kiak(){
 
	Authors();
	Authorsandbooks();
	Books();
	Result();
	}
}

Error's:

[COLOR="#FF0000"]Exception in thread "main" java.lang.NullPointerException
	at Authorandbook.Authors2.Books(Authors2.java:35)
	at Authorandbook.Authors2.Kiak(Authors2.java:47)
	at Authorandbook.Main.main(Main.java:10)[/COLOR]

Please help!

Okey.

You are talking about this?:

books2[i] = scan3.nextLine();

Hmm.. I don't know.. As I created this:

books2[i] = scan3.nextLine();

I was compelled to create this one.

String [] books2;

What can I do?...
Program..jpg

Now I changed:

public void Books(){
			scan3 = new Scanner(System.in);
			for(int i = 0; i < authors03; i++){
 
			System.out.println("Please write author books: " + authors);
			books2 = scan3.nextLine();
		}
		//scan3.close();
		}
		public void Result(){
			System.out.println("You have writed the author: " + authors);
			System.out.println("You have entered these author books: ");
			for(int i = 0; i < authors03; i++){
			System.out.println(books2);
			int[] books21;
			books21 = new int[1];
			int books2 = 0;
			books21[0] = books2;
		}
		}

But my result is:

Test1
Please write author books: Lukas
Test2
Please write author books: Lukas
Test3
You have writed the author: Lukas
You have entered these author books: 
Test3
Test3
Test3

I found the problem in the times of scans you have been used.
Sorry for my previous post that i had deleted, i misunderstood concept.
As you creating scan for three times, you are prompted such a way. create scan as class level variable that holds value. and use it in place of scan2, scan3..

How to create? I don't know...

help!

Is the description of the problem in Post #1 still accurate, or have things changed? If they've changed, please provide updated code, descriptions, errors, etc.

As the error indicates, check line 35 for a null (uninitialized) variable and fix it. If you want more help than that, you should provide us with a short runnable example that demonstrates the problem.

Use .next() instead of .nextLine();

I forgot specifically why, but .nextLine(); is a little flawed in a way that it sometimes forgets the input or overwrites it.

My code:

import java.util.Scanner;
 
public class Authors2 {
 
	int authors03;
	String authors;
	String books2;
	private Scanner scan;
	private Scanner scan2;
	private Scanner scan3;
	public void Authors(){
		scan = new Scanner(System.in);
 
		System.out.println("Please write the author: ");
		authors = scan.next();
		}
		//scan.close();
	public void Authorsandbooks(){
		scan2 = new Scanner(System.in);
 
		System.out.println("Please write how much author books you want to write: " + authors);
		authors03 = scan2.nextInt();
		scan2.nextLine();
	}
		//scan2.close();
	public void Books(){
		scan3 = new Scanner(System.in);
		for(int i = 0; i < authors03; i++){
 
		System.out.println("Please write author books: " + authors);
		books2 = scan3.next();
	}
	//scan3.close();
	}
	public void Result(){
		System.out.println("You have writed the author: " + authors);
		System.out.println("You have entered these author books: ");
		for(int i = 0; i < authors03; i++){
		System.out.println(books2);
	}
}
	public void Kiak(){
		Authors();
		Authorsandbooks();
		Books();
		Result();
		}
	}

And my result is:

Please write the author: 
Lukas
Please write how much author books you want to write: Lukas
2
Please write author books: Lukas
Test1
Please write author books: Lukas
Test2
You have writed the author: Lukas
You have entered these author books: 
Test2
Test2

Why?

Here is the code that prints "Test2" twice. Is that the reason you've asked "Why?" by the way? Why can't you say, "Why does my program print Test2 twice when I expect it to do ". . . .(some other thing)? Don't post riddles. Tell us exactly what you need help with. Back to your code:

		System.out.println("You have entered these author books: ");
		for(int i = 0; i < authors03; i++){
		System.out.println(books2);
	}

The loop prints the String object books2 as many times as the value stored in authors03. What are you expecting it to do?

I want that the program print all books which I inserted. But now, my program prints the last book.

Better. What class (with the main() method) drives or tests this class?

Method names should begin with lowercase letters.

This is my main.

public class Main {
 
	/**
	 * @param args
	 */
	public static void main(String[] args) {
		Authors2 library = new Authors2 ();
		library.Kiak();
 
	}
}

Your design needs to be reworked. The class Author - get rid of the 's' - should contain only info about authors like 'name', 'datesActive', 'awards', 'booksWritten', etc. The 'booksWritten' field should be a collection of Book objects, and the Book class should contain only info about books. Each author is then a new instance of Author, and the fields for each author object are populated with that author's information.

The Author class should not have a Scanner object or methods that ask the user to input information. That should be accomplished somewhere else, in another class that builds the collection of Author and Book objects into a Library. Trying to do everything in one class as you are currently is a tangled mess, hard to keep track of, and I can see why you're confused.

Can you help me to rework it? Because I don't understand now how to do that..

You need to quit declaring ignorance and get to work. You know how to create classes. Create 2 new ones, Author and Book, create the necessary fields, setters, and getters within them, and then move code you've already written into them (if any), as appropriate. A third class, LibraryManager (?), will be used to gather user input, create authors and books, etc. That third class will have the Scanner object and the methods you've written to do those parts.