Declared variables not carrying over

**evanscott815** · October 4th, 2012, 08:55 AM

Hello,
I have in one class a JFrame declared like this:

public class copyPastePopup extends JFrame {
 
	JTextField cpText;
	String text;
 
	public copyPastePopup(String heading, String inputText) {
		inputText = text;

with other code following it. I then have that frame called like this:

copyPastePopup popup = new copyPastePopup("Encoded Message",finalMessage);

where finalMessage is a string. However, when I run the program, the JFrame sees the variables as null even though they have a string fed to them.
Any Idea whats going on?

evanscott815

**KevinWorkman** · October 4th, 2012, 09:04 AM

First off, I'd recommend using the standard naming conventions- classes start with an upper-case letter, methods and variables start with a lower-case letter. Seems trivial but it makes code a lot easier to read.

But think about what you're doing: you take inputText as a parameter. You then throw away whatever the value is and set it equal to text, which hasn't been set to anything yet. Is that really what you want to do?

**evanscott815** · October 4th, 2012, 10:40 AM

Yes, since text is a class-wide variable. I use it in other functions in that class.
However, even when I check the value of inputText, it is still null.
Personally, I like to use the nocaps-Caps format for names.

**KevinWorkman** · October 4th, 2012, 11:05 AM

Originally Posted by evanscott815

Yes, since text is a class-wide variable. I use it in other functions in that class.

That part is fine.

Originally Posted by evanscott815

However, even when I check the value of inputText, it is still null.

That's because you're setting it equal to text, which hasn't been set yet, so it's null. It's like if you do this:
int x = 0;
int y = 7;
y = x;
...and then ask why y isn't equal to 7.

Originally Posted by evanscott815

Personally, I like to use the nocaps-Caps format for names.

For your own purposes I suppose that's fine, but you're asking other people to read your code. Using non-standard naming conventions screams at more experienced developers, making it harder to actually see what's going on in your code. Shouldn't you make it as easy as possible to help you?

**evanscott815** · October 4th, 2012, 11:24 AM

Yeah, I get it. I will go through and rename my classes.
How do you suggest I set text equal to inputText?

**KevinWorkman** · October 4th, 2012, 11:27 AM

Originally Posted by evanscott815

How do you suggest I set text equal to inputText?

Well, you just said it. Right now you're setting inputText equal to text. It sounds like you might want to go the other way around?

**evanscott815** · October 4th, 2012, 11:52 AM

Ohhh... *facepalms*
That helps!
Thank you!

Thread: Declared variables not carrying over

LinkBack

Thread Tools

Display

Declared variables not carrying over

Related threads:

Re: Declared variables not carrying over

Re: Declared variables not carrying over

Re: Declared variables not carrying over

Re: Declared variables not carrying over

Re: Declared variables not carrying over

The Following User Says Thank You to KevinWorkman For This Useful Post:

Re: Declared variables not carrying over

Similar Threads

append to text field declared out of class

Differences between local variables and instance variables

can't use the file declared in other thread

Instance Variables and local variables difference

JFrame declared as setAlwaysOnTop doesn't stay on top during slide show