Thread: Server-client ping system won't work. (message being sent but not received)

Did that, all other code is still visible in the github.

Why whould you need to compile it? I really do think it's something little I've looked over since it almost always is... And it doesn't give an error or so, it just never says anything in the server while it does say "ping..."in the client once per second.

Ok, but I have to go in a hurry now, forgot the time. Ill make a compiling version later.

Okay, I made it so it can compile.
server
clientaccepter.java, accepts incoming connections

package server;
 
import java.io.IOException;
import java.net.ServerSocket;
import java.net.Socket;
 
public class ClientAccepter extends Thread{
 
	public static void main(String[] args) {
		new ClientAccepter();
	}
 
	ServerSocket server = null;
 
	public ClientAccepter() {
		init();
		this.start();
	}
 
 
	public void init() {
		try {
			server = new ServerSocket(25367);
		} catch (IOException e) {
			System.out.println("Could not listen on port 25367");
			System.exit(-1);
		}
	}
 
	@Override
	public void run() {
		while (true){
			try {
				Socket clientsocket = server.accept();
				Client client = new Client(clientsocket);
				client.init();
				((Thread)client).start();
			} catch (IOException e) {
				e.printStackTrace();
			}
 
		}
	}
 
}

client.java, maintains the connections

package server;
 
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.Socket;
 
 
public class Client extends Thread{
	private InputStreamReader in;
	private PrintWriter out;
	private Socket socket;
 
	public Client(Socket socket) {
		this.socket = socket;
	}
 
	public void init(){
		System.out.println("Client connected: "+socket.getInetAddress()+":"+socket.getPort());
		try {
			in = new InputStreamReader(socket.getInputStream());
			out = new PrintWriter(socket.getOutputStream(),true);
		} catch (IOException e) {
			e.printStackTrace();
		}
	}
 
	@Override
	public void run() {
		while (true){
			try {
				if (in.ready()){
					String string = "";
					int chr = in.read();
					while (chr != -1){
						string += Character.toString((char) chr);
					}
					System.out.println(string);
				}
			} catch (IOException e) {
				e.printStackTrace();
			}
		}
	}
 
}

client
connection.java, connects and pings

package client;
 
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.Socket;
import java.net.UnknownHostException;
import java.util.concurrent.CopyOnWriteArrayList;
 
 
public class Connection extends Thread{
 
	/**
	 * @param args
	 */
	public static void main(String[] args) {
		new Connection();
	}
 
	public Connection() {
		connect();
		((Thread)this).start();
	}
 
	Socket socket;
	private String host = "localhost";
	private InputStreamReader in;
	private PrintWriter out;
	private CopyOnWriteArrayList<String> messages = new CopyOnWriteArrayList<String>();
	private long lastPinged;
 
 
	public void connect() {
		try {
			socket = new Socket(host ,25367);
			in = new InputStreamReader(socket.getInputStream());
			out = new PrintWriter(socket.getOutputStream(),true);
		} catch (UnknownHostException e) {
			System.out.println("Could not connect.");
			e.printStackTrace();
		} catch (IOException e) {
			System.out.println("Could not connect.");
			e.printStackTrace();
		}
		System.out.println("Connected");
 
	}
 
	public void ping() {
		out.println("1|"+System.currentTimeMillis());
		out.flush();
		System.out.println("ping...");
		lastPinged = System.currentTimeMillis();
	}
 
	public void update(){
 
	}
 
	@Override
	public void run() {
		while (true){
			if (System.currentTimeMillis() - lastPinged >= 1000){
				ping();
			}
			try {
				if (in.ready()){
					String string = "";
					int chr = in.read();
					while (chr != -1){
						string += Character.toString((char) chr);
					}
					messages.add(string);
					System.out.println(string);
				}
			} catch (IOException e) {
				e.printStackTrace();
			}
		}
	}
 
}

The problem is, I already did that and it did say ping... in the client, and in the server the while loop was running... I'll try it again.

Probably not...

d4dev
I see you have 3 diff. threads. 1 server (ClientAccepter), 1 Connection and 1 Client...
I see how the server accepts an incomming request and starts the Client thread...
But I don't know where the Connection is invoked...
Your server can receive an incoming request only if this Connection thread is started somewhere...then your Client thread is started...when your client is started IT PINGS !

d4dev
I review your codes and don't find the relationship between the thread Connection and the Client+ClientAccepter thread. May I give you a hint? Don't use excessive threads. They can cause lots of hidden problems (e.g. Synchronization)