Thread: TCP Java Socket Server

Hi, i wrote this code, but when i connect via telnet, the server gives me no response :/ Please help ?

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.net.ServerSocket;
import java.net.Socket;
import java.util.logging.Level;
import java.util.logging.Logger;

/**
*
* @author Jenda
*/

public class Server extends Thread {
 
    Socket s;
 
    public static void main(String[] args) {
        try {
            ServerSocket ss = new ServerSocket(5222);
            while (true) {
                Socket s = ss.accept();
                Server srv = new Server();
                srv.s = s;
                srv.start();
            }
        } catch (IOException ex) {
            Logger.getLogger(Server.class.getName()).log(Level.SEVERE, null, ex);
        }
    }
 
    public void run(Socket s) {
        try {
            InputStream is = s.getInputStream(); //ze site
            OutputStream os = s.getOutputStream(); // to co ja posilam do site
            BufferedReader br = new BufferedReader(new InputStreamReader(is)); //obaleni buffered abych mohl cist po celych radcich
            String str;
            while ((str = br.readLine()) != null) {
                System.out.println(">> " + str);
                str = "SRV: " + str + "\n";
                os.write(str.getBytes());
            }
        } catch (IOException ex) {
            Logger.getLogger(Server.class.getName()).log(Level.SEVERE, null, ex);
        }
    }
}

Please edit your post and wrap your code with code tags:
[code=java]
YOUR CODE HERE
[/code]
to get highlighting and preserve formatting.

Add calls to the printStackTrace() to the catch blocks so any error messages are shown on the console.

Also try debugging the code by adding some println() statements that print out messages to show where the code is executing.

Originally Posted by vviston

public void run(Socket s) {

The main point: you are not overriding the run() of Thread.

But there is also other you should understand and improve ....