Thread: HttpURLConnection executing two times

I am using HttpURLConnection to make a request to server and save some data in the Database, but when I make the request it executes two times which adds two identical rows in the database.

Note: I am making the same request to the server from iOS as well and it works perfectly this only happens on Android using Java

This is the code where I make the request:

HttpURLConnection httpURLConnection = (HttpURLConnection)url.openConnection();

httpURLConnection.setRequestMethod("POST");
httpURLConnection.setDoOutput(true);
httpURLConnection.setDoInput(true);

OutputStream outputStream = (OutputStream)httpURLConnection.getOutputStream();
BufferedWriter bufferedWriter = new BufferedWriter(new OutputStreamWriter(outputStream, "UTF-8"));

String post_data = URLEncoder.encode("user_name" ,"UTF-8") + "=" + URLEncoder.encode(user,"UTF-8")+"&"
+URLEncoder.encode("user_id" ,"UTF-8") + "=" + user_id+"&"
+URLEncoder.encode("manager_id" ,"UTF-8") + "=" + manager+"&"
+URLEncoder.encode("company_id" ,"UTF-8") + "=" + company+"&"
+URLEncoder.encode("user_role" ,"UTF-8") + "=" + URLEncoder.encode(user_role ,"UTF-8");

bufferedWriter.write(post_data);
bufferedWriter.close();
outputStream.close();

InputStream inputStream = httpURLConnection.getInputStream();
Reader reader = new InputStreamReader(inputStream);

final char[] buf = new char[256];

final StringBuffer sb = new StringBuffer();

while (true) {
int length = reader.read(buf);
if (length == -1) break;
sb.append(buf, 0, length);
}

reader.close();
inputStream.close();

I am using HttpURLConnection to make a request to server and save some data in the Database, but when I make the request it executes two times which adds two identical rows in the database.

Note: I am making the same request to the server from iOS as well and it works perfectly this only happens on Android using Java

This is the code where I make the request:

HttpURLConnection httpURLConnection = (HttpURLConnection)url.openConnection();
 
httpURLConnection.setRequestMethod("POST");
httpURLConnection.setDoOutput(true);
httpURLConnection.setDoInput(true);
 
OutputStream outputStream = (OutputStream)httpURLConnection.getOutputStream();
BufferedWriter bufferedWriter = new BufferedWriter(new OutputStreamWriter(outputStream, "UTF-8"));
 
String post_data = URLEncoder.encode("user_name" ,"UTF-8") + "=" + URLEncoder.encode(user,"UTF-8")+"&"
+URLEncoder.encode("user_id" ,"UTF-8") + "=" + user_id+"&"
+URLEncoder.encode("manager_id" ,"UTF-8") + "=" + manager+"&"
+URLEncoder.encode("company_id" ,"UTF-8") + "=" + company+"&"
+URLEncoder.encode("user_role" ,"UTF-8") + "=" + URLEncoder.encode(user_role ,"UTF-8");
 
bufferedWriter.write(post_data);
bufferedWriter.close();
outputStream.close();
 
InputStream inputStream = httpURLConnection.getInputStream();
Reader reader = new InputStreamReader(inputStream);
 
final char[] buf = new char[256];
 
final StringBuffer sb = new StringBuffer();
 
while (true) {
int length = reader.read(buf);
if (length == -1) break;
sb.append(buf, 0, length);
}
 
reader.close();
inputStream.close();

Originally Posted by Norm

Is that because it is called two times? The posted code does not show how it is called.

This is how I call it, SaveCheckin is AsyncTask class:

private void saveCheckin(){
        try {
            JSONObject user = new JSONObject(i.getStringExtra("userData"));
 
            String name, id, manager, company, added_by;
            name = user.getString("first_name") +"_"+ user.getString("last_name");
            id = user.getString("ID");
 
            if(is_admin){
                manager = id;
                company = id;
                added_by = "Owner";
 
            }else{
                manager = user.getString("manager");
                company = user.getString("company_id");
                added_by = user.getString("added_by");
            }
 
            SaveCheckin checkin = new SaveCheckin(this, name, buttons, loading, checkinPage, userPhoto);
 
            checkin.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, id, manager, company, added_by, location, userRole);
        } catch (JSONException e) {
            e.printStackTrace();
        }
    }

And this is the onBackground method of SaveCheckin:

@Override
    protected String doInBackground(String... strings) {
 
        Date date = new Date();
        SimpleDateFormat formatter = new SimpleDateFormat("yyyy-M-dd HH:mm:ss");
 
        user_id = Integer.parseInt(strings[0]);
        manager = Integer.parseInt(strings[1]);
        company = Integer.parseInt(strings[2]);
 
        String added_by = strings[3];
        String user_role = strings[5];
 
        String url = context.getString(R.string.web_path)+"/mobile/save-data.php";
 
 
        try{
            HttpURLConnection httpURLConnection = (HttpURLConnection)url.openConnection();
 
            httpURLConnection.setRequestMethod("POST");
            httpURLConnection.setDoOutput(true);
            httpURLConnection.setDoInput(true);
 
            OutputStream outputStream = (OutputStream)httpURLConnection.getOutputStream();
            BufferedWriter bufferedWriter = new BufferedWriter(new OutputStreamWriter(outputStream, "UTF-8"));
 
            String post_data = URLEncoder.encode("user_name" ,"UTF-8") + "=" + URLEncoder.encode(user,"UTF-8")+"&"
                    +URLEncoder.encode("user_id" ,"UTF-8") + "=" + user_id+"&"
                    +URLEncoder.encode("manager_id" ,"UTF-8") + "=" + manager+"&"
                    +URLEncoder.encode("company_id" ,"UTF-8") + "=" + company+"&"
                    +URLEncoder.encode("user_role" ,"UTF-8") + "=" + URLEncoder.encode(user_role ,"UTF-8");
 
            bufferedWriter.write(post_data);
            bufferedWriter.close();
            outputStream.close();
 
            InputStream inputStream = httpURLConnection.getInputStream();
            Reader reader = new InputStreamReader(inputStream);
 
            final char[] buf = new char[256];
 
            final StringBuffer sb = new StringBuffer();
 
            while (true) {
                int length = reader.read(buf);
                if (length == -1) break;
                sb.append(buf, 0, length);
            }
 
            reader.close();
            inputStream.close();
 
            return sb.toString();
        }catch (MalformedURLException e){
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
 
 
        return null;
    }

Originally Posted by Norm

How do you know that the code in the doInBackground method is being executed two times? Do you have a print statement at the start of the method that prints a message when the method's code is executed?
If the method is being executed two times, where is it called from each time?
I do not see any calls to doInBackground in the posted code.

This line

checkin.executeOnExecutor(AsyncTask.THREAD_POOL_EX ECUTOR, id, manager, company, added_by, location, userRole);

calls doInBackground.
It adds two rows at once in the MySql database.