Is this a stupid idea?

**Kerr** · November 28th, 2011, 06:05 PM

Hi all.

Had to refactor the program I am working on after deciding that a feature was missing. Anyway, I realized that a private method was useful elsewhere and moved it out. Then I refactored that method as well, so it . Anyway, long story short I ended up with this method:

    public static void fill(Collection<String> data, Iterator<String> itr) {
        while (itr.hasNext())
            data.add(itr.next());
    }

Is that too little code to justify being in a method of its own? I feel that it helps keeping my code a but cleaner to have it as a utility method rather then doing it over and over again every time I need to do that (it is not too many times, tbh, but its common enough). This is also related to another question, which is the one that I was thinking of when I made the title, but I thought I would ask this one first since they kind of goes hand in hand.

Take care,
Kerr.

**Junky** · November 28th, 2011, 06:19 PM

If your aim is to add items from one Collection into another then why not use the addAll method?

**Kerr** · November 28th, 2011, 06:44 PM

I have to use an Iterator and the addAll method accepts a Collection.

**Junky** · November 28th, 2011, 07:14 PM

Why do you have to use an Iterator? If this is for a school assignment then make sure you have read the requirements correctly. Confirm with the teacher if you can use the addAll method.

**Kerr** · November 30th, 2011, 01:29 PM

No, the program is just me fooling around building a very basic scripting language (quite useless, actually, since it can only do about 4 things, but its good training). Basically I am using an iterator to move through a string that is being read from a file. There is a class that does that already, moving through a string the way I want that is, but I didnt realize that until after I made the iterator, and since my code works as I want I didnt feel the need to change it. Anyway, the iterator is used for some things before this method is called. In fact, this method is the one called last, when the rest of the string is data rather then commands.

In any case, I have decided that my change was not needed so I changed back my code. Would still like an answer to the question, though, just for future reference.

Thread: Is this a stupid idea?

LinkBack

Thread Tools

Display

Is this a stupid idea?

Related threads:

Re: Is this a stupid idea?

Re: Is this a stupid idea?

Re: Is this a stupid idea?

Re: Is this a stupid idea?

Similar Threads

what the stupid problem in using netbeans

"The import ___ cannot be resolved" (stupid noob question)

No idea what to do for this

Stupid thing can't find image icon right in front of it!!!

My doubt may be stupid