Thread: How to return class instance?

I have the next code:

import java.sql.*;
 
public class Products {
private int ProductID;
private String name;
private String category;
private Double price;
public void setId(int ProductID) { this. ProductID = ProductID; }
public int getId() { return this.ProductID; }
public void setName(String name) { this.name = name; }
public String getName() { return this.name; }
public void setCategory(String category) { this. category = category; }
public String getcategory () { return this.category; }
public void setPrice(double price) { this.price = price; }
public double getCijena() { return this.price; }
public Products(int ProductID, String name, String category, Double price)
{
    this.ProductID = ProductID;
    this.name = name;
    this.category = category;
    this.price = price;
  }
public static void getFromId(int productID)
{
Connection conn = null;
   {
try
    {
      Class.forName ("com.mysql.jdbc.Driver").newInstance ();
          conn = DriverManager.getConnection ("jdbc:mysql://localhost/prodaja", "root", "");
        System.out.println(conn.isClosed());
    }
catch(Exception ex)
{ 
System.out.println("Connection not established"); 
}
 try
{
 Statement st = conn.createStatement();
    st.executeQuery("select * from products WHERE ID_product="+productID);
    ResultSet rs = st.getResultSet();
    while (rs.next()) 
    {
        int IdP = rs.getInt(1);
        String Pname = rs.getString(2);
        String Pcategory = rs.getString(3);
        Double Pprice = rs.getDouble(4);
        Products p=new Products(IdP, Pname, Pcategory, Pprice);
    }
}
   catch (SQLException s){
  System.out.println("SQL statement not executed!");
}
 
finally {
try
    {
    if(conn!=null && !conn.isClosed())
        conn.close();
    System.out.println(conn.isClosed());
    }
catch(Exception ex) { }
 
 }
}

Now, what I need is to make this method(getFromId) return this newly created class instance, with its fields values.
Any suggestons?

Originally Posted by newbie

I'm assuming you want to return your Products object, so all you need to do is change the method declaration from void, to a return type of Products.
then in your method, use return p;

E.g
To write a method which returns a String, you would do:

public String getString(){
   String x = "Hello World";
   return x;
}

I tried that, but it's not working.
I get error message saying:
Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - missing return statement
at sales.Product.getFromId(Product.java:158)
at sales.Sales.main(Sales.java:18)
Java Result: 1

"Sales" is the name of main class, from which I call method(getFromID)

Originally Posted by newbie

Your class is Products not Product

It was, but I changed it to Product, because it should contain data for one product.

Cross posted at classInstanceInitalization - CodeGuru Forums