Thread: How to get getPixelColor to Loop

Where in the loop do you change either of the values being tested in the while condition?

Originally Posted by newbie

Forgive me if I'm being unreasonable, but could you possibly rephrase the question? Having a hard time understanding the exact issue you're having.

Sorry, my English is bad. I will try to explain myself.

robot.getPixelColor takes colour of pixel on coordinates x=1147 and y=706 and write it to variable End.
If colour is not the same as in variable L, then the loop will starts.
When the pixel on coordinates x and y change its colour, value of variable End will be still the same and 'while loop' wont stops.
I need to make variables L and End have the same values.

Norm gave me a good question. I forgot on that.
But still I don't know how to implement it into the while condition.

public static void main(String[] args) throws InterruptedException {
 
        try {
 
               Robot robot = new Robot();
               Color End = robot.getPixelColor(1147, 706);
               Color L = new Color(53,51,41);
 
               while(End.getRGB() != L.getRGB()){
               //some things
               Color End = robot.getPixelColor(1147, 706); // <<---------- it can't be written like this, right?
             }} catch (AWTException e) {
}

Your code is defining two different variables with the name end (note variable names should start with lowercase letter). Use the existing variable: end inside of the loop. Do not define a new one:

  end = robot.getPixelColor(1147, 706);

while(End.getRGB() != L.getRGB()){
               //some things
               Color End = robot.getPixelColor(1147, 706); // <<---------- it can't be written like this, right?
             }} catch (AWTException e) {
}

What's actually happening here is, the End variable inside the loop has scope only inside the loop and it's not actually changing the above variable defined as End. And End and L are not changing at all. Just don't create a new variable but use the above variable to get the pixel color and to compare. (Also, read the Sun's naming conventions)

Thank you, that should resolve my problem. Really thanks

Originally Posted by Vergil333@gmail.com

Thank you, that should resolve my problem. Really thanks

Yeah it should. But the question is, did it?

Originally Posted by Mr.777

Yeah it should. But the question is, did it?

It didn't But I think problem is in statements inside the While.

Here is something from the code:

public static void main(String[] args) throws InterruptedException {
    int l=0;
        try {
 
               Robot robot = new Robot();
               Robot r = new Robot();
               Color end = robot.getPixelColor(1147, 706);
               Color k = new Color(53,51,41);
 
               while(end.getRGB() != k.getRGB()){
 
                         Color spd = robot.getPixelColor(72, 572);
                         Color mis = new Color(55,53,31);
                         Color mas = new Color(82,79,57);
 
                         if(spd.getRGB() >= mis.getRGB() && spd.getRGB() <= mas.getRGB()){
                         r.delay(50);
                         r.keyPress(KeyEvent.VK_ENTER);
                         r.delay(50);
                         r.keyRelease(KeyEvent.VK_ENTER);
                         r.delay(1000);}
 
                         Color btb = robot.getPixelColor(531, 148);
                         Color alert = new Color(174,42,37);
 
                         while(l<0){
                              if(btb.getRed() > alert.getRed() && btb.getGreen() < alert.getGreen() && btb.getBlue() < alert.getBlue()){
                              r.delay(50);
                              r.keyPress(KeyEvent.VK_F3);
                              r.delay(50);
                              r.keyRelease(KeyEvent.VK_F3);
                              r.delay(50);
                              l++;}
                        btb = robot.getPixelColor(531, 148);
                        }
 
               end = robot.getPixelColor(1147, 706);
             }} catch (AWTException e) {
}}}

It's just part of the code. I have there 3 Whiles and 1 If in the "main while".

Can you explain your problem?
What is the code you posted supposed to do? What does it do?
Have you tried debugging the code by adding printlns to show the values of variables and the execution flow as the code is executed?

.......................... Sorry just seen l

end = robot.getPixelColor(1147, 706);

Each time you are getting color of same pixels.

Hallo again. It is working now good In my code I have a looot of loops in other loops and them in other loops Adding println really helped me to find and fix issues that I had. There is still something not working properly, but I think I can deal with it now
Thanks for helping me

Wow what is a robot in Java?

There is a class named Robot in Java SE. Read the API doc for more info.
Java Platform SE 6