Thread: ServerSocket send data to all Sockets

I'm working on my first maultiplayer game in java. But I have a problem. Only the latest connected socket get any data, and I have no idea why. I tried to make a loop that would send the collected data to all the players but only the newest one gets it.

Here is my code

public void run()
   {
      while(true)
      {
         String data = "";
         for(Player player : Player.getPlayers())
         {
            player.move();
            data += player.getData();
         }
 
         data += "done"+in.newline;
 
         for(Player player : Player.getPlayers())
         {
            Socket socket = player.getSocket();
 
            if(!socket.isClosed())
            {
               try
               {
                  OutputStream out = socket.getOutputStream();
                  out.write(data.getBytes());
                  out.flush();
               } catch (IOException e) {
                  e.printStackTrace();
               }
            }
         }
 
         try{Thread.sleep(10);}catch(Exception e){}
      }
   }

Originally Posted by Norm

sounds like you need to save the connections to all the clients that have connected in a collection of some kind so you can use that connection to send something to each of them.

It's hard to say what the problem is without seeing all the code. What is in Player? What does getPlayers() return? Print it out to see for sure.

This is what i have in the main server class.

	public void run()
	{
		while(true)
		{
			Socket join = null;
 
			try 
			{
				join = serverSocket.accept();
			} catch (IOException e) {
				e.printStackTrace();
			}
 
			if(join != null)
			{
				System.out.println(join.toString());
				Player.getPlayers().add(new Player(join));
			}
		}
	}

The Player class extends Entity which is just this

public class Entity
{
	int x, y;
	public void setX(int i){ x = i; }
	public void setY(int i){ y = i; }
	public int getX(){ return x; }
	public int getY(){ return y; }
}

And this is Player class

public class Player extends Entity implements Runnable 
{
	private static Socket socket;
	private static List<Player> players  = new ArrayList<Player>();
	private Thread thread;
 
	private int move = 0, steps;
 
	public Player(Socket s)
	{		
		setX(64);
		setY(64);
		socket = s;
 
		thread = new Thread(this);
		thread.start();
	}
 
	public Socket getSocket()
	{
		return socket;
	}
 
	public static List<Player> getPlayers()
	{
		return players;
	}
 
	public String getData()
	{
		return getX()+":"+getY()+in.newline;
	}
 
	public void move(int dir)
	{
		if(move == 0)
		{
			move = dir;
			steps = 32;
		}
	}
 
	public void move()
	{
		if(move == 1){ setY(getY()+1); }
		if(move == 2){ setY(getY()-1); }
		if(move == 3){ setX(getX()-1); }
		if(move == 4){ setX(getX()+1); }
 
		if(steps != 0)
		{
			steps--;
		}
 
		if(steps == 0 && move != 0)
		{
			move=0;
		}
	}
 
	public void run()
	{
		while(getSocket().isConnected() && !getSocket().isClosed())
		{
			Scanner scan = null;
 
			try 
			{
				scan = new Scanner(getSocket().getInputStream());
				while(scan.hasNextLine())
				{
					String line = scan.nextLine();
					String[] raw = line.split("\\:");
					move(Integer.parseInt(raw[0]));
				}
 
			} catch (IOException e) {
				e.printStackTrace();
			}finally{
				if(scan != null)
				{
					scan.close();
				}
			}
		}
	}
}

Originally Posted by Norm

Have you tried debugging the code by adding printlns to show the values of variables when they are changed and used. For example, players. When is a Player object added to it? How many Player objects are in it before the for loop?

Thanks. It helped me locate the problem. In the Player.java I had this code private static Socket socket; which sould have been this private Socket socket;