Thread: Limiting Letters in a String

Why is this code letting me enter a password such as a123?

 
                System.out.println("\nEnter new password:");
                strPasswordTemp = input.next();
                byte[] bytPassword = strPasswordTemp.getBytes();  
                for (byte bytTemp : bytPassword)
                {
                    char tempChar = (char) bytTemp;
                    if (Character.isLetter(tempChar))
                    {
                        intNumOfLetters++;
                    } // end of if statement
                    if (Character.isDigit(tempChar))
                    {
                        intNumOfDigits++;
                    } // end of if statement
                } // end of for loop
                if (intNumOfLetters < 8 && intNumOfDigits < 3)
                {
                    System.out.println("\n[ Password must contain at least 8 " +
                        "letters and 3 numbers ]");
                    System.out.println("\nPlease press the 'Enter' key to " +
                            "continue");
                    keyIn.nextLine();
                    break;
                } // end of if statement

Use System.out.println to see what your input is and make sure everything is getting read correctly. Next do the same with intNumOfLetters and intNumOfDigits, to see if your variable values are wrong or if you are incorrectly scanning the string.

When you determine the location of where your program is going wrong, the solution becomes much more simple to look for. Tis more efficient to ask how to fix this, than to ask what's wrong in the first place.

I see what you are doing. You are obtaining a String, changing it to byte, then changing the byte to char...

Could it be thats missing the array state of [] ?

I think there are easier approaches to this. You can proably get the String length and declare an array of char with that length. Then evalaute position by position.

Hello.
Your condition has logical error.
Lets say there are two conditions c1 and c2. If either condition is false then the result is false. In this case we will use AND operator.
But I use converse !c1 and !c2. In this case I will use OR operator not AND.

Syed.