Thread: It does not return data as it should in the cycle

I did it this way, but it doesn't verify that the license plates are the same, how come?

public void confrontaTarghe() throws IOException {
 
		VeicoloDb veicoloDb = new VeicoloDb();
		Spinelli spinelli = new Spinelli();
		int i;
 
		// Se la Targa veicolo sono uguali Aggiungi ID nella Nuova colonna
		for (i = 0; i < 280; i++) {
			for (int j = 0; j < 280; j++) {
				if (spinelli.getListCellveicoli_targa().get(i).equals(veicoloDb.getListCelltarga().get(j))) {
					System.out.println(
							spinelli.getListCellveicoli_targa().get(i) + " =  " + veicoloDb.getListCelltarga().get(i)
									+ " --> " + i + " --> " + spinelli.getListCellveicoli_id().get(i));
 
					// Scrivi nella riga i
					row = sheet.getRow(i);
 
					// Scrivi nella colonna AC indice 28
					cell = row.createCell(28);
 
					// Scrivi il ciclo in tutte le righe nella colonna AC indice 28
					sheet.getRow(i).createCell(28).setCellValue(spinelli.getListCellveicoli_id().get(i));
 
					FileOutputStream fos = new FileOutputStream(filePath);
 
					// Scrivi nel file
					wb.write(fos);
 
					// Chiudi il file
					fos.close();
					System.out.println("OK");
 
				}
 
 
			}
 
		}
	}

methods

// Lista Spinelli veicoli_targa
	public ArrayList<String> getListCellveicoli_targa() {
		for (int rowIndex = 1; rowIndex < 281; rowIndex++) {
			currentRow = dataTypeSheet.getRow(rowIndex);
			cell_veicoli_targa = currentRow.getCell(32); // Cella AG
			veicoli_targa.add(cell_veicoli_targa.getStringCellValue());
		}
		return veicoli_targa;
	}

methods

// Lista targa
	public ArrayList<String> getListCelltarga() {
		for (int rowIndex = 1; rowIndex < 281; rowIndex++) {
			currentRow = dataTypeSheet.getRow(rowIndex);
			cell_targa = currentRow.getCell(11); // Cella L
			targa.add(cell_targa.getStringCellValue());
		}
		return targa;
	}

the index is 281 in excel


if the wipers are the same, I must print only the same number plates.
Does it print everything to me?

The first 20 me prints well the same plates. Then going ahead does not make the comparison and I print the plates not equal index i and j

FR727XD = FR727XD --> 0 --> 25875
OK
FN871AM = FN871AM --> 1 --> 25874
OK
FN712MX = FN712MX --> 2 --> 25873
OK
FL966WE = FL966WE --> 3 --> 25872
OK
FL965WE = FL965WE --> 4 --> 25871
OK
FL964WE = FL964WE --> 5 --> 25870
OK
FL963WE = FL963WE --> 6 --> 25869
OK
FL962WE = FL962WE --> 7 --> 25868
OK
FL893WE = FL893WE --> 8 --> 25867
OK
FL892WE = FL892WE --> 9 --> 25866
OK
FL891WE = FL891WE --> 10 --> 25865
OK
FL890WE = FL890WE --> 11 --> 25864
OK
FL889WE = FL889WE --> 12 --> 25863
OK
FL721WE = FL721WE --> 13 --> 25862
OK
FL720WE = FL720WE --> 14 --> 25861
........
.......
ET713YE = ET433TE --> 127 --> 25751
OK
ET527GV = ET352HR --> 128 --> 25750
OK
ET478TG = ET351HR --> 129 --> 25749
OK
ET433TE = ET350HR --> 130 --> 25748
OK
ET352HR = ET349HR --> 131 --> 25747
OK
ET351HR = ET348HR --> 132 --> 25746
OK
ET350HR = ET347HR --> 133 --> 25745


Can you help me to correct the code please?

--- Update ---

ET350HR = ET347HR --> 133 --> 25745 -->This would be the id of the license plate 25745


I only do the control with the license plate, I remind you that the data are two excel files with identical license plates and identical ids.
In the first file there are 281 records
In the second file there are 267 records

public void confrontaTarghe() throws IOException {
 
		VeicoloDb veicoloDb = new VeicoloDb();
		Spinelli spinelli = new Spinelli();
		int i,j;
		for (i = 0; i < 280 ; i++) {
			for (j = 0; j < 280 ; j++) {
				if (spinelli.getSpinelliTarga().get(i).equals(veicoloDb.getVeicoloTarga().get(j))) {
					System.out.println(
							spinelli.getSpinelliTarga().get(i) + " =  " + veicoloDb.getVeicoloTarga().get(i)
									+ " --> " + i + " --> " + spinelli.getListCellveicoli_id().get(i)
									+ " --> " + veicoloDb.getListCellId().get(j));
 
					// Scrivi nella riga i
					row = sheet.getRow(i);
 
					// Scrivi nella colonna AC indice 28
					cell = row.createCell(28);
 
					// Scrivi il ciclo in tutte le righe nella colonna AC indice 28
					sheet.getRow(i).createCell(28).setCellValue(spinelli.getListCellveicoli_id().get(i));
 
					FileOutputStream fos = new FileOutputStream(filePath);
 
					// Scrivi nel file
					wb.write(fos);
 
					// Chiudi il file
					fos.close();
					System.out.println("OK");
 
				}
 
 
			}
 
		}

this is the print code


when i do the if, it has to print only the same license plates and nothing else

--- Update ---

BP377GT = FR727XD --> 0 --> 25610 --> 25875
OK
BV469PE = FN871AM --> 1 --> 25611 --> 25874
OK
BV475PE = FN712MX --> 2 --> 25612 --> 25873
OK
BV649PE = FL966WE --> 3 --> 25613 --> 25872
OK
BV790PE = FL965WE --> 4 --> 25614 --> 25871

This is the index in excel: veicoloDb.getListCellId()
in the excel file the index is 267
id
25610
25611
25612
25613
25614
25615
25616
25617
25618
25619
25620


this is the code

public ArrayList<String> getListCellId() {
		for (int rowIndex = 1; rowIndex < 266; rowIndex++) {
			currentRow = dataTypeSheet.getRow(rowIndex);
			cell_id = currentRow.getCell(0); // Cella A
			id.add(cell_id.getStringCellValue().toString());
		}
		return id;
	}

Instead for the other, the id list is:
in the excel file the index is 281
veicoli::id
25610
25611
25612
25613
25614
25615
25616
25617
25618
25619
25620
25621
25622

public ArrayList<String> getListCellveicoli_id() {
		for (int rowIndex = 1; rowIndex < 281; rowIndex++) {
			currentRow = dataTypeSheet.getRow(rowIndex);
			cell_veicoli_id = currentRow.getCell(27); // Cella AB
			veicoli_id.add(cell_veicoli_id.getStringCellValue().toString());
		}
		return veicoli_id;
	}

Maybe if I understand correctly the problem is in the index, I don't know how I can solve it

// Se la Targa veicolo sono uguali Aggiungi ID nella Nuova colonna
		for (spinelliIndex = 0; spinelliIndex < spinelli.getListCellveicoli_id().size(); spinelliIndex++) {
			for (veicoloIndex = 0; veicoloIndex < veicoloDb.getListCellId().size(); veicoloIndex++) {
				if (spinelli.getSpinelliTarga().get(spinelliIndex).equals(veicoloDb.getVeicoloTarga().get(veicoloIndex))) {
					System.out.println(
							spinelli.getSpinelliTarga().get(spinelliIndex) + " =  " + veicoloDb.getVeicoloTarga().get(veicoloIndex));

print:
BP377GT = BP377GT
OK
BP377GT = BP377GT
OK
BP377GT = BP377GT
OK
BP377GT = BP377GT
OK
BP377GT = BP377GT
OK

does not work

I'll explain the press:

Targa == Targa

That the first plate corresponds to spinelli.getSpinelliTarga (). Get (spinelliIndex)

That the second plate corresponds

veicoloDb.getVeicoloTarga (). get (veicoloIndex)

Then I noticed

public ArrayList <String> getVeicoli_id () {
return Vehicles_id;
}

The list is empty

which recalls

public ArrayList <String> getListCellveicoli_id () {
for (int rowIndex = 1; rowIndex <281; rowIndex ++) {
currentRow = dataTypeSheet.getRow (rowIndex);
cell_veicoli_id = currentRow.getCell (27); // Cell AB
veicoli_id.add (cell_veicoli_id.getStringCellValue (). toString ());
}
return Vehicles_id;
}

when I recall the method again by indexing getVeicoli_id (), it appears EMPTY, how come?
No restitusce anything
Since the list is populated with
veicoli_id.add (cell_veicoli_id.getStringCellValue (). toString ());

I don't know how to solve it, I need help.

for (spinelliIndex = 0; spinelliIndex < spinelli.getVeicoli_id().size(); spinelliIndex++) {
			for (veicoloIndex = 0; veicoloIndex < veicoloDb.getVeicoloId().size(); veicoloIndex++) {
				if (spinelli.getSpinelliTarga().get(spinelliIndex).equals(veicoloDb.getVeicoloTarga().get(veicoloIndex))) {
					System.out.println(
							spinelli.getSpinelliTarga().get(spinelliIndex) + " =  " + veicoloDb.getVeicoloTarga().get(veicoloIndex));

public ArrayList<String> getVeicoli_id() {
		for (int rowIndex = 1; rowIndex < 281; rowIndex++) {
			currentRow = dataTypeSheet.getRow(rowIndex);
			cell_veicoli_id = currentRow.getCell(27); // Cella AB
			veicoli_id.add(cell_veicoli_id.getStringCellValue().toString());
		}
		return veicoli_id;
	}

I did it this way, but the result is always the same.
There are no other alternatives, the list must necessarily be popular to fill in the values ​​in the list.

How can I implement the method?

thank you so much


Can you help me code the system, since I am a beginner?

now I try and let you know. thank you

--- Update ---

Thank you that you made me understand the problem a lot, it works, slowly I go ahead with the project, if I have other problems I create a new post

thanks a lot

Another thing is sorry again, in the first sheet in Excel I entered an extra id, instead in the second sheet in Excel I didn't insert it. For the negative ifs as I did in the code I don't print the negative

}else if(!spinelli.getVeicoli_id().get(spinelliIndex).equals(veicoloDb.getVeicoloId().get(veicoloIndex))){
					System.out.println(veicoloDb.getVeicoloId().get(veicoloIndex));
				}

I tried to insert an extra id on the first sheet but on the second sheet I didn't enter it, but the print doesn't come out

Exactly, if the customer code is not present in the list, a message must be sent out. Come on can I implement in this case?

if the plaque is not found either in joints or in vehicles, print the plaque that is not the same or does not exist in the list

for (spinelliIndex = 0; spinelliIndex < spinelli.getVeicoli_id().size(); spinelliIndex++) {
			for (veicoloIndex = 0; veicoloIndex < veicoloDb.getVeicoloId().size(); veicoloIndex++) {
				if (spinelli.getVeicoli_targa().get(spinelliIndex).equals(veicoloDb.getTarga().get(veicoloIndex))) {
 
					System.out.println(spinelli.getVeicoli_targa().get(spinelliIndex) + " = "
							+ veicoloDb.getTarga().get(veicoloIndex) + " --> "
							+ spinelli.getVeicoli_id().get(spinelliIndex) + " --> "
							+ veicoloDb.getVeicoloId().get(veicoloIndex));
 
					// Scrivi nella riga i
					row = sheet.getRow(spinelliIndex);
 
					// Scrivi nella colonna AC indice 28
					cell = row.createCell(28);
 
					// Scrivi il ciclo in tutte le righe nella colonna AC indice 28
					sheet.getRow(spinelliIndex).createCell(28)
							.setCellValue(spinelli.getVeicoli_id().get(spinelliIndex));
 
					FileOutputStream fos = new FileOutputStream(filePath);
 
					// Scrivi nel file
					wb.write(fos);
 
					// Chiudi il file
					fos.close();
 
				} else if (spinelli.getVeicoli_targa().get(spinelliIndex) != veicoloDb.getTarga().get(veicoloIndex) || !(spinelli.getVeicoli_targa().get(spinelliIndex) != veicoloDb.getTarga().get(veicoloIndex))) {
					System.out.println( "else:" + spinelli.getVeicoli_targa().get(spinelliIndex) + " = "
							+ veicoloDb.getTarga().get(veicoloIndex) + " --> "
							+ spinelli.getVeicoli_id().get(spinelliIndex) + " --> "
							+ veicoloDb.getVeicoloId().get(veicoloIndex));
				}
 
			}
 
		}

This is what I print when I do, but in the part of ELSE, like that, it doesn't convince me

else:FL962WE = EP342EL --> 25868 --> 25652
else:FL962WE = EP343EL --> 25868 --> 25653
else:FL962WE = EP478EL --> 25868 --> 25654
else:FL962WE = EP479EL --> 25868 --> 25655
else:FL962WE = EP480EL --> 25868 --> 25656
else:FL962WE = EP481EL --> 25868 --> 25657
else:FL962WE = EP482EL --> 25868 --> 25658


In addition, I must print both the license plates and the license plates that are not the same or that the license plate is not present in the list of joints or in the vehicle list


thank you

If the license plates are the same in the IF code, the print exits in this way.

BP377GT = BP377GT --> 25610 --> 25610
BV469PE = BV469PE --> 25611 --> 25611
........
When I insert the other ELSE instruction ...... as you see in the code

the print must appear as follows:

The license plate of the vehicleDb.getTarga (). Get (vehicleIndex) was not found in the list or spinelli.getVeicoli_targa (). Get (spinelliIndex) the license plate was not found in the list