Thread: Determine the two smallest integers from a set of user input integers

Hi everyone,

I am a little stumped on this problem. I have it solved for the most part but I'm getting stuck on a small detail. First here is the exact wording of the problem:

"Write a Java program that prompts the user to enter integer values then prints the two smallest numbers (in any order) in the input. You may assume that the user will enter a valid number greater than 1 for the number of numbers to read."

We have not studied arrays yet so the prof expects us to use loops and conditional statements to determine the smallest values in real time. Now I have been able to write a program that will output the two smallest digits in all scenarios EXCEPT for if the first digit entered is the smallest digit. I was wondering if there is another if statement that can remedy this issue or if I should approach the problem in a completely different way. Here is the code:

import java.util.*;
 
public class Assignment5Q1 {
    public static void main(String[] args) {
        Scanner input = new Scanner (System.in);
        System.out.print ("How many numbers would you like to enter? ");
        int numin = input.nextInt();
        System.out.print ("Number 1: ");
        int num1 = input.nextInt();
        int min1 = num1;
        int min2 = num1;
        for (int i=2; i<=numin; i++)  {
            System.out.print ("Number " + i + ": ");
            int num2 = input.nextInt();
            if (num2 >= min1 && num2 < min2) {
                min2 = num2;
            }
            if (num2 < min1) {
                min2 = min1;
                min1 = num2;
            }
        }
        System.out.println("The two smallest numbers are " + min1 + " and " + min2);
    }
}

I don't necessarily want someone to outright give me the answer but even a hint as to what I might try would be greatly appreciated. Thanks very much in advance for your help!!

Thanks so much aussiemcgr, that is very helpful and those are some good tips. Unfortunately I think you misinterpreted the question a little bit. When it says the user will enter a value greater than 1, this is in reference to the number of numbers that the user wants to input, not the numbers themselves. So I don't think setting the two min values to -1 will work since the numbers can be any value, positive or negative. I have rewritten my code a little bit to incorporate your tips and try to make it a little cleaner but I am still running into trouble. Here is the code:

// Import java utils so we can use user input
import java.util.*;
 
public class Assignment5Q1 {
    public static void main(String[] args) {
        Scanner input = new Scanner (System.in);
//      Prompt user for the number of numbers they want to enter
        System.out.print ("How many numbers would you like to enter? ");
        int numin = input.nextInt();
        System.out.print ("Number 1: ");
        int num1 = input.nextInt();
//      Assigns the two minimum values to the first value entered by the user
        int min1 = num1;
        int min2 = num1;
//      Continues to prompt user for numbers and evaluate the minimum values on the fly
        for (int i=1; i<numin; i++)  {
            System.out.print ("Number " + (i+1) + ": ");
            int num2 = input.nextInt();
//          Series of conditional statements that determines what the minimum values
//          entered by the user are.
            if (num2 <= min1) {
                min2 = min1;
                min1 = num2;
            } else if (num2 < min2) {
                min2 = num2;
            } else if (min1 == min2)   {
                min2 = num2;
            }
        }
//      Prints the two minimum integers that the user input
        System.out.println("The two smallest numbers are " + min1 + " and " + min2);
    }
}

Now the issue I am having is that if you input the smallest value, say 1, and then a larger value and then 1 again and then another larger value, it determines the two smallest numbers to be 1 and the last value, rather than 1 and 1. For example:

How many numbers would you like to enter? 4
Number 1: 1
Number 2: 5
Number 3: 1
Number 4: 3
The two smallest numbers are 1 and 3

Clearly this is wrong and the two smallest numbers should be 1 and 1. Is there something very simple I am missing here? I cant figure this one out!

Thanks again in advance!

Hi aussiemcgr thanks again for your quick reply. I do see what you are saying however if I remove that statement I am back to where I started where if the first number entered is the smallest number, min1 and min2 will be displayed as that number. For example...

        for (int i=1; i<numin; i++)  {
            System.out.print ("Number " + (i+1) + ": ");
            int num2 = input.nextInt();
//          Series of conditional statements that determines what the minimum values
//          entered by the user are.
            if (num2 <= min1) {
                min2 = min1;
                min1 = num2;
            } else if (num2 < min2) {
                min2 = num2;
//            } else if (min1 == min2)   {
//                min2 = num2;
            }
        }
//      Prints the two minimum integers that the user input
        System.out.println("The two smallest numbers are " + min1 + " and " + min2);
    }
}

Gives me...

How many numbers would you like to enter? 4
Number 1: 1
Number 2: 2
Number 3: 2
Number 4: 2
The two smallest numbers are 1 and 1

When the two smallest numbers should be 1 and 2.

Any more suggestions?

Thanks again