Thread: how to loop a method?

When does this return true?

Originally Posted by LeslieInNorthPole

//...............
   public Boolean isSuspended (){
 
       if (numTickets >= 2)
            return false;
       return false;
    }//.................

When does this return false?

Originally Posted by LeslieInNorthPole

//.....................
   public Boolean addTicket() {
      numTickets ++;
      if (numTickets >= 2)
    return true;
      return true; 
   //<--can I get addTicket to run through isSuspended with the new value of numTicket or do I need to //redo this?
   }//....................

Originally Posted by LeslieInNorthPole

public class DLTest
{
    // main() method
    public static void main(String[] args)
    {
        // declare and create two DrivingLicense objects
        DrivingLicense d1 = new DrivingLicense();
        DrivingLicense d2 = new DrivingLicense();
       //private String name;
        //public class DrivingLicense (String name){
               //citizen = name;
        //public void set
 
        // initialize the objects with names and speeding tickets
        d1.name = "Alice";
        d1.numTickets = 2;
 
        d2.name = "Bob";
        d2.numTickets = 0;
 
 
 
/* The code starting here ---------------------------------------------------------- */
        // check if Alice or Bob have suspended licenses (more than 2 tickets)
        if ( d1.isSuspended() )
        {
            System.out.println(d1.name + " has a suspended license!");
        }
        else
        {
            System.out.println(d1.name + " does NOT have a suspended license");
        }
 
        if ( d2.isSuspended() )
        {
            System.out.println(d2.name + " has a suspended license!");
        }
        else
        {
            System.out.println(d2.name + " does NOT have a suspended license");
        }
/* and ending here ----------------------------------------------------------------- */
 
 
 
        // Alice and Bob both get caught speeding, so add another ticket for each of them
        System.out.println("Bob and Alice are both caught speeding!");
       d1.addTicket();
        d2.addTicket();
 
 
/* looks like a repeat of the code starting here ------------------------------------------------ */
        // check again if Alice or Bob have suspended licenses (more than 2 tickets)
        if ( d1.isSuspended() )
        {
            System.out.println(d1.name + " has a suspended license!");
        }
        else
        {
            System.out.println(d1.name + " does NOT have a suspended license");
        }
 
        if ( d2.isSuspended() )
        {
            System.out.println(d2.name + " has a suspended license!");
        }
        else
        {
            System.out.println(d2.name + " does NOT have a suspended license");
        }
/* and ending here --------------------------------------------------------------------------------- */
 
    }
 
}

Any time you have repeated code, you have missed the opportunity to make a method which can be reused.

thanks for the input. I did get it figured out. I didn't need a loop, I needed to find a way to call a method within the same class. Here is the reworked code.

public class DrivingLicense {
String  name; 
   int  numTickets, A; 
  public DrivingLicense() { 
  }
    public DrivingLicense (String name, int numTickets){
    this.name = name; 
    this.numTickets = numTickets;
    }
   public Boolean isSuspended (){
       return (numTickets > 2);}          
 public Boolean addTicket(){
           A = numTickets++; 
           A = numTickets; 
           if (numTickets > 2){
               if (isSuspended ()){ 
                   return (numTickets > 2);
               }}
      return false;
    }
    }

Originally Posted by LeslieInNorthPole

...

//...
 public Boolean addTicket(){
           A = numTickets++; 
           A = numTickets; 
           if (numTickets > 2){
               if (isSuspended ()){ 
                   return (numTickets > 2);
               }}
      return false;
    }//...

I'm not too sure about this section of code, for the following reasons.
1) this method returns a boolean. This method adds a ticket to the ticket count. I don't understand what the return boolean would ever be used for.
2) A = numTickets++; followed by A = numTickets; I don't know what you were trying to do with those two lines of code. It looks to me like all you wanted to do was increase and store the number of tickets. If that is the case just using numTickets++; would do that, and you do not even need the variable A at all.
3) The next three lines of code:
if(numTickets > 2) {
if(isSuspended()) {
return(numTickets > 2);
All three lines test if numTickets is greater than 2. Three times in a row. But it seems to me testing that is more like testing isSuspended, and has nothing to do with adding a ticket. I don't think you need this method to return anything really. Just have a side effect of updating numTickets. If you need to check for license suspended after adding a ticket, use the method you wrote for that rather than trying to make one method do two things.

1) I changed it to a String, allowing for isSuspended method to be called after the numTickets update.
2) good point, simple is better
3) I eliminated the extra tests and changed the addTicket to a string with a return of name just so the program will run.

Thanks for the second look

Originally Posted by LeslieInNorthPole

1) I changed it to a String, allowing for isSuspended method to be called after the numTickets update.2) good point, simple is better
3) I eliminated the extra tests and changed the addTicket to a string with a return of name just so the program will run.

I would think that method could be as simple as:

public void addTicket() {
    numTickets++;
}

...where the method does exactly one thing. Raise the number of tickets by one. Methods are not required to always have a return value. That is where void comes in. It basically means you want a method to have a side effect (add 1 to numTickets) when used, and not send any information back to the point where it was called.

Originally Posted by LeslieInNorthPole

Thanks for the second look

You are welcome. We are happy to help any way we can.