Boolean Method Problem

**DarkestLord** · September 22nd, 2014, 04:04 PM

I'm writing a program called Curse Detector. The idea is that you answer 5 questions and this program tells you if an item is cursed.

The item is cursed if:
1) The item adds +6 or less to the player's AC bonus AND is worth less than 250,000 gold pieces AND either provides Energy Immunity or Weapon Breaking

2) Adds more than +6 to AC and does not provide Energy Immunity

3) Summons Monsters

I am using two classes, and interface, and CinReader.

My problem is that: no matter what I put into the test, it tells me that the item is cursed, even if it shouldn't be.

Here's the interface:

public interface CurseDetector
{
    /**
     * Welcome to the Curse Detector program. This program will help you determine if your magical items are cursed
     *
     * @param  addsLessThan7   true if greater than 6.
     * @param  worthOver250K   true if worth more than 250,000 gold peices
     * @param  energyImmunity  true if it provides energy immunity
     * @param  weaponBreaking  true if it provides weapons breaking
     * @param  summonsMonsters true if it provides monster summoning
     *
     * @return   true if likely cursed, false if likely not cursed
     */
    public boolean detectCurse(boolean addsLessThan7,
                        boolean worthOver250K,
                        boolean energyImmunity,
                        boolean weaponBreaking,
                        boolean summonsMonsters
                        );
}

Here's the AberrationsDetector:

/**
 * Write a description of class AberrationsDetector here.
 *
 * @author Erik Ingvoldsen
 * @version 1.0
 */
public class AberrationsDetector implements CurseDetector
{
    boolean returnBoolean=false;
    public boolean detectCurse(boolean addsLessThan7, boolean worthOver250K,boolean energyImmunity, boolean weaponBreaking, boolean summonsMonsters)
    {
            if(summonsMonsters=true){
            returnBoolean=true;
            }else{
            if(summonsMonsters=false){
            if(addsLessThan7==true){
            if(worthOver250K==false){
            if(energyImmunity==true){
            returnBoolean=true;
            }
            else if(weaponBreaking==true){
            returnBoolean=true;
            }
            else if(energyImmunity||weaponBreaking==true){
            returnBoolean=false;
            }
            }
            }else{
            if(addsLessThan7==false){
            if(energyImmunity=false){
            returnBoolean=true;
            }
            }
            }
            }else{
            returnBoolean=false;
            }
            }
return returnBoolean;
}
}

And here is the test:

/**
 * A tool designed to use the Curse Detector
 *
 * @author Erik Ingvoldsen
 * @version 1.0
 */
public class CurseTest
{
static CinReader Cin= new CinReader();
public CurseTest()
{
    System.out.println("Welcome to the Curse Detector program.");
    System.out.println("his program will help you determine if your magical items are cursed.");
    System.out.println("Here are a few questions for  you:");
    System.out.println("    ");
    Question1();
}
public static void Question1(){
    System.out.println("What AC advantage does the magic item provide? (Enter an integer)");
    int Q1=Cin.readInt();
    if(Q1>6){
    boolean addsLessThan7=true;
    }else{
    boolean addsLessThan7=false;
    }
    Question2();
}
public static void Question2(){
    System.out.println("    ");
    System.out.println("How much is the magic item worth? (Enter an integer)");
    int Q2=Cin.readInt();
    if(Q2>250000){
    boolean worthOver250K=true;
    }else{
    boolean worthOver250K=false;
    }
    Question3();
}
public static void Question3(){
    System.out.println("    ");
    System.out.println("Does the item provide Energy Immunity? (Yes or No)");
    String Q3=Cin.readString();
    if(Q3.equals("yes")){
    boolean energyImmunity=true;
    }else if(Q3.equals("no")){
    boolean energyImmunity=false;
    }else{
    System.out.println("Not a valid answer. Do not use any capital letters.");
    Question3();
    }
    Question4();
}
public static void Question4(){
    System.out.println("    ");
    System.out.println("Does the item provide Weapon Breaking? (Yes or No)");
    String Q4=Cin.readString();
    if(Q4.equals("yes")){
    boolean weaponBreaking=true;
    }else if(Q4.equals("no")){
    boolean weaponBreaking=false;
    }else{
    System.out.println("Not a valid answer. Do not use any capital letters.");
    Question4();
    }
    Question5();
}
public static void Question5(){
    System.out.println("    ");
    System.out.println("Does the item Summon Monsters? (Yes or No)");
    String Q5=Cin.readString();
    if(Q5.equals("yes")){
    boolean summonsMonsters=true;
    }else if(Q5.equals("no")){
    boolean summonsMonsters=false;
    }else{
    System.out.println("Not a valid answer. Do not use any capital letters.");
    Question5();
    }
    Answer();
}
public static void Answer(){
    AberrationsDetector myDetector= new AberrationsDetector();
    myDetector.detectCurse(false, false, false, false, false);
    System.out.println("    ");
    if(myDetector.detectCurse(false, false, false, false, false)==true){
    System.out.println("This time is cursed!");
    }else{
    System.out.println("This item is not cursed.");
    }
}
}

**Cornix** · September 22nd, 2014, 04:31 PM

I would guess its probably an error because of improper indention.
Indent all your curly brackets correctly as per the java style convention and you are probably going to be able to see the mistake yourself.
Another note: Why do you use a boolean variable in your AberrationsDetector class? The variable seems completely redundant. Just return the correct boolean value when you know it.
Furthermore, you might want to think about applying the logical AND and/or OR operators to your boolean variables. You could probably save a lot of if-then-else statements this way.

**DarkestLord** · September 24th, 2014, 03:34 AM

Originally Posted by Cornix

Another note: Why do you use a boolean variable in your AberrationsDetector class? The variable seems completely redundant. Just return the correct boolean value when you know it.

Uhhh how would I go about this? ^^;

Originally Posted by Cornix

Furthermore, you might want to think about applying the logical AND and/or OR operators to your boolean variables. You could probably save a lot of if-then-else statements this way.

Could you give me an example? I'm still learning things like this.

**Cornix** · September 24th, 2014, 03:48 AM

You defined the outcome of your method like this:

The item is cursed if:
1) The item adds +6 or less to the player's AC bonus AND is worth less than 250,000 gold pieces AND either provides Energy Immunity or Weapon Breaking
2) Adds more than +6 to AC and does not provide Energy Immunity
3) Summons Monsters
I am using two classes, and interface, and CinReader.

And you have a method with a signature like this:

    public boolean detectCurse(boolean addsLessThan7,
                        boolean worthOver250K,
                        boolean energyImmunity,
                        boolean weaponBreaking,
                        boolean summonsMonsters
    );

So what you can do is simply this:

    public boolean detectCurse(boolean addsLessThan7,
                        boolean worthOver250K,
                        boolean energyImmunity,
                        boolean weaponBreaking,
                        boolean summonsMonsters
	) {
		if (addsLessThan7 && worthOver250K && (energyImmunity || weaponBreaking)) {
			return true;
		}
		if (!worthOver250K && !energyImmunity) {
			return true;
		}
		if (summonsMonsters) {
			return true;
		}
		return false;
	}

This is just a 1:1 translation of your text to code. Study the logical operators "&&", "||" and "!".
The && is a logical AND; the boolean A && B is only true if both A and B are true.
The || is a logical OR; the boolean A || B is only true if neither A nor B are false.
The ! is a logical negation; the boolean !A is only true if A is false.

Using these you can combine multiple boolean values to one which drastically cuts down the amount of code you have and makes everything more readable and maintainable.

Of course, you should always keep in mind, that your error might also be in the other parts of your program. It does not necessarily have to be your "CurseDetector" implementation.

**DarkestLord** · September 24th, 2014, 11:12 AM

Oh! I wasn't familiar with &&! Thanks! The program still isn't working, but this is very helpful!

Hmmm...the only other thing I can think of is the way I coded the test. When I call the method, I call it like this:

myDetector.detectCurse(false, false, false, false, false);

Because I'm not sure what else I could put in there (aside from true, true, true, true, true). Would this affect my results?

**aussiemcgr** · September 24th, 2014, 11:25 AM

myDetector.detectCurse(false, false, false, false, false);

Because I'm not sure what else I could put in there (aside from true, true, true, true, true). Would this affect my results?

What about: myDetector.detectCurse(true, false, false, false, false);
Or: myDetector.detectCurse(false, false, false, false, true);
Or: myDetector.detectCurse(false, true, true, false, false);
Or any of the other (I'm going to guess: hundreds) of differences?

**Cornix** · September 24th, 2014, 11:53 AM

I would say its 2^5 different combinations, but thats just an educated guess.

You probably want to save the input from the user in private member variables and then send the input to your CurseDetector implementation at the end.

**aussiemcgr** · September 24th, 2014, 12:02 PM

I would say its 2^5 different combinations, but thats just an educated guess.

I think that permutations...? Can't remember that stuff, lol. Although I admit it probably isn't hundreds.

**DarkestLord** · September 24th, 2014, 02:42 PM

OK, this IS the problem. It's connected to the input somehow. If I do true, true, true, true, true, the fifth "true" for "Summons Monsters" is always true, which means the item is always cursed. I tried making it "true, true, false, false, false" and now it's never cursed, regardless of input. Now sure what I can do to fix this though....hmmmm...

**Cornix** · September 24th, 2014, 02:46 PM

You have to use the input from the user. You must NOT use "true" or "false" at all when calling the method. Use variables that store what the user has entered.

**DarkestLord** · September 24th, 2014, 03:12 PM

OK, updated the detector and the test...

Currently the program is still telling me the item is cursed no matter what though. I think the problem is in the test, but I'm not sure what it is...

Test:

/**
 * A tool designed to use the Curse Detector
 * 
 * @author Erik Ingvoldsen
 * @version 1.0
 */
public class CurseTest
{
static CinReader Cin= new CinReader();
static boolean addsLessThan7;
static boolean worthOver250K;
static boolean energyImmunity;
static boolean weaponBreaking;
static boolean summonsMonsters;
public CurseTest()
{
    System.out.println("Welcome to the Curse Detector program.");
    System.out.println("his program will help you determine if your magical items are cursed.");
    System.out.println("Here are a few questions for  you:");
    System.out.println("    ");
    Question1();
}
public static void Question1(){
    System.out.println("What AC advantage does the magic item provide? (Enter an integer)");
    int Q1=Cin.readInt();
    if(Q1>6){
    boolean addsLessThan7=true;
    }else{
    boolean addsLessThan7=false;
    }
    Question2();
}
public static void Question2(){
    System.out.println("    ");
    System.out.println("How much is the magic item worth? (Enter an integer)");
    int Q2=Cin.readInt();
    if(Q2>250000){
    boolean worthOver250K=true;
    }else{
    boolean worthOver250K=false;
    }
    Question3();
}
public static void Question3(){
    System.out.println("    ");
    System.out.println("Does the item provide Energy Immunity? (yes or no)");
    String Q3=Cin.readString();
    if(Q3.equals("yes")){
    boolean energyImmunity=true;
    }else if(Q3.equals("no")){
    boolean energyImmunity=false;
    }else{
    System.out.println("Not a valid answer. Do not use any capital letters.");
    Question3();
    }
    Question4();
}
public static void Question4(){
    System.out.println("    ");
    System.out.println("Does the item provide Weapon Breaking? (yes or no)");
    String Q4=Cin.readString();
    if(Q4.equals("yes")){
    boolean weaponBreaking=true;
    }else if(Q4.equals("no")){
    boolean weaponBreaking=false;
    }else{
    System.out.println("Not a valid answer. Do not use any capital letters.");
    Question4();
    }
    Question5();
}
public static void Question5(){
    System.out.println("    ");
    System.out.println("Does the item Summon Monsters? (yes or no)");
    String Q5=Cin.readString();
    if(Q5.equals("yes")){
    boolean summonsMonsters=true;
    }else if(Q5.equals("no")){
    boolean summonsMonsters=false;
    }else{
    System.out.println("Not a valid answer. Do not use any capital letters.");
    Question5();
    }
    Answer();
}
public static void Answer(){
    AberrationsDetector myDetector= new AberrationsDetector();
    myDetector.detectCurse(addsLessThan7, worthOver250K, energyImmunity, weaponBreaking, summonsMonsters);
    System.out.println("    ");
    if(myDetector.detectCurse(addsLessThan7, worthOver250K, energyImmunity, weaponBreaking, summonsMonsters)==true){
    System.out.println("This time is cursed!");
    }else{
    System.out.println("This item is not cursed.");
    }
}
}

Detector:

/**
 * Write a description of class AberrationsDetector here.
 *
 * @author Erik Ingvoldsen
 * @version 1.0
 */
public class AberrationsDetector implements CurseDetector
{
       public boolean detectCurse(boolean addsLessThan7,
                        boolean worthOver250K,
                        boolean energyImmunity,
                        boolean weaponBreaking,
                        boolean summonsMonsters) 
{
		if (addsLessThan7 && !worthOver250K && (energyImmunity || weaponBreaking)) {
			return true;
		}
		if (!addsLessThan7 && !energyImmunity) {
			return true;
		}
		if (summonsMonsters) {
			return true;
		}
		return false;
}
}

**Cornix** · September 24th, 2014, 03:27 PM

You are getting closer, but you still have a little error in your class "CurseTest".
The problem is, that your variables are never changed. They will always keep their initial value, that is "false".

This is because you create new local variables in your methods Question1 - Question5. You change the values of these new variables, but the old ones will never get changed.

**DarkestLord** · September 24th, 2014, 03:41 PM

Originally Posted by Cornix

This is because you create new local variables in your methods Question1 - Question5. You change the values of these new variables, but the old ones will never get changed.

Ahhh...but...what makes them new? They are called the same thing in each question? I tried removing "boolean" in front of the question variables, but the problem remains. Is it something else that makes them "new" local variables?

Edit: Oh wait! I had the first question wrong! It was supposed to be Q1<6, not Q1>6!

Thanks guys, the programs working now!

**Cornix** · September 24th, 2014, 03:56 PM

If you write "boolean a = true;" you create a new boolean variable called "a" and assign the value "true" to it. If you just write "a = true" you assign the value "true" to a previously defined variable "a". If no variable "a" was previously defined you will get an error.

Thread: Boolean Method Problem

LinkBack

Thread Tools

Display

Boolean Method Problem

Related threads:

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Re: Boolean Method Problem

Similar Threads

Boolean method help!

I need a little help with a boolean method.

Boolean Method Test Problem

Need help with boolean method! =(

Boolean method returning a boolean value