Thread: Time Class problem

Originally Posted by Norm

The code is missing the ending }s


Does the code you have compile and execute?
If not, copy the full text of any error messages and paste them here if you need help.

it works but i dont recive the second output as 17:45 but as 00:00

Originally Posted by Norm

Sorry, I don't see how the posted code can work with the missing parts.
Please post the complete code that will compile and execute and create some output.


I'm done for tonight. Back tomorrow.

package com.company;
public class Time1StudentTester
{
    public static void main(String [] args) {
 
        System.out.println("\n********** Test Time1 - Started **********\n");
        System.out.println("\n1. Testing Constructors and toString:");
        Time1 t1 = new Time1(17, 45);
        System.out.println("\tt1=" + t1);
        Time1 t2 = new Time1(t1);
        System.out.println("\tt2=" + t2);
        System.out.println("\n********** Test Time1 - Finished **********\n");
 
    }
}

this outputs the next

1. Testing Constructors and toString:
	t1=17:45
	t2=00:00

and i need it to be the same

Originally Posted by Norm

Where is the code for the Time1 class?

package com.company;
 
public class Time1 {
    private  int _hour;
    private  int _minute;
 
    public Time1(int h, int m)
    {
        this._hour   = (((h >= 0) && (h < 23)) ? h : 0);
        this._minute = (((m >= 0) && (m < 59)) ? m : 0);
    }
    public String toString()
    {
        return String.format("%02d:%02d",_hour,_minute);
    }
}

Originally Posted by Norm

That code does not compile without errors.
The code must compile without errors to be able to execute it for testing.

If you have code that compiles without errors, please post it.

thats why i need help understand how to continue from here

Originally Posted by Norm

Please copy the full text of the error messages you get and paste it here if you need help fixing it.

Error:(11, 20) java: constructor Time1 in class com.company.Time1 cannot be applied to given types;
  required: int,int
  found: com.company.Time1
  reason: actual and formal argument lists differ in length

Originally Posted by Norm

Ok, that error says the Time1 class needs a constructor that takes a Time1 object as an argument.
You posted some code in post#13 that declared a constructor but did not have any statements in it to get the needed data from the Time1 object that was passed to the constructor.

so again same question how do i continue from this spot ?????

Originally Posted by Norm

The error message says you need a constructor that takes a Time1 object as its argument.
The code in post#13 declares that constructor.
Copy that code into the class's declaration.
Add code to that constructor that copies the values from the Time1 object into the class's variables.

        return  String.format ("%02d:%02d",_hour,_minute);

this line can be replaced and still get same result ??? i just figured it out that i cant use string.format

Originally Posted by Norm

Replaced with what? Post the new code that gives the same results.



Why not? If you get errors, copy the full text and paste it here.

i am asking if it can be replaced and if it can than with what ???

are you sure you know java ???? cause for now your not helping at all

Originally Posted by Norm

I am not able to look over your shoulder to see what you are doing. I need you to post the code that is giving the problem and the error messages it gives so I can help.


I have been posting on this forum since 2010 and have posted over 22K times.

i am posting over and over and over and one more time over

package com.company;
import com.company.Time1;
public class Time1StudentTester
{
    public static void main(String [] args) {
 
        System.out.println("\n1. Testing Constructors and toString:");
        Time1 t1 = new Time1(17, 45);
        System.out.println("\tt1=" + t1);
        Time1 t2 = new Time1(t1);
        System.out.println("\tt2=" + t2);
 
        System.out.println("\n2. Testing accessors and mutators:");
        t1.setHour(20);
        t1.setMinute(10);
        System.out.println("\tt1=" + t1);
        System.out.println("\tHour   of t1=" + t1.getHour());
        System.out.println("\tMinute of t1=" + t1.getMinute());
 
 
 
        System.out.println("\n4. Testing equals method:");
        Time1 t3=new Time1(12, 34);
        Time1 t4=new Time1(23, 45);
        System.out.println("\tt3=" + t3);
        System.out.println("\tt4=" + t4);
        if(t3.equals(t4))
            System.out.println("\tt3 is the same time as t4");
        else
            System.out.println("\tt3 isn't the same time as t4");
 
        System.out.println("\n5. Testing before method:");
 
 
        System.out.println("\n6. Testing after method:");
 
 
        System.out.println("\n7. Testing difference method:");
        t1=new Time1(11, 25);
        t2=new Time1(10, 15);
        System.out.println("\tt1=" + t1);
        System.out.println("\tt2=" + t2);
 
 
        System.out.println("\n8. Testing addMinutes method:");
        System.out.println("\tt1=" + t1);
 
 
        System.out.println("\n********** Test Time1 - Finished **********\n");
    }
}

this is the code test for the class file Time1.java
now this is the final output i need to recive

********** Test Time1 - Started **********
 
 
1. Testing Constructors and toString:
	t1=17:45
	t2=17:45
	t33=00:00
 
2. Testing accessors and mutators:
	t1=20:10
	Hour   of t1=20
	Minute of t1=10
 
2. Testing out of range setters:
	t1=00:00
	Hour   of t33=0
	Minute of t33=0
 
3. Testing minFromMidnight method:
	t1=10:15
	Minutes from midnight of t1=615
 
3. Testing minFromMidnight method:
	t33=00:00
	Minutes from midnight of t33=0
 
3. Testing minFromMidnight method:
	t1=23:59
	Minutes from midnight of t1=1439
 
4. Testing equals method:
	t3=12:34
	t4=23:45
	t33=23:45
	t3=12:34 = t4=23:45 ? false
	t33=23:45 = t4=23:45 ? true
	t34=23:46 = t4=23:45 ? false
	t35=22:45 = t4=23:45 ? false
 
5. Testing before method:
	t3=12:34 before t4=23:45 ? true
	t33=23:45 before t4=23:45 ? false
	t34=23:46 before t4=23:45 ? false
	t35=22:45 before t4=23:45 ? true
	t35=23:44 before t4=23:45 ? true
 
6. Testing after method:
	t3=12:34 after t4=23:45 ? false
	t33=23:45 after t4=23:45 ? false
	t34=23:46 after t4=23:45 ? true
	t35=22:45 after t4=23:45 ? false
	t35=23:44 after t4=23:45 ? false
 
	t4=23:45 after t3=12:34 ? true
	tt4=23:45 after t33=23:45 ? false
	tt4=23:45 after t34=23:46 ? false
	tt4=23:45 after t35=22:45 ? true
	tt4=23:45 after t36=23:44 ? true
 
7. Testing difference method:
	t1=11:25
	t2=10:15
	The difference between 11:25 and 10:15 is : 70 min
	The difference between 23:45 and 23:45 is : 0 min
	The difference between 23:45 and 23:46 is : -1 min
	The difference between 23:45 and 22:45 is : 60 min
	The difference between 23:45 and 23:44 is : 1 min
 
8. Testing addMinutes method:
	t1=11:25
	Adding 10 minutes to t1=11:35
	Adding 20 minutes to 23:45= 00:05
	Adding 48 hours and -5 min to 23:45= 23:40
	Adding 48 hours and +5 min to 23:45= 23:50
	Adding 48 hours to 23:45= 23:45
	Adding -48 hours to 23:45= 23:45
	Adding -48 hours to 23:45= 23:45
	Adding -10 minutes to 00:05= 23:55
	Adding -48 hours and -6 min to 00:05= 23:59
	Adding -48 hours and +6 min to 00:05= 00:11
 
********** Test Time1 - Finished **********

and now this is my time1 class file

package com.company;
public class Time1
{
    private  int _hour;
    private  int _minute;
    public Time1(int h, int m)
    {
        this._hour   = (((h >= 0) && (h < 23)) ? h : 0);
        this._minute = (((m >= 0) && (m < 59)) ? m : 0);
    }
    public Time1(Time1 t2)
    {
        getHour ();
        getMinute ();
    }
 
    public int getHour()
    {
        return _hour;
    }
    public int getMinute()
    {
        return _minute;
    }
    public void setHour(int _hour)
    {
        this._hour = _hour;
    }
    public void setMinute(int _minute) {
        this._minute = _minute;
    }
}

from here how do i need to continue to eventually recive the final output

********** Test Time1 - Started **********
 
 
1. Testing Constructors and toString:
	t1=17:45
	t2=17:45
	t33=00:00
 
2. Testing accessors and mutators:
	t1=20:10
	Hour   of t1=20
	Minute of t1=10
 
2. Testing out of range setters:
	t1=00:00
	Hour   of t33=0
	Minute of t33=0
 
3. Testing minFromMidnight method:
	t1=10:15
	Minutes from midnight of t1=615
 
3. Testing minFromMidnight method:
	t33=00:00
	Minutes from midnight of t33=0
 
3. Testing minFromMidnight method:
	t1=23:59
	Minutes from midnight of t1=1439
 
4. Testing equals method:
	t3=12:34
	t4=23:45
	t33=23:45
	t3=12:34 = t4=23:45 ? false
	t33=23:45 = t4=23:45 ? true
	t34=23:46 = t4=23:45 ? false
	t35=22:45 = t4=23:45 ? false
 
5. Testing before method:
	t3=12:34 before t4=23:45 ? true
	t33=23:45 before t4=23:45 ? false
	t34=23:46 before t4=23:45 ? false
	t35=22:45 before t4=23:45 ? true
	t35=23:44 before t4=23:45 ? true
 
6. Testing after method:
	t3=12:34 after t4=23:45 ? false
	t33=23:45 after t4=23:45 ? false
	t34=23:46 after t4=23:45 ? true
	t35=22:45 after t4=23:45 ? false
	t35=23:44 after t4=23:45 ? false
 
	t4=23:45 after t3=12:34 ? true
	tt4=23:45 after t33=23:45 ? false
	tt4=23:45 after t34=23:46 ? false
	tt4=23:45 after t35=22:45 ? true
	tt4=23:45 after t36=23:44 ? true
 
7. Testing difference method:
	t1=11:25
	t2=10:15
	The difference between 11:25 and 10:15 is : 70 min
	The difference between 23:45 and 23:45 is : 0 min
	The difference between 23:45 and 23:46 is : -1 min
	The difference between 23:45 and 22:45 is : 60 min
	The difference between 23:45 and 23:44 is : 1 min
 
8. Testing addMinutes method:
	t1=11:25
	Adding 10 minutes to t1=11:35
	Adding 20 minutes to 23:45= 00:05
	Adding 48 hours and -5 min to 23:45= 23:40
	Adding 48 hours and +5 min to 23:45= 23:50
	Adding 48 hours to 23:45= 23:45
	Adding -48 hours to 23:45= 23:45
	Adding -48 hours to 23:45= 23:45
	Adding -10 minutes to 00:05= 23:55
	Adding -48 hours and -6 min to 00:05= 23:59
	Adding -48 hours and +6 min to 00:05= 00:11
 
********** Test Time1 - Finished **********

and again this is the final output i need to recive i am brand new to java so help me please reach this output

Originally Posted by Norm

Ok, it is better to work on one problem at a time.
What is the program's current output? Copy the program's output and paste it here.
Add some comments to the print out showing where it needs to be changed.
For example:

1. Testing Constructors and toString:
	t1=17:45
	t2=17:45
	t33=00:00   <<<<<<<<< THIS should be t33=11:22

Did you see my comments about one of the Time1's constructors? It needs to be changed to get the values from the passed argument and saved in the current object.

1. Testing Constructors and toString:
	t1=com.company.Time1@1b6d3586
	t2=com.company.Time1@4554617c
 
2. Testing accessors and mutators:
	t1=com.company.Time1@1b6d3586
	Hour   of t1=20
	Minute of t1=10
 
4. Testing equals method:
	t3=com.company.Time1@74a14482
	t4=com.company.Time1@1540e19d
	t3 isn't the same time as t4
 
5. Testing before method:
 
6. Testing after method:
 
7. Testing difference method:
	t1=com.company.Time1@677327b6
	t2=com.company.Time1@14ae5a5
 
8. Testing addMinutes method:
	t1=com.company.Time1@677327b6
 
********** Test Time1 - Finished **********

current output