Thread: whats wrong with this one....

public class Sample {
 
 
    private static int selection = Integer.parseInt(JOptionPane.showInputDialog(
                                   null, "Please Selecti"));;
 
    public static boolean Condition() {
 
        if (selection >= 4) {
 
            JOptionPane.showMessageDialog(null, "There are only three choices!");
            return true;
        }
        else if (selection <= 0) {
 
            JOptionPane.showMessageDialog(null, "You didn't Make A Choice!");
            return true;
        }
        else {              //if i remove this else block the program will ask
                            //for a return statement
            return false;
        }
    }
 
    public void selection() {
 
        switch (selection) {
 
            case 1:
 
                JOptionPane.showMessageDialog(null, "Chocolate");
                break;
 
            case 2:
 
                JOptionPane.showMessageDialog(null, "Vanilla");
                break;
 
            case 3:
 
                JOptionPane.showMessageDialog(null, "Banana");
                break;
        }
    }
 
    public static void main(String[] args) {
 
        do {
 
            Sample a = new Sample();
 
            a.selection();
        }
        while (Condition());
    }
}

try to run it in false condition...
in true condition everything is fine but whats going on in false condition.

If I run this and input 3 the loop will stop because the condition method returns false, and thats what you want isnt it, because the user selected a value (3) which is a valid value between 0 and 4.

As long as the user puts a zero, negative or a positive value higher than 3 you will keep showing him/her the input box, but if the value is within the right range, return false and the loop stops.

You need to figure out exactly what you want to happen, design your flow and then you will know how its supposed to work and why it isnt working like you want it to.

What is your intention with this code?

// Json

i really owe you a lot sir JSON... actually that program was ryt,this is the right code

public class ReturnStatementInIfElse_UNCLARIFIED_UNFINISHED {
 
    //IM HAVING SOME PROBLEM IN FALSE CONDITION
    // RUN THE PROGRAM IN FALSE CONDITION
    //YOU WILL SEE THE PROBLEM
    //I DECLARED THE selection as an input variable
    private static int selection;
 
 
    public static boolean Condition() {
 
        if (selection >= 4) {
 
            JOptionPane.showMessageDialog(null, "There are only three choices!");
            return true;
        }
        else if (selection <= 0) {
 
            JOptionPane.showMessageDialog(null, "You didn't Make A Choice!");
            return true;
        }
        else {              //if i remove this else block the program will ask
                            //for a return statement
            return false;
        }
    }
 
    public void selection() {
 
        selection = Integer.parseInt(JOptionPane.showInputDialog(
                                   null, "Please Selecti"));
 
        switch (selection) {
 
            case 1:
 
                JOptionPane.showMessageDialog(null, "Chocolate");
                break;
 
            case 2:
 
                JOptionPane.showMessageDialog(null, "Vanilla");
                break;
 
            case 3:
 
                JOptionPane.showMessageDialog(null, "Banana");
                break;
        }
    }
 
    public static void main(String[] args) {
 
        do {
 
            ReturnStatementInIfElse_UNCLARIFIED_UNFINISHED a = new ReturnStatementInIfElse_UNCLARIFIED_UNFINISHED();
 
            a.selection();
        }
        while (Condition());
    }
}

i did this part, the declaration of the class data member selection (at the first part)

    private static int selection = Integer.parseInt(JOptionPane.showInputDialog(
                                   null, "Please Selecti"));

one of my question is... why is it like that when i declared the data member as an input variable?
it became like that one , the first code that i posted....

and i will add another question... what i did is not ryt? or not efficient?

whaa.. i cant express it more briefly but i hope you understand what im trying to imply.... i hope you understand it..

and one more thing.. when I run the first code.. and i input the value in false condition...
the messagebox doesnt stop anymore... and i have to cancel the runtime manualy ... why is it like that?

the point is i just want to understand why is that error happens with the first code...

so its fine to create a data member static/or not static and declare it as an input variable ,
what happens in my program is that my MAIN program which will loop the input cannot repeat it..

ryt?

it will just depends on how where and when will I use that "class"