Thread: please help? simple fix that someone who knows bout java can prolly help me

Originally Posted by joelmeler

it doesnt seem to be working.

So what does it do instead?

I just took a copy of your code and tried to run it. It doesn't paint correctly, so I would start there.

I looked at your code, fixed the Override and made Shooter actually call Player.. it prints two white boxes on either side of a black background

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
 
public class Shooter extends JFrame
{
	/**
	 * serialVersionUID
	 */
	private static final long serialVersionUID = -4420393074204026863L;
	int WIDTH = 500;
	int HEIGHT = 500;
	int x,y = 0;
	int height,width = 0;
	int health = 10;
	Rectangle p1 = new Rectangle(480, 210, 15, 100);
	Rectangle p2 = new Rectangle(0,210,15,100);
 
 
	public Shooter(){
		super("Shooter");
		setSize(WIDTH,HEIGHT);
		setResizable(false);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		setBackground(Color.black);
		setVisible(true);
		Thread t = new Thread(new Player()); //This actually calls the Player class
		t.start(); //Start it!
	}
	public class Player implements KeyListener, Runnable
	{
		public Player()
		{
 
		}
		@Override
		public void run()
		{
			addKeyListener(this);
		}
 
		@Override
		public void keyPressed(KeyEvent event) {}
 
		@Override
		public void keyReleased(KeyEvent event) {}
 
		@Override
		public void keyTyped(KeyEvent event) {
			if(event.getKeyChar()=='o'){
				p1.y--;
			}
 
 
 
 
		}
 
 
 
 
	}
	@Override
	public void paint(Graphics g)
	{
		g.setColor(Color.white);
		g.fillRect(0,210,15,100);
		g.fillRect(p1.x,p1.y, 15, 100);
		p1 = new Rectangle(480, 210, 15, 100);
		p2 = new Rectangle(0,210,15,100);
 
	}
	public static void main(String args[])
	{
		new Shooter();
 
	}
 
}

but then the movement wasn't working.. so I switched it into three classes.

Shooter.java

 
import javax.swing.*;
import java.awt.*;
 
public class Shooter extends JPanel
{
	/**
	 * serialVersionUID
	 */
	private static final long serialVersionUID = -4420393074204026863L;
	public JFrame frame;
	static int WIDTH = 500;
	static int HEIGHT = 500;
	int x,y = 0;
	int height,width = 0;
	int health = 10;
	public Rectangle p1 = new Rectangle(480, 210, 15, 100);
	public Rectangle p2 = new Rectangle(0,210,15,100);
 
 
	public Shooter(JFrame frame)
	{
		this.frame = frame;
	}
 
	@Override
	public void paint(Graphics g)
	{
		Graphics2D g2d = (Graphics2D) g; //I prefer Graphics2D, not sure if it matters
		g2d.fillRect(0, 0, HEIGHT, WIDTH); //Clear the background (This is necessary or it doesn't paint right..)
		g2d.setColor(Color.white);
		g2d.fillRect(0,210,15,100);
		g2d.fillRect(p1.x,p1.y, 15, 100);
		Toolkit.getDefaultToolkit().sync();
		//p1 = new Rectangle(480, 210, 15, 100);
		//p2 = new Rectangle(0,210,15,100);
 
	}
	public synchronized void decrementY() //Make guy go up
	{
		p1.y--;
		repaint();
	}
	public synchronized void incrementY() //Make guy go down
	{
		p1.y++;
		repaint();
	}
 
}

Player.java

import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
 
 
 
public class Player implements KeyListener
{
	private Shooter shooter;
	public Player(Shooter shooter)
	{
		this.shooter = shooter;
	}
	@Override
	public void keyPressed(KeyEvent event) {}
 
	@Override
	public void keyReleased(KeyEvent event) {}
 
	@Override
	public void keyTyped(KeyEvent event) 
	{
		if(event.getKeyChar()=='o')
		{
			shooter.decrementY(); //Make the guy go up
		}else if(event.getKeyChar()=='l')
		{
			shooter.incrementY(); //Make the guy go down
		}
	}
}

Main.java

import java.awt.Color;
 
import javax.swing.JFrame;
 
 
class Main extends JFrame
{
	private static final long serialVersionUID = 1L;
	public Main()
	{
		super("Shooter");
		Shooter s = new Shooter(this);
		add(s); //Add the Shooter
		addKeyListener(new Player(s)); //Add the key listener
		setBackground(Color.black); //Set background
		setDefaultCloseOperation(EXIT_ON_CLOSE); //Make it so it closes
		setSize(Shooter.WIDTH, Shooter.HEIGHT);
		setLocationRelativeTo(null); //Not sure
		setVisible(true); //Set visible
		setResizable(false); //Don't let it get resized
	}
	public static void main(String[] args)
	{
		new Main(); //Self-Explanatory
	}
}

Sorry that I kind of did it for you.. but I added lots of comments