Thread: UDP Port Scanner For Computer Security Module

Greetings all.

I need to implement a UDP port scanner for a university security module but I seem to be having issues. I have checked that everything has a value and that nothing is null. The address has the value it should and the port numbers are those that exist.

I have included the error that I get as well as the code snippet that seems to be the problem.

-- ERROR --
Exception in thread "main" java.lang.NullPointerException: null address || null buffer
at java.net.PlainDatagramSocketImpl.send(Native Method)
at java.net.DatagramSocket.send(Unknown Source)
at PortScanner.scanUDP(PortScanner.java:116)
at PortScanner.scan(PortScanner.java:142)
at PS.main(PS.java:30)

-- CODE SNIPPET -- PortScanner.java

...
	private ArrayList<String> udpServiceNames = null;
	private ArrayList<Integer> udpPortNumbers = null;
	private String IP = null;
...
//Initialization of udpServiceNames  and udpPortNumbers from a file.
//Setting of IP to "127.0.0.1"
...
		File udpOut = new File("UDP_Ports_Status.txt");
		FileOutputStream uout = new FileOutputStream(udpOut);
		DatagramSocket sock = new DatagramSocket();
		for(int i = 0; i < udpServiceNames.size(); i++)
		{
			System.out.print(".");
			InetAddress addr = null;
			try
			{
				addr = InetAddress.getByName(IP);
			}
			catch(UnknownHostException ex)
			{
				System.out.println("Passed original IP name conversion but failed now. Terminating....");
				System.exit(1);
			}
			byte[] buff = new byte[256];
			DatagramPacket pack = new DatagramPacket(buff, 256, addr, udpPortNumbers.get(i).intValue());
			sock.setSoTimeout(500);
			boolean received = false;
			int sendCnt = 0;
			while(!received && sendCnt < 3)
			{
                                //Error refers to the sending of the packet.
				sock.send(pack);
				pack = new DatagramPacket(buff, 256);
				try
				{
					sock.receive(pack);
					received = true;
					break;
				}
				catch(Exception ex)
				{
				}
				sendCnt++;
			}
			String str;
			if(!received)
				str = udpPortNumbers.get(i).intValue() + "::" + udpServiceNames.get(i) + "::CLOSED\r\n";
			else
				str = udpPortNumbers.get(i).intValue() + "::" + udpServiceNames.get(i) + "\r\n";
			uout.write(str.getBytes());
		}
...

java.lang.NullPointerException: null address || null buffer
at java.net.PlainDatagramSocketImpl.send(Native Method)
at java.net.DatagramSocket.send(Unknown Source)
at PortScanner.scanUDP(PortScanner.java:116)

What is going on at statement 116? It looks like a call to the send method. Are any of its arguments null?

Add a println to show what the values are each time around the loop.

Originally Posted by MetalPaw

I have checked that everything has a value and that nothing is null. The address has the value it should and the port numbers are those that exist.

I have already done that with all arguments that make up the DatagramPacket...

What is going on at statement 116?
What are the values of the variables used in that statement?

There is a comment in the code to say where the error is, ie where line 116 is. It is when I attempt to send a DatagramPacket through a DatagramSocket.

sock.send(pack);

Where sock = new DatagramSocket(); and pack = new DatagramPacket(buff, 256, addr, udpPortNumbers.get(i).intValue());
buff is a byte array of length 256 which is created though the elemenets are not initialized. addr is InetAddress.getByName(IP); where IP is a string representing the IP address. udpPortNumbers is an ArrayList of Integers.

I have check to make sure that they all have valid values and nothing is null, as the error suggests.

*facepalm* It's freaking staring at me....

Yes, I was outputing a fullstop to show looping but it never got further than the first one.

Problem is here:

			while(!received && sendCnt < 3)
			{
				sock.send(pack);
				pack = new DatagramPacket(buff, 256);
				...
			}

The pack that is supposed to send it different to the pack that is supposed to be recieved, but I'm simply overwriting it, so duh, the stuff is null. I only check for non-nulls BEFORE the while loop, but inside the while loop the stuff is obviously deleted....

Bleg.

Thanks for the help anyways. Once again, PBKC.

That was exactly what I was asking you to show by using print statements in the loop. It would have shown you that the second time around the loop the value of pack had changed.
Glad you found it finally.

Print the value of sendCnt inside the while loop and you'll be able to work out exactly what's going wrong.
edit: *Splosh* missed the boat!