Thread: bit array and register problem

Does your code even compile? It looks as though it should require a no-args constructor for the array declaration, and you seem to have messed up the no-args constructor in your Bit class, instead creating a method called Bit() that would return a boolean. There's an example of a no-argument constructor near the top of this page:
Providing Constructors for Your Classes (The Java™ Tutorials > Learning the Java Language > Classes and Objects)
You seem also to have not followed the instruction:

you will use boolean for the data type

Please edit your post and remove the code tags from around the text. The folding of the lines makes it hard to read.

The problem I'm having with this code is that my array isn't working with the Bit class above

Can you explain what "isn't working" means.
You get errors.
The results are wrong. If so please show what the results are and explain what they should be.

sean4u:

I don't really understand what the boolean data type means. Does my professor want the output to be true/false or just 0/1?

norm:
The register class isn't compiling at all. I'm getting problems like incompatible type and cannot find symbol. I keep confusing how to use my Bit() class and int().

I'm getting problems

Please copy and paste here the full text of the error messages.

I don't really understand what the boolean data type means

It's a 'primitive data type':
Primitive Data Types (The Java™ Tutorials > Learning the Java Language > Language Basics)

----jGRASP exec: javac -g Register.java

Register.java:11: cannot find symbol
symbol : method reset()
location: class Bit[]
bit[0] = bit.reset();
^
Register.java:21: incompatible types
found : int
required: Bit
bit[bit.length] = 0;
^
Register.java:41: incompatible types
found : int
required: Bit
bit[i] = bit[i].flip();
^
Register.java:46: COMP(Bit[]) in Register cannot be applied to (Bit)
bit[i] = COMP(bit[i]);
^
Register.java:57: cannot find symbol
symbol : variable bit1
location: class Register
Bit[] bit3 = bit1[i] + bit2[i];
^
Register.java:57: cannot find symbol
symbol : variable bit2
location: class Register
Bit[] bit3 = bit1[i] + bit2[i];
^
Register.java:57: incompatible types
found : java.lang.String
required: Bit[]
Bit[] bit3 = bit1[i] + bit2[i];
^
Register.java:65: operator - cannot be applied to Bit,Bit
Bit[] bit3 = bit2[i] - bit1[i];
^
8 errors

bit[0] = bit.reset();

The variable bit is an array. Arrays do not have a method reset().

What are you trying to do with that statement?

bit[bit.length] = 0;

What does the bit array contain? You can only assign values to elements in the array with the data that they are supposed to contain. 0 is an int not a Bit object.

Most of these errors are of the same type. You are mixing apples and oranges.

I defined the reset() method in the class Bit() to set the value of the bit to 0.

What is the variable: bit?
Is it a Bit object?
or is it an array of Bit objects?
You need a Bit object to call the Bit class's methods.

To get a Bit object from an array of Bit objects you'd code something like this: bit[ix]

I had the line
private static Bit[] bit = new Bit[size];
to create a Bit[] with the variable name bit with an array of Bit objects. I want to set the first bit ( bit[0] ) equal to zero, which is what I defined my reset() method is supposed to do.

The code you posted did NOT use bit[0] as the object reference. It was used as a reference to the array.

Go back and see how you coded it.

You need to get a reference to the Bit object and call its method. Something like this:
refToBitObject.itsMethod()

I hate asking stupid questions but I just don't seem to understand.

bit[0] refers to the bit[] array but isn't the bit[] array an array of the Bit object? Doesn't that mean that the bit[0] is also a Bit object?

Or do I have to do something like this:
private Bit bitVariableName = new Bit();

So that bitVariableName refers to the Bit object. Though if I do this, then bitVariableName is no longer an array.

Yes bit[0] is a Bit object and you should use that to call the Bit class's methods.
bit is NOT a Bit object and you can NOT use that to call the Bit class's methods

You coded: bit.reset();
You need to code: bit[0].reset();

okay that makes sense. So now I have this

	public static void LSR(Bit[] bit)
	{
	for (i = 0; i < bit.length; i++)
		{
			bit[i + 1] = bit[i];
			bit[0] = bit[0].reset();
		}
	}

but I'm getting the error:
Register.java:11: incompatible types
found : void
required: Bit
bit[0] = bit[0].reset();

What does it mean by the "required: Bit" the bit[0] should still be a Bit object.

What type does the bit reset() method return? The compiler sees that the reset method is void.
You are assigning what that method returns to an element in the bit array which can only be assigned Bit objects.

Think about what an assignment statement does.
The right hand of the = must evaluate to or return a value.
That value is assigned to the variable to the left of the =

My reset method is currently void. Should I change it to Bit?

If I have a code like this

	public int reset()
	{
		return bit = 0;
	}

then the method will return an integer. If I want it to return a Bit, should I do something like this?

	public Bit reset()
	{
		return bit = bit.Bit(0);
	}

BEFORE you write the code for a method you need to define what the method is to do.
What is the purpose of the reset method?
Does it create a new Bit object that you want to save in the bit array?
Or does it change the contents of the Bit object it is in?
Or what ?

the reset method is supposed to change the contents of the Bit object. It is supposed to change the value of the content to 0. That's why I originally though to use int object.

If the reset method does NOT return anything then you should not be assigning it to a slot in the array:
bit[0] = bit.reset(); // assigns what reset returns to a slot in the array

If you want to reset the element at 0 code:
bit[0].reset();

Okay I think I fixed most of those errors. Now I have to create a Register method. What the professor wants is this:

This method is the Register constructor. Its purpose is to construct a Register. The
address, or reference, of that Register will be returned to the statement which called
the constructor. There will be two constructors, both of course named Register, but
with different signatures. There will be a constructor with one parameter which is the
number of bits in the register. This constructor will create a Register object of the
correct size in which every bit will have the value 0. There will also be a constructor
with 2 parameters, the first is the number of bits as above, the second will be the
value stored in the register. Note that this value must be converted to binary, and
the individual bits stored in the register. Note also that this value may be positive or
negative, but the NEG operation will be useful for any negative value.
Internally, your Register object will represent the data fields of the register as an array
of Bit objects. The Bit object will be discussed later in this document.


If I interpret this correctly, I think he wants something like this:

	public Register(int numberOfBits)
	{
		Bit[] bit = new Bit[numberOfBits];
	}	
	public Register(int numberOfBits, int valueStored)
	{
		Bit[] registerBit = new Bit[numberOfBits];
		//code to parse valueStored from int to binary and store it in registerBit[]?
	}

but when I try to compile that, I get this error:

----jGRASP exec: javac -g Register.java

Register.java:101: class, interface, or enum expected
public static void Register(int numberOfBits)
^
Register.java:104: class, interface, or enum expected
}
^
Register.java:105: class, interface, or enum expected
public static void Register(int numberOfBits, int valueStored)
^
Register.java:110: class, interface, or enum expected
}

What code is at the lines in the error messages?
It sounds like a mismatched pair of {}s. Check that all {s have a matching } where it should be.
Also check for matching pairs of [] and ().

Why is the posted text formatted with so many short lines?
You could take the time to make the text easier to read by removing all the extra line ends so there are not so many short lines.

That's the most common cause.
Another is code statements outside of a method.

for

	public Register(int numberOfBits)
	{
		Bit[] bit = new Bit[numberOfBits];
	}

I'm supposed to set the array to all values of 0. I thought I did this when I did:

	public Bit()
	{
		bit = 0;
	}

however, I'm getting null values for the entire array. Is the Bit() method not doing what I think I'm telling it to do.