Thread: FractionCalculator StringTokenizer with parsing DUE IN 4 HOURS

DUE IN 4 HOURS,

As i am guessing from your name your assignment is due in soon. Now, i'm also going to assume you have probably cross-posted this on many forums in the hope of getting a response. Also, I am going to assume that you have skipped reading the forum rules,

Announcements - What's Wrong With My Code?

Perhaps if you give those a read, and then take the time to provide error messages, an indication of where the code is crashing etc etc we will be able to provide help.

Regards,
Chris

if(finalint!=0 && finaldenom!=1 && finaldenom!=0 && finalint>0)
 
why are you saying if finalint is NOT 0 AND finalint is greater then 0.. its the same thing unless it goes negative. Try removing one.

yeah, i don't think repetition is causing a problem but i tried deleting it anyway and it didn't fix the problem.

take a look at this demo ive just done on console reading / writing:

public demo() throws Exception{
		// GET FIRST NUMBER
		Scanner sc = new Scanner(System.in);
		System.out.println("Please enter your first fraction: ");
		String inputstr = sc.nextLine();
 
		// TESTING IF INPUT ENTERED IS 444
		if(inputstr.equals("444")){
			System.out.println("Works!");
		}
 
		// GET SECOND VALUE
		System.out.println("Please enter your second fraction: ");
		String second = sc.nextLine();
	}

Now i've had a play around with your code, It seems that your not parsing the data that the user is giving u into a variable.

try creating 3 different number variables..

when your scanning the console.. make sure that you put
VARIABLE = sc.readLine();

Because as ive said.. the problem looks like the 3 end int values your trying to process are always staying as 0...

You may also ask for a OPERATOR after every number they have entered... and get that.

Correct me if im wrong but.. is this not what you're trying to do only simplified?

	public demo() throws Exception{
		// CREATE SCANNER
		Scanner sc = new Scanner(System.in);
 
		// GET FIRST NUMBER
		System.out.println("Please enter your first number: ");
		int first = Integer.parseInt(sc.nextLine());
 
		// GET FIRST OPERATOR
		System.out.println("Please enter your first operator: ");
		String fOP = sc.nextLine();
 
		// GET SECOND NUMBER
		System.out.println("Please enter your second number: ");
		int second = Integer.parseInt(sc.nextLine());
 
		// GET SECOND OPERATOR
		System.out.println("Please enter your second operator: ");
		String sOP = sc.nextLine();
 
		// GET THIRD NUMBER
		System.out.println("Please enter your third number: ");
		int third = Integer.parseInt(sc.nextLine());
 
 
		System.out.println("The total value =  ");
	}

Only thing left for you to do there is to convert the operators so that they can read.. and put the numbers together with the specified operators entered.. Gutta leave something for you to do lol

Originally Posted by macko

Correct me if im wrong but.. is this not what you're trying to do only simplified?

	public demo() throws Exception{
		// CREATE SCANNER
		Scanner sc = new Scanner(System.in);
 
		// GET FIRST NUMBER
		System.out.println("Please enter your first number: ");
		int first = Integer.parseInt(sc.nextLine());
 
		// GET FIRST OPERATOR
		System.out.println("Please enter your first operator: ");
		String fOP = sc.nextLine();
 
		// GET SECOND NUMBER
		System.out.println("Please enter your second number: ");
		int second = Integer.parseInt(sc.nextLine());
 
		// GET SECOND OPERATOR
		System.out.println("Please enter your second operator: ");
		String sOP = sc.nextLine();
 
		// GET THIRD NUMBER
		System.out.println("Please enter your third number: ");
		int third = Integer.parseInt(sc.nextLine());
 
 
		System.out.println("The total value =  ");
	}

Only thing left for you to do there is to convert the operators so that they can read.. and put the numbers together with the specified operators entered.. Gutta leave something for you to do lol

no this is a fraction calculator 2/3 + 1/3 + 1_2/3 not an integer calculator 1 + 2 + 3

simply change the value of first, second and third to String or w.e ur wanting lol I've clearly said that this is for demo only.

As i've said tho try actualy sending the values from the console to a variable.. might help.

I'm not here to complete your homework, I'm simply here to point you in the correct direction... remember that.

Originally Posted by macko

take a look at this demo ive just done on console reading / writing:

public demo() throws Exception{
		// GET FIRST NUMBER
		Scanner sc = new Scanner(System.in);
		System.out.println("Please enter your first fraction: ");
		String inputstr = sc.nextLine();
 
		// TESTING IF INPUT ENTERED IS 444
		if(inputstr.equals("444")){
			System.out.println("Works!");
		}
 
		// GET SECOND VALUE
		System.out.println("Please enter your second fraction: ");
		String second = sc.nextLine();
	}

Now i've had a play around with your code, It seems that your not parsing the data that the user is giving u into a variable.

try creating 3 different number variables..

when your scanning the console.. make sure that you put
VARIABLE = sc.readLine();

Because as ive said.. the problem looks like the 3 end int values your trying to process are always staying as 0...

You may also ask for a OPERATOR after every number they have entered... and get that.

I don't think I understand what you are saying. If you could make the changes to my code and post your response that way it would be really helpful to me.

I think I've already done what your saying I should do.
int firstnum = 0; //first numerator
firstnum = Integer.parseInt(st1_sub2.nextToken());

try saying

int firstnum;
int secondnum;
int thirdnum;

and then simply under your custom error message type
System.out.println(firstnum + " " + secondnum + " " + thirdnum);

You will then see what the values of those numbers are on the console.. if the output posts null that means that i was correct and that you need to listen to my previous advice....

Originally Posted by newbie

O_oinvisiblefiller

Forget my crappy first comment, Upon further reading i had discovered the real error obv.. as ive updated

int firstnum = 0; //first numerator
firstnum = Integer.parseInt(st1_sub2.nextToken());
this didn't do that?

True it's just that when you first declare firstnum = 0...

its hard to do the debugging, Hence if you remove the = 0

Then if the next line doesn't go through properly you can see that firstnum is equal to null...

Otherwise it wills how 0 on the console and you wont know if it had calculated something or not unles you did further debugging.. so the easiest way is doin the above..

i added System.out.println(firstnum + " " + secondnum + " " + finalnum); to run after the error message and then input 2/3 + 1/3 which should produce an error because my calculator asks for 3 different numbers/fractions and System.out.println(firstnum + " " + secondnum + " " + finalnum); gave me 2 1 1

@DUE IN 4 HOURS: Better turn off the PC or laptop, go outside, have a walk for half an hour and come back with Fresh mind. I actually don't have the link to Kevin's blog, but this suggestion is taken from his blog. So, all credit goes to Kevin. Lol try it. you will solve it.

i removed the " = 0" from all my variables and i got this when i ran the program:
Exception in thread "main" java.lang.Error: Unresolved compilation problems:
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable seconddenom may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstdenom may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable seconddenom may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstdenom may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable firstdenom may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable firstdenom may not have been initialized
The local variable firstnum may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable firstdenom may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable seconddenom may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable seconddenom may not have been initialized
The local variable secondnum may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable seconddenom may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable firstnum may not have been initialized
The local variable seconddenom may not have been initialized
The local variable firstdenom may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstdenom may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable firstdenom may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable first_whole_int may not have been initialized
The local variable firstdenom may not have been initialized
The local variable firstnum may not have been initialized
The local variable seconddenom may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable seconddenom may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable second_whole_int may not have been initialized
The local variable seconddenom may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstnum may not have been initialized
The local variable secondnum may not have been initialized
The local variable firstdenom may not have been initialized
The local variable seconddenom may not have been initialized
The local variable cmndenom may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalint may not have been initialized
The local variable finalint may not have been initialized
The local variable finalint may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalint may not have been initialized
The local variable finalint may not have been initialized
The local variable finalnum may not have been initialized
The local variable finalint may not have been initialized

at Fractioncalculator.main(Fractioncalculator.java:11 2)

Originally Posted by Mr.777

@DUE IN 4 HOURS: Better turn off the PC or laptop, go outside, have a walk for half an hour and come back with Fresh mind. I actually don't have the link to Kevin's blog, but this suggestion is taken from his blog. So, all credit goes to Kevin. Lol try it. you will solve it.

I wish, this is due in just under two hours and ive got a little more than an hour to work on it. i have no idea what the problem is i think i will have to skip class and get an excuse note somehow the other forums that i posted this on my username is: "imsof*cked"....

Can you just read my posts and follow them O_O... nobody here will "give you the code" java can be frustrating at times, We all deal with it.

If what you are doing is beginner java which it looks like it is due to the code.. You're code should really be under 50 lines long..


Your if statements should be else if... and your code is just a mess mate.. as ive said 1000 times follow what ive said.. you'll find the awnser yourself and be proud that you learnt a new trick

Originally Posted by macko

There you go... you've got the debugging now.. work out how you would fix that..

As ive said i will not help complete home work.. Now that you know what the outcome is doing.. try changing it and working out why that this is giving you that output.

1 major step in java is the debugging, Maybe its reading the second value twice as you have not entered a third fraction, Try doing a third and seing if the anwser shows of the final..

etc... work it out from there. take your code step by step.

EDIT:
There you go.. as i have been saying for the last 2000 posts lol.. You must initialize the variables.. dont just say = 0; as ull never know if your codes working or not.

Remember before you start all your if statements you've got to write code to initialize all those values..

and LOL @ Mr.777

i know how to fix that "bug" you press ctrl z and reinitialize all the variables