Need help

**TheEvilCouncil** · March 2nd, 2012, 12:39 PM

Here's my code

public void add(int newID, String newDesc, double newCost)
	{
		catalogItems.trimToSize();
		CatalogItem copy = new CatalogItem(newID, newDesc, newCost);
		for(int i = 0; i < catalogItems.size();)
			if(catalogItems.get(i).getItemID() == newID)
			{
				i = catalogItems.size();
				check = true;
			}
			else
			{
				i++;
				check = false;
			}
			if(check = true)
				System.err.println("Error, that item ID already exists.");
			else
				catalogItems.add(copy);
	}

The problem is, on the first if, else statement it seems like my method is completely ignoring it. I tried to test it by printing some guff in both the if and else and I got nothing back, but check is always true no matter what. catalogItems is an <CatalogItem>ArrayList and the CatalogItem object is (int, String, double) if that helps.

**Sean4u** · March 2nd, 2012, 02:21 PM

Here is your code after I 'prettify' it with

indent --no-tabs tmp.java

public void
add (int newID, String newDesc, double newCost)
{
  catalogItems.trimToSize ();
  CatalogItem copy = new CatalogItem (newID, newDesc, newCost);
  for (int i = 0; i < catalogItems.size ();)
    if (catalogItems.get (i).getItemID () == newID)
      {
        i = catalogItems.size ();
        check = true;
      }
    else
      {
        i++;
        check = false;
      }
  if (check = true)
    System.err.println ("Error, that item ID already exists.");
  else
    catalogItems.add (copy);
}

Does that make it more obvious where you've gone wrong? indent does automatic indentation based on code 'depth'. Javac (the Java compiler) ignores whitespace when it compiles your source, so only braces ('{' and '}') affect code depth.

[edit]I'm barking up the wrong tree. To compare a boolean variable, use '=='. The return value of 'theBoolean = true' is always true

**TheEvilCouncil** · March 2nd, 2012, 05:04 PM

Oh man I totally missed that, thank you so much!

Thread: Need help

LinkBack

Thread Tools

Display

Need help

Re: Need help

The Following User Says Thank You to Sean4u For This Useful Post:

Re: Need help