Thread: Why isn't this code working?

Ok so I have a problem.

You operate several hot dog stands distributed throughout town. Define a class named HotDogStand that has a member variable for the hot dog stand's ID number and a member variable for how many hot dogs the stand has sold that day. Create a constructor that allows a user of the class to initialize both values.
Also create a method named justSold that increments the number of hot dogs the stand has sold by one. The idea is that this method will be invoked each time the stand sells a hot dog so that we can track the total number of hot dogs sold by the stand. Add another method that returns the number of hot dogs sold.

Finally, add a static variable that tracks the total number of hotdogs sold by all hot dog stands and a static method that returns the value in this variable.

Write a main method to test your class with at least three hot dog stands that each sell a variety of hot dogs.

private static int totalSold = 0;
 
      public static int getTotalSold()
      {
            return totalSold;
      }
 
 
      private String name;
 
      private int id;
 
      private int numSold;
 
      public HotDogStand(String name, int id)
      {
            this.name = name;
            this.id = id;
      }
 
      public void setJustSold()
      {
            numSold++;
            totalSold++;
      }
 
      public int getNumSoldToday()
      {
            return numSold;
      }
 
      public int getID()
      {
            return id;
      }
 
      public String getName()
      {
            return name;
      }
 
      public String toString()
      {
            return name+" ("+id+") - "+numSold;
      }
 
      public HotDogStand(HotDogStand rhs)
      {
            id = rhs.id;
            name = ""+rhs.name;
            numSold = rhs.numSold;
      }
}
 
class Test
{
 
      public static void main(String[] args)
      {
 
            HotDogStand one = new HotDogStand("one", 1);
            HotDogStand two = new HotDogStand("two", 2);
            HotDogStand three = new HotDogStand("three", 3);
 
            System.out.println(one);
            System.out.println(two);
            System.out.println(three);
 
            System.out.println("Total: "+HotDogStand.getTotalSold());
 
            one.setJustSold();
            two.setJustSold();
            three.setJustSold();
 
            System.out.println("Name\tID\tNumber Sold");
            System.out.println("________________________________");
            System.out.println(one.getName()+"\t"+one.getID()+"\t"+one.getNumSoldToday());
            System.out.println(two.getName()+"\t"+two.getID()+"\t"+two.getNumSoldToday());
            System.out.println(three.getName()+"\t"+three.getID()+"\t"+three.getNumSoldToday()+"\t");
 
            System.out.println("Total: "+HotDogStand.getTotalSold());
 
            HotDogStand four = new HotDogStand(one);
      }
}

How come when I run it nothing shows up?

Hello tai8!
I just run your code and it printed what it was supposed to.

Originally Posted by Norm

Please copy and paste here the console from when you execute the program.
I see lots of println statements, some of them will print if the program executes.

All it says is this:

run:
BUILD SUCCESSFUL (total time: 2 seconds)

What is it supposed to show?

Originally Posted by andreas90

Hello tai8!
I just run your code and it printed what it was supposed to.

Really? What IDE did you use and what does your output look like?

Originally Posted by Norm

Can you use the java command to execute your program in a command prompt window?

The output you posted is from the IDE not from the java program.

How do i do that?

Originally Posted by tai8

Really? What IDE did you use and what does your output look like?

I run it on NetBeans. Here is the output.


run:
one (1) - 0
two (2) - 0
three (3) - 0
Total: 0
Name ID Number Sold
________________________________
one 1 1
two 2 1
three 3 1
Total: 3
BUILD SUCCESSFUL (total time: 2 seconds)

Originally Posted by andreas90

I run it on NetBeans. Here is the output.


run:
one (1) - 0
two (2) - 0
three (3) - 0
Total: 0
Name ID Number Sold
________________________________
one 1 1
two 2 1
three 3 1
Total: 3
BUILD SUCCESSFUL (total time: 2 seconds)

I'm using NetBeans too. How did you get that? Did you copy and pasted exactly what I posted and ran it or did you change anything to the code at all?

Oh I forgot to mention I also have this right before the code i posted:

package assignment.pkg5.pkg1;

public class HotDogStand {

What did you have before the code?

Originally Posted by tai8

I'm using NetBeans too. How did you get that? Did you copy and pasted exactly what I posted and ran it or did you change anything to the code at all?

Oh I forgot to mention I also have this right before the code i posted:

package assignment.pkg5.pkg1;

public class HotDogStand {

What did you have before the code?

Just copy-pasted your code in a public class. I had no package. Did you try the cmd as Norm suggested? I did it and it worked too.

Originally Posted by newbie

Sorry, but that is some weird coding practice.

Anyway, the reason it always sums up to 45 is because for every justSold() and getNumSold() call, you increment your variables by 1.
If you count how many times they are all called, it adds up to 45 (42 when you exit the for loops, then an additional 3 calls here : int getTotalSold = (s1.getNumSold() + s2.getNumSold() + s3.getNumSold())).

So how would i fix it then? Do i just delete all the loops then?

Originally Posted by newbie

Just rework your logic.

Plan what you want to do, write down on paper how you would do it in the real world, then convert that logic into Java.

The problem is i'm not sure why the numbers for hot dog stands 1, 2, and 3 are not adding up. I know what i want to do, i just don't know how to get there.

Originally Posted by Norm

You can not change the values used to compute a sum after you compute the sum.
for example
x = y+ z;
y = y = 2;
now x does not equal the current value of y + z because y has been changed/

I don't think changing the order does anything. I just tried and nothing. I dont know why the 3 stands are not adding together. what is wrong with the code there?

Originally Posted by Norm

Move this line to just in front of where you print out the value of getTotalSold.
Have these two line right next to each other.
int getTotalSold = (s1.getNumSold() + s2.getNumSold() + s3.getNumSold());
System.out.println("Total sold = " + getTotalSold);

I tried it and still nothing. sigh... i want to die

my god i really dont know... anyone?