Thread: Sorting issues.

This program is supposed to take a lit of objects, and sort them in different ways. Along with that, the assignment requires us to use different algorithms for some of them, so that is why my methods do not all look the same. The method in question is sortName(), which obviously is supposed to sort by name. It uses the same algorithm as sortID(), which works fine. The error - "java.lang.IndexOutOfBoundsException: Index: 5, Size: 5
at java.util.ArrayList.rangeCheck(ArrayList.java:604)
at java.util.ArrayList.get(ArrayList.java:382)
at TestItem.sortName(TestItem.java:79)
at TestItem.main(TestItem.java:148)"

occurs at the line "a.add(i, a.get(posmax));
Which shouldnt throw this exception, because the line before it removes i, making the List 1 smaller, so therefore it should have room. Take a look and throw me some solutions! Thanks!

import java.text.*;
import java.util.*;
public class TestItem
{
private static List<Item> hardware = new ArrayList<Item>();
 
    public static void printInventory(List<Item> a)
    {
        System.out.println("itemID    itemName     Stock    Price");
        System.out.println("------------------------------------------");
 
        for(Item i : a)
        {
            System.out.println(i);
        }
        System.out.println();
 
    }
 
    public static void sortID(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmaxobj = a.get(posmax);
             int gmax = Integer.parseInt(gmaxobj.getID());
            for ( k = 0 ; k <= i ; k++ )
            {
                Item gobj = a.get(k);
                int g = Integer.parseInt(gobj.getID());
                if (g > gmax)
                 posmax = k;
         }
         temp = a.get(i);
         a.remove(i);
         a.add(i, a.get(posmax));
         a.remove(posmax);
         a.add(posmax, temp);
        }
 
        System.out.println("Sorting by ID..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
    }
 
        public static void sortName(List<Item> a)
        {
                  int i;
                int k;
                int posmax;
                Item temp;
                for ( i = a.size() - 1 ; i >= 0 ; i-- )
                {
                    posmax = 0;
 
                    Item gmax = a.get(posmax);
 
                    for ( k = 0 ; k <= i ; k++ )
                    {
                        Item g = a.get(k);
                        if (g.getName().compareTo(gmax.getName()) > 0 )
                     posmax = k;
                 }
                 temp = a.get(i);
                 a.remove(i);
                 a.add(i, a.get(posmax));
                 a.remove(posmax);
                 a.add(posmax, temp);
                }
 
                System.out.println("Sorting by Name..");
                System.out.println();
                printInventory(hardware);
                System.out.println();
        }
 
 
 
 
        public static void sortInStore(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmax = a.get(posmax);
 
            for ( k = 0 ; k <= i ; k++ )
            {
                Item g = a.get(k);
                if (g.getStock() > gmax.getStock() )
             posmax = k;
         }
         temp = a.get(i);
         a.remove(i);
         a.add(i, a.get(posmax));
         a.remove(posmax);
         a.add(posmax, temp);
        }
 
        System.out.println("Sorting by Stock..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
    }
 
 
        public static void sortPrice(List<Item> a)
    {
 
 
    }
 
 
 
 
   public static void main(String [] args)
   {
       hardware.add(0, new Item("100", "Air Filters", 200, 10.5));
       hardware.add(1, new Item("101", "Door Knobs", 60, 21.5));
       hardware.add(2, new Item("102", "Hammers", 90, 9.99));
       hardware.add(3, new Item("103", "Levels", 80, 19.99));
       hardware.add(4, new Item("104", "Ceiling Fans", 100, 59));
       hardware.add(5, new Item("105", "Wrench Sets", 55, 80));
 
       printInventory(hardware);
       sortInStore(hardware);
 
       sortID(hardware);
 
       sortName(hardware);
 
 
 
    }
}

Hello Santroi!

a.remove(i);
a.add(i, a.get(posmax));

You are removing the element in the i-th position of your list and then you try to add in it a.get(posmax). But from your inner for loop, posmax can be equal to i. I would definitely recommend you follow Norm's suggestion to see what's going on with the indexes.
Hope it helps.

Okay, making the k <= i just k < i seems to have fixed it, but I see more problems with it. I will give you both classes on this post, and if you run it you will see that 2 of the Items that are printed are printed differently than the rest and I cant figure out why. If you have a fix for that please let me know. Also, the sortName method is sorting the names strangely. I need them in alphabetical order, so if anyone can give me a new method to try for that, it would be appreciated. I was going off of an example they had given us, but it was using an array of ints. It has to be an "Insertion" sort, which involves creating an empty copy of the array you are sorting. Then, one by one, taking values from the array you want to sort and insert them into the empty array.

Thanks for any help you can offer!

Item Class.

import java.text.*;
import java.util.*;
 
public class Item
{
  private String itemID, itemName;
  private int inStore;
  private double price;
  private DecimalFormat df = new DecimalFormat("#.##");
    public Item (String id, String name, int stock, double cost)
    {
    itemID = id;
    itemName = name;
    inStore = stock;
    price = cost;
 
   }
 
   public String getID()
   {
       return itemID;
    }
 
       public String getName()
    {
       return itemName;
    }
 
       public int getStock()
    {
       return inStore;
    }
 
       public double getPrice()
    { 
       return price;
    }
 
    public String toString()
    {
       return " " + itemID + "\t" + itemName + "\t" + inStore + " \t" + "$" + df.format(price);
    }
}

TestItem Class.

import java.text.*;
import java.util.*;
public class TestItem
{
private static List<Item> hardware = new ArrayList<Item>();
 
    public static void printInventory(List<Item> a)
    {
        System.out.println("itemID    itemName     Stock    Price");
        System.out.println("------------------------------------------");
 
        for(Item i : a)
        {
            System.out.println(i);
        }
        System.out.println();
 
    }
 
    public static void sortID(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmaxobj = a.get(posmax);
             int gmax = Integer.parseInt(gmaxobj.getID());
            for ( k = 0 ; k <= i ; k++ )
            {
                Item gobj = a.get(k);
                int g = Integer.parseInt(gobj.getID());
                if (g > gmax)
                 posmax = k;
         }
         temp = a.get(i);
         a.remove(i);
         a.add(i, a.get(posmax));
         a.remove(posmax);
         a.add(posmax, temp);
        }
 
        System.out.println("Sorting by ID..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
    }
 
        public static void sortName(List<Item> a)
        {
                  int i;
                int k;
                int posmax;
                Item temp;
                for ( i = a.size() - 1 ; i >= 0 ; i-- )
                {
                    posmax = 0;
 
                    Item gmax = a.get(posmax);
 
                    for ( k = 0 ; k < i ; k++ )
                    {
                        Item g = a.get(k);
                        if (g.getName().compareTo(gmax.getName()) > 0 )
                     posmax = k;
                 }
                 temp = a.get(i);
                 a.remove(i);
                 a.add(i, a.get(posmax));
                 a.remove(posmax);
                 a.add(posmax, temp);
                }
 
                System.out.println("Sorting by Name..");
                System.out.println();
                printInventory(hardware);
                System.out.println();
        }
 
 
 
 
        public static void sortInStore(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmax = a.get(posmax);
 
            for ( k = 0 ; k <= i ; k++ )
            {
                Item g = a.get(k);
                if (g.getStock() > gmax.getStock() )
             posmax = k;
         }
         temp = a.get(i);
         a.remove(i);
         a.add(i, a.get(posmax));
         a.remove(posmax);
         a.add(posmax, temp);
        }
 
        System.out.println("Sorting by Stock..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
    }
 
 
        public static void sortPrice(List<Item> a)
    {
 
 
    }
 
 
 
 
   public static void main(String [] args)
   {
       hardware.add(0, new Item("100", "Air Filters", 200, 10.5));
       hardware.add(1, new Item("101", "Door Knobs", 60, 21.5));
       hardware.add(2, new Item("102", "Hammers", 90, 9.99));
       hardware.add(3, new Item("103", "Levels", 80, 19.99));
       hardware.add(4, new Item("104", "Ceiling Fans", 100, 59));
       hardware.add(5, new Item("105", "Wrench Sets", 55, 80));
 
       printInventory(hardware);
       sortInStore(hardware);
 
       sortID(hardware);
 
       sortName(hardware);
 
 
 
    }
}

out.jpg

That help?

I tried your code and changed a little the Item's toString() but didn't find what is causing this formatting. The only thing I noticed is that this is happening if the name's length is less than 8. With a name's length >= 8, the formatting works.
Hope this helps somebody else find the bug (I'm very curious to know what's the bug).

Yeah I may just make the names to all be at least 8. It seems like the most viable choice. I only do it this way because I am required to use toString in my assignment. Usually I would just use printf. Any ideas on changing the sortName method though? as of right now it sorts by name, but I dont know exactly what it means by that. Its not in alphabetical order, which is what i'd like it to be. But the method has to involve putting them in order into a new List.

I did that and I dont understand why its seeing what its seeing. When two strings are compared using compareTo, is it based on alphabetical or what? Because if not then this method wont do what I want it to anyway.

Well ive given up trying to do different sorts, so i'll just make them all selection. My problem is, 2 of my selection sorts are not working now. The sortName() is still printing wrong, which is probably due to the compareTo method, but I cant find how. And the sortPrice, a new method, is sorting wrong and I dont know why. I'll post my new code to let you see all the changes and see if you can let me know whats going on.

import java.text.*;
import java.util.*;
public class TestItem
{
private static List<Item> hardware = new ArrayList<Item>();
 
    public static void printInventory(List<Item> a)
    {
        System.out.println("itemID    itemName     Stock    Price");
        System.out.println("------------------------------------------");
 
        for(Item i : a)
        {
            System.out.println(i);
        }
        System.out.println();
 
    }
 
    public static void sortID(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmaxobj = a.get(posmax);
             int gmax = Integer.parseInt(gmaxobj.getID());
            for ( k = 0 ; k <= i ; k++ )
            {
                Item gobj = a.get(k);
                int g = Integer.parseInt(gobj.getID());
                if (g > gmax)
                 posmax = k;
         }
         temp = a.get(i);
         a.remove(i);
         a.add(i, a.get(posmax));
         a.remove(posmax);
         a.add(posmax, temp);
        }
 
        System.out.println("Sorting by ID..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
    }
 
        public static void sortName(List<Item> a)
        {
                 int i;
            int k;
            int posmax;
            Item temp;
            for ( i = a.size() - 1 ; i >= 0 ; i-- )
            {
                posmax = 0;
 
                Item gmax = a.get(posmax);
 
                for ( k = 0 ; k <= i ; k++ )
                {
                    Item g = a.get(k);
                    if (gmax.getName().compareTo(g.getName()) < 0)
                 posmax = k;
             }
             temp = a.get(i);
             a.set(i, a.get(posmax));
             a.set(posmax, temp);
            }
 
            System.out.println("Sorting by Name..");
            System.out.println();
            printInventory(hardware);
            System.out.println();
          }
 
 
        public static void sortInStore(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmax = a.get(posmax);
 
            for ( k = 0 ; k <= i ; k++ )
            {
                Item g = a.get(k);
                if (g.getStock() > gmax.getStock() )
             posmax = k;
         }
         temp = a.get(i);
         a.remove(i);
         a.add(i, a.get(posmax));
         a.remove(posmax);
         a.add(posmax, temp);
        }
 
        System.out.println("Sorting by Stock..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
    }
 
 
        public static void sortPrice(List<Item> a)
    {
        int i;
        int k;
        int posmax;
        Item temp;
        for ( i = a.size() - 1 ; i >= 0 ; i-- )
        {
            posmax = 0;
 
            Item gmax = a.get(posmax);
 
            for ( k = 0 ; k <= i ; k++ )
            {
                Item g = a.get(k);
                if (g.getPrice() > gmax.getPrice() )
             posmax = k;
         }
         temp = a.get(i);
         a.set(i, a.get(posmax));
         a.set(posmax, temp);
        }
 
        System.out.println("Sorting by Price..");
        System.out.println();
        printInventory(hardware);
        System.out.println();
 
   }  
 
 
   public static void main(String [] args)
   {
       hardware.add(0, new Item("100", "Air Filters", 200, 10.5));
       hardware.add(1, new Item("101", "Door Knobs", 60, 21.5));
       hardware.add(2, new Item("102", "Sledge Hammers", 90, 9.99));
       hardware.add(3, new Item("103", "Laser Levels", 80, 19.99));
       hardware.add(4, new Item("104", "Ceiling Fans", 100, 59));
       hardware.add(5, new Item("105", "Wrench Sets", 55, 80));
 
       printInventory(hardware);
       sortInStore(hardware);
 
       sortID(hardware);
 
       sortName(hardware);
 
       //sortPrice(hardware, (int)Math.floor(findHigh(hardware)), (int)Math.floor(findLow(hardware)));
 
       sortPrice(hardware);
    }
}

import java.text.*;
import java.util.*;
 
public class Item
{
  private String itemID, itemName;
  private int inStore;
  private double price;
  private DecimalFormat df = new DecimalFormat("#.##");
    public Item (String id, String name, int stock, double cost)
    {
    itemID = id;
    itemName = name;
    inStore = stock;
    price = cost;
 
   }
 
   public String getID()
   {
       return itemID;
    }
 
       public String getName()
    {
       return itemName;
    }
 
       public int getStock()
    {
       return inStore;
    }
 
       public double getPrice()
    { 
       return price;
    }
 
    public String toString()
    {
       return " " + itemID + "\t" + itemName + "\t" + inStore + " \t" + "$" + df.format(price);
    }
}

Basically, i'm so tired and confused by what ive done with this, that i'm almost ready to wipe it and start over. Just treat it like its a brand new question, even though the code hasnt drastically changed.

I guess you have a point. But I mean its simple, each method sorts the Items in the array differently according to the name. sortName() will obviously sort them by their name, ect.

As to each thing, I cant say i'm positive as to what each line of code is supposed to do, most of it got pulled from some instructions and edited based on what I learned from looking stuff up, and it worked for 2 methods.

But, I am sorry for my being hasty, I was frustrated and looking for an easy fix, which I found after a little work. The line "Item gmax = a.get(posmax);" needed to be inside the second for loop for it to work.
Thanks for all your help.