Thread: Making a method to move blocks in a grid

import acm.graphics.*;
import acm.program.*;
import java.awt.Color;
import java.util.Iterator;
import java.util.Random;
import java.util.List;
 
public class LAB1
{
	final static int BLOCKWIDTH = 50;
	final static int BLOCKHEIGHT = 10;
	final static int NBLOCKS = 10;
	final static int BLOCKROWS = 5;
	final static int ROWZERO = 50;
	final static int ROWSEPARATION = (5*BLOCKHEIGHT);
	final static int WIDTH = (BLOCKWIDTH*NBLOCKS);
	final static int HEIGHT = 600;
 
	public static java.util.List<acm.graphics.GRect> createPlayfield()
	{
		Random r = new Random();
		List<GRect> l = null;
		int x = 0;
		int y = ROWZERO - BLOCKHEIGHT;
		Color c = new Color(r.nextInt(256));
 
		addBrick(l,x,y,BLOCKWIDTH,BLOCKHEIGHT,c);
 
		for (int i = 0; i < BLOCKROWS; i++)
		{
			i = (i * ROWSEPARATION) + ROWZERO;
 
			for(int j = 0; j < NBLOCKS; j++)
			{
				j = j * BLOCKWIDTH;
			}
		}
 
 
 
 
	}
 
	public static void addBrick(java.util.List<acm.graphics.GRect> l, int x, int y, int width, int height, java.awt.Color c)
	{
		l.add(createBrick(x,y,WIDTH,HEIGHT,c));
	}
 
	public static acm.graphics.GRect createBrick(int x, int y, int width, int height, java.awt.Color c)
	{
		GRect s = new GRect(x,y,WIDTH,HEIGHT);
 
		return s;
	}
	public static acm.graphics.GRect intersect(acm.graphics.GObject o,java.util.List<acm.graphics.GRect> l)
	{
		GRectangle r = o.getBounds();
 
		for(GRect e : l)
		{
			if(e.getBounds().intersects(r))
				return e;
		}
		return null;
	}

My main problem is the createplayfield method, this is the description to make it:

createPlayfield is a static method that returns a List of GRects. Each GRect is coloured randmoly and is
of size BLOCKWIDTH x BLOCKHEIGHT. The blocks are placed in a grid BLOCKROWS height x
NBLOCKS. The i'th row of blocks has its upper edge aligned with row i * ROWSEPARATION +
ROWZERO. The j'th column of blocks has its left edge aligned with j * BLOCKWIDTH. You may
find it useful to implement this method using the addBrick method below.

API's : The acm.graphics.GRect Class.

As you can see I tryed to do it but haven't done well, it's a very confusing description.

Please Edit your post and wrap your code with[code=java]<YOUR CODE HERE>[/code] to get highlighting

Rewrite the requirements for the method as a list of small simple steps. Then work on the code for each step.

What was posted is hard to read because it was has weird line breaks and doesn't have the steps in a simple list.

Often you can code from the list of simple steps.
If you have a list of steps and are having a problem coding any of them, list the step you are having problems with.

how would i return the list of grects.

With a return statement:
return grects;

l is a terrible name for a variable. Can you add a few more letters to it?

Originally Posted by Norm

Often you can code from the list of simple steps.
If you have a list of steps and are having a problem coding any of them, list the step you are having problems with.


With a return statement:
return grects;

l is a terrible name for a variable. Can you add a few more letters to it?

I will rename all the variables to make it look better once I can make the program function right.

ok so

 
public static java.util.List<acm.graphics.GRect> createPlayfield()
{
     Random r = new Random();
     List<GRect> l = null;
     int x = 0;
     int y = ROWZERO - BLOCKHEIGHT;
     Color c = new Color(r.nextInt(256),r.nextInt(256),r.nextInt(256));
      // Where to implement how to insert the blocks into a grid?
     for (i = 0; i <= BLOCKROWS; i++) // 
     {// How to implement that i'th row is aligned with i * ROWSEPARATION + ROWZERO
        i = i * ROWSEPARATION + ROWZERO;
          for (j = 0; j <= NBLOCKS; j++) 
          {// How to implement that i'th row is aligned with j x BLOCKWIDTH;         
             j = j * BLOCKWIDTH;
          }
             addBrick(l,x,y,BLOCKWIDTH,BLOCKHEIGHT,c); // How to implement i and j into the list of grects.
      }
        return l;
}

These are my problems and theres some more, I think my other methods are wrong too.

I will rename all the variables to make it look better once I can make the program function right.

The idea of using well named variables is so when you (or anyone) reads the code they can understand what it does. When the coding is finished and is being tossed in the bin who cares what the names are.

Those comments hidden in the code are hard to read.

how to insert the blocks into a grid?

What is a block? Is it an object?
What is the grid? Is it an array?

At what locations in the array are the objects to be inserted?

Writing code before you have a design for what the code is supposed to do usually is a bad idea.
Get the design, then write the code.

I have not seen the List of steps the code has to do to solve the problem. Post that and we'll work on the code for each step one by one.

Perhaps the steps you are thinking of are at a too high a level and need to be further broken down into simpler steps.

#4 what is a block? what is a grid? At what locations in the grid do the blocks go?
#5 implies the grid is a 2D array. Is that right?

I have no idea what #6 & #7 mean

#8 What is the List that is returned? How does that relate to the grid (an array?)?

Ok, I think I get it. The method is supposed to layout shapes on a visual grid. Most of the needed logic is for step #4. Work on the rows one by one using step #6 to get the rows position. On each row position the shapes column as per step #7

Now you need to expand step #4 to handle going through the rows and columns etc

 
public static java.util.List<acm.graphics.GRect> createPlayfield()
{
     Random r = new Random();
     List<GRect> l = null;     
     int x = 0;
     int y = ROWZERO - BLOCKHEIGHT;
     Color c = new Color(r.nextInt(256),r.nextInt(256),r.nextInt(256));
 
     for (i = 0; i <= BLOCKROWS; i++) 
     {
        i = i * ROWSEPARATION + ROWZERO;
          for (j = 0; j <= NBLOCKS; j++) 
          {
             j = j * BLOCKWIDTH;
            addBrick(l.getX(),l.getY(),BLOCKWIDTH,BLOCKHEIGHT,l.getColor(c));        
          } 
      }
        return l;
}

Ok so, I did what you described but now, the problem is, i and j are just there and their doing nothing, and there is no grid, how would I add an grid because there is BLOCKROW x NBLOCK for grid.

Do you have the steps the program needs to do now? You keep posting lines of code.
What is the logic for placing the shapes for #4?
Does the GRect constructor take the size? That would be for #3. It also would have a method to take the results of #2.