Thread: Prim numbers

I got a task to write a java program which can solve some mathematical actions. Every action has to be in separate methods. My problem is with a method which should sort prime numbers between 0 and a given number. The code works without the method but I have to implement into a method anyway and that's the problem. I tried many different ways with array etc but nothing works. I guess it's a very simple and easy task for many of you but I'm totally beginner so I would like to ask for you help. Thanks!

public class prim4 {

public static void main (String[] args) {

int prim=50;
int j;
boolean control;

for (j=1; j<=prim; j++)
{
control=primtal(j);

if (control=false)
{
break;
}
if (control=true)
{
System.out.println(j + " ");
}
}
}

public static boolean primtal (int j)
{
int i;
boolean result;
for (i=2; i < j ;i++ ){
int temp = j%i;
if (temp==0)
{
result=false;
}
}
if(i == j){
{
result=true;
}
return result;
}
}

}

It always helps to wrap your code in code tags: [ code][/code]
Also, this part isn't done correctly.

if (control=false)
{
     break;
}
if (control=true)
{
     System.out.println(j + " ");
}

You are assigning true or false to the control variable instead of checking for its value.

Also, just a little helpful bit of advice: when checking for booleans, you don't need to check if they are equal to true or false as you did. An easier, nicer way of writing it would look like this.

if (control) {
    //This will execute if control is true.
}
 
if (!control) {
    //This will execute if control is false.
}

Thank you! I was trying as you said but it still writes an error message like: ...\prim4.java:42: error: missing return statement. I can´t find out what the problem is.

public class prim4 {
 
public static void main (String[] args) {
 
int prim=50;
int j;
boolean control;
 
for (j=1; j<=prim; j++)
{
control=primtal(j);
 
if (!control)
	{
	break;
	}
 
if (control)
	{
	System.out.println(j + " ");
	}
}
}
 
public static boolean primtal (int j)
{
  int i;
  boolean result;
  for (i=2; i < j ;i++ ){
  int temp = j%i;
	if (temp==0)
	{
 	result=false;
	}
  }
  if(i == j){
	{
	result=true;
	}
return  result;
}
}
}

In your primtal method, the second if statement has an extra set of braces.

Thank you. I haven't seen it. I tried again but when i fix a fail there will be an other. It is now: "prim4.java:42: error: variable result might not have been initialized return result; " Do you think this solution/algorithm could work or should I find out an other one?

That error just means that you never initialized "result". Set it to true or false to begin with.

I fixed it.

public class prim7 {
 
public static void main (String[] args) {
 
int prim=50;
int j;
boolean control;
 
for (j=2; j<=prim; j++){
control=primtal(j);
 
if (control)
	{
	System.out.print(j + " ");
	}
}
}
 
static boolean primtal (int j)
{
    for(int i=2;i<j;i++) {
        if(j%i==0)
            return false;
    }
    return true;
}
 
}