Thread: can anyone think of a more efficient way of doing this...

guys, this code calculate the amount of classes that a student needs to take lets say for 17 credits. It will be 5 three credits classes and 2 one credit classes, but I think the loop is kind of unnecessary. could anyone post a more efficient way? thanks

public static void numOfClasses(int credits)
    {
        int class3 = 3, class1 = 1, numOfClass;
 
        do
        {
            if(credits >= 3)
            {
                numOfClass = credits / class3;
                credits -= (numOfClass * class3);
                System.out.println("3 credits classes: "+numOfClass);
            }           
            else
            {
                numOfClass = credits / class1;
                credits -= (numOfClass * class1);
                System.out.println("1 credit classes: "+numOfClass);
            }                
        }while(credits != 0);
    }

Originally Posted by Norm

Look at using the /, - and % operators.

like this? or could be better?

public static void numOfClasses(int totalCred)
    {
        int numOfClass = 0;
 
        if(totalCred >= 3)
        {
            numOfClass = totalCred / 3;
            totalCred = totalCred % 3;
            System.out.println("3 credit classes: "+numOfClass);
        }
        if(totalCred >= 1)
        {
            numOfClass = totalCred;
            System.out.println("1 credit classes: "+numOfClass);
        }
    }

Originally Posted by Norm

Does that code give the correct results?
Do you intend that both if statements be true if the first one is true?

yes, it gives correct result... now both statement are not always true, depending on the total of credits "totalCred"... have you try it?