Thread: Help with bouncing ball

Hello everyone I am having a hard time bouncing a ball I cant seem to get the collision correct and the ball is moving way to fast.Any help would be greatly appreciated.Here is my code.

import java.awt.*;
import javax.swing.*;
/**
 * Created by IntelliJ IDEA.
 * User: aortell24
 * Date: 7/31/12
 * Time: 4:41 PM
 * To change this template use File | Settings | File Templates.
 */
public class Ball extends JPanel {
    private Color _color;
    private int _radius;
    private int _xSpeed;
    private int _ySpeed;
    private int _xPoint;
    private int _yPoint;
    private double _direction;
 
    public Ball()
    {
        _color = Color.YELLOW;
        _radius = 5;
        _direction = Math.random() * 360;
    }
    public Color getColor()
    {
        return _color;
    }
    public double getDirection()
    {
        return _direction;
    }
    public int getXSpeed()
    {
        return _xSpeed;
    }
    public void setXSpeed(int xSpeed)
    {
        _xSpeed = xSpeed;
    }
    public int getYSpeed()
    {
        return _ySpeed;
    }
    public  void setYSpeed( int ySpeed)
    {
        _ySpeed = ySpeed;
    }
    public int getXPoint()
    {
        _xPoint = (int)(Math.random() * 800 +5);
        return _xPoint;
    }
    public int getYPoint()
    {
        _yPoint = (int)(Math.random() * 800 +5);
        return _yPoint;
    }
    public void setXPoint(int xPoint)
    {
        _xPoint = xPoint;
    }
    public void setYPoint(int yPoint)
    {
        _yPoint = yPoint;
    }
    public void setColor(Color color)
    {
        _color = color;
    }
    public void setDirection(double direction)
    {
        _direction = direction;
    }
    public void setRadius(int radius)
    {
        _radius = radius;
    }
    public int getRadius()
    {
        return _radius;
    }
    protected void paintComponent(Graphics graphics)
    {
        graphics.setColor(getColor());
        graphics.fillOval(0,0, getRadius() * 2, getRadius() * 2);
        graphics.setColor(Color.BLACK);
        graphics.drawOval(0,0,getRadius() *2, getRadius() * 2);
    }
}
import javax.swing.*;
import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
 
 
/**
 * Created by IntelliJ IDEA.
 * User: aortell24
 * Date: 7/31/12
 * Time: 6:34 PM
 * To change this template use File | Settings | File Templates.
 */
public class Board extends JFrame {
 
    JPanel panel1 = new JPanel();
    Ball ball = new Ball();
    Timer timer = new Timer(10,new TimerEventHandler());
 
    int xPoint =0;
    int yPoint =0;
    Board()
    {
        timer.start();
        this.setLayout(null);
        panel1.setLayout(null);
        panel1.setBounds(0,0,800,800);
        this.add(panel1);
        panel1.add(ball);
        panel1.setBackground(Color.BLACK);
        if(ballHitsLeftOrRight() || ballHitsTopOrBottom())
        {
            ballBounce();
        }
    }
    public boolean ballHitsTopOrBottom()
    {
        if(ball.getY() >= 800)
            return true;
        else if(ball.getY() <= 0)
            return true;
        else return false;
    }
    public boolean ballHitsLeftOrRight()
    {
        if(ball.getX() >= 800)
            return true;
        else if(ball.getY() <= 0)
            return true;
        else
            return false;
    }
    public void ballBounce()
    {
        if(ballHitsLeftOrRight())
        {
            ball.setXSpeed(-xPoint);
        }
        if(ballHitsTopOrBottom())
        {
            ball.setYSpeed(-yPoint);
        }
    }    
    class TimerEventHandler implements ActionListener
    {
        public void actionPerformed(ActionEvent actionEvent)
        {
            ball.setBounds(ball.getXPoint() + ball.getXSpeed(),ball.getYPoint() + ball.getYSpeed(),15,15);
            repaint();
        }
 
    }
 }
import javax.swing.*;
 
/**
 * Created by IntelliJ IDEA.
 * User: aortell24
 * Date: 7/31/12
 * Time: 6:42 PM
 * To change this template use File | Settings | File Templates.
 */
public class Application {
    public static void main(String[] args)
    {
        Board board = new Board();
        board.setSize(800, 600);
        board.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        board.setLocationRelativeTo(null);
        board.setVisible(true);
 
    }
}

To slow it you could always make the x and y positions a double or float i suppose and do the same for the x and y point. then multiply them by 0.1 or something. It should go slower now.
I dont recommend on using a timer though.

Also another tip, instead of writing a "_" in front of every variable the class has, you could also use "this." makes everything a bit easier in my opinion. Example:

private int speed = 0;
public void setSpeed(int speed){
  this.speed = speed;
}

Thanks alot guys that is a old habit my teacher told me he puts '_' in front of private data fields.Thanks for the help.

Owh, well mine thought me to use this. by this. you refer to a private data field. Also i'm not quite inderstanding your code. Do you want a simple ball bouncing on the screen? If so, look at this line:

 ball.setBounds(ball.getXPoint() + ball.getXSpeed(),ball.getYPoint() + ball.getYSpeed(),15,15);

And then specifically what ball.getXPoint and ball.getYPoint do.

My project is to create an instance of the ball for every client that is connected to a server and the client should have a way to display and change the color , speed and direction of the ball.

But yes I just need a bouncing ball fro every client connected .

Try to get just 1 ball able to bounce and move properly. If you follow Norm's tips on his post, and then read what i said, you should be able to make a conclusion on what is going wrong .

I wrote all this.Thanks for the help.

I was trying to keep the ball inside the panel which is 800 by 800 but I though that it was moving to fast so I changed it to 80 but that did not help .

I though that by giving it random number in between 0 and 800 it would position the ball at random postions inside the panel which is 800 x 800

That's true indeed. Now look at the line i pointed out. It will execute that every 10 ms i believe. so every once in a very short while it will execute ball.getXPoint() and ball.getYPoint(). And those function position the ball at random position inside the panel. All the time. You should give it a random position only at the initiation of the ball, so in the constructor for example .

So, I move that line to the construtor and just update the speed every timer tick?

You could update the speed every timer tick, but why not update the position every tick?
make something like an update function. something along the lines of:

public void update(){
   x+=xspeed;
   y+=yspeed;
}

And you change the speed everytime it hits a wall. All you have to do then is execute the update function everytime the timer finishes.

Oh got ya Thanks alot

XPoint and Ypoint keep printing out 0 I dont understand how they can be 0 and the ball is moving so fast I can bearly see it.

I got it I finally got it ! now I just need to keep it in the panel. Thanks so much!

I have the perfect speed now I just need to keep it on the panel it goes right of the panel as soon as it makes it across the panel but the speed is perfect.