Thread: Can't work out how to detect and incorrect input

I'm making a calculator that asks for inputs in the console and prints answers, nothing fancy. I've got it all working, even detecting if you have inputed an integer lower than 0 when square rooting.

At the moment I have it so you type in a string which asks you to type in integers. The problem I'm having is detecting if the string is wrong rather than the string and the integer.

Here's my code:

import java.util.Scanner;
import static java.lang.System.*;
 
public class CalculatorConsole {
 
		@SuppressWarnings({ "resource" })
		public static void main(String args[]) {
 
			out.println("Please select an operation from the list:");
			out.println("- sqrt");
			out.println("- add");
			out.println("- subtract");
			out.println("- times");
			out.println("- divide");
			out.println("- terminate");
 
			String sqrt = "sqrt";
			String add = "add";
			String subtract = "subtract";
			String times = "times";
			String divide = "divide";
			String terminate = "terminate";
 
			int loop = 0;
 
			while (loop != 1) {
 
				Scanner input = new Scanner(in);
				String output = input.next();
 
				if (output.equals(sqrt)) {
					out.print("Please enter a number to square root: ");
 
						int sqrtInput = input.nextInt();
 
						if (sqrtInput < 0) {
							out.println("You are a silly person, you cannot use anything below zero");
 
						} else {
 
							out.printf("The square root of " + sqrtInput + " is %1.1f\n", Math.sqrt(sqrtInput));
 
						}
				}
 
					if (output.equals(add)) {
					out.println("Please enter two numbers to add: ");
 
						int addInput1 = input.nextInt();
						int addInput2 = input.nextInt();
 
							out.println((addInput1) + " + " + (addInput2) + " = " + (addInput1 + addInput2));
 
				}
 
					if (output.equals(subtract)) {
						out.println("Please enter two numbers to subtract: ");
 
							int subtractInput1 = input.nextInt();
							int subtractInput2 = input.nextInt();
 
								out.println((subtractInput1) + " - " + (subtractInput2) + " = " + (subtractInput1 - subtractInput2));
 
					}
 
						if (output.equals(times)) {
							out.println("Please enter two numbers to times: ");
 
								int timesInput1 = input.nextInt();
								int timesInput2 = input.nextInt();
 
									out.println((timesInput1) + " * " + (timesInput2) + " = " + (timesInput1 * timesInput2));
 
						}
 
							if (output.equals(divide)) {
								out.println("Please enter two numbers to divide: ");
 
									int divideInput1 = input.nextInt();
									int divideInput2 = input.nextInt();
 
										if (divideInput2 == 0) {
											out.println("You are a silly person, you cannot use 0");
										} else {
 
										out.println((divideInput1) + " / " + (divideInput2) + " = " + (divideInput1 / divideInput2));
										}	
							}
 
								if (output.equals(terminate)) {
									out.println();
									out.println("##################");
									out.println("PROGRAM TERMINATED");
									out.println("##################");
 
										loop++;
 
								}
 
								if (!output.equals (sqrt + times + add + divide + subtract)) {
									out.println("Incorrect input");
 
								}
									if (loop != 1) {
										out.println();
										out.println("Please choose another operation");
 
									}
 
		}
	}
}

Thanks in advance!

In order to check one thing regardless of the other, check one item first (string). If the item is wrong, ask for input until it is correct. Then move on and work on the next part (integers).

Thanks for the tip, but could you help me with my code please? I learn better that way, thanks.

Originally Posted by DrPerry

Thanks for the tip, but could you help me with my code please? I learn better that way, thanks.

Spoonfeed you working code? No. That would make me a bad person.

You said you are having problems detecting if the string is wrong rather than the string and the integer.
So take it one step at a time.

First get a string from the user.
Check the string to see if it is valid for your purpose.
---if not, repeat the 2 steps above.
---if so, move on to the next part.

Get an integer from the user.
Check the integer to see if it is valid for the purpose chosen by the user's string.
---if not, repeat the 2 steps above.
---if so, move on to the next part.

Get the second integer from the user.
Check the integer to see if it is valid for the purpose chosen by the user's string.
---if not, repeat the 2 steps above.
---if so, move on to the next part.

Calculate the result based on the string the user selected to start.
Output the result to the user.
Ask the user if they want to keep using the calculator.
Get the user's reply.
Check the reply to see if it is valid for the purpose of using the calculator more or exiting the program.
---if not, repeat the 2 steps above.
---if so, start the calcuator over or exit the program.

I don't feel like that helped me, also I only came here because I wanted someone to tell me how to fix my code, not tell me how to figure out how to fix my code. It's not exactly spoonfeeding if I only need help with one issue in my code and it's the first time I've needed it.

I appreciate the help you've given me, but could you please just tell me how to fix it? If not, I'll just move onto another forum. Thanks.

Originally Posted by DrPerry

...I only came here because I wanted someone to tell me how to fix my code, not tell me how to figure out how to fix my code.

Well that is not what I am here to do...

Originally Posted by DrPerry

It's not exactly spoonfeeding if I only need help with one issue in my code and it's the first time I've needed it.

I offered help. In fact I wrote out part of your pseudocode for you.

Originally Posted by DrPerry

I appreciate the help you've given me, but could you please just tell me how to fix it?

I told you how to fix it. Write code to do the actions in post #4.

Originally Posted by DrPerry

If not, I'll just move onto another forum.

Don't let the door hit you in the backside on the way out. I can spend my time helping other people who want help instead of answers.

Originally Posted by DrPerry

Thanks.

You are welcome.

Originally Posted by DrPerry

Oh it doesn't matter anyway, I fixed it.

As long as you are happy with it I guess.