Thread: Program should display number of positives\negatives\total\average

Should display like so:

Enter an int value, the program exits if the input is 0:
1 2 -1 3 0
The number of positives is 3
The number of negatives is 1
The total is 5
The average is 1.25

hi, my code is NOT working, I don't understand why, please help

 
import java.util.Scanner;
 
public class main41 {
 
	public static void main(String[] args)
	{
		System.out.println("Enter an int value, the program exits if the input is 0\n\n");
 
 
		int total=0, numOfPos=0, numOfNeg=0, n=0;
		double average=0;
 
		Scanner sin = new Scanner(System.in);
		n = sin.nextInt();
 
 
		total = total+n;
		average = total/n;
 
	while(n!=0)
	{
		//if the number is less than zero, count it
		if(n<0)
		{
			numOfNeg++;
		}
		//if the number is greater than zero, count it
		if(n>0)
		{
			numOfPos++;
		}	
			System.out.print("\r\nThe number of positives is: " + numOfPos);
			System.out.print("\r\nThe number of negatives is " + numOfNeg);
			System.out.print("\r\n\nThe total is: " + total);	
			System.out.print("\r\nThe average is: "+ average);
	}
}
 
 
}

my code is NOT working,

Please explain what "NOT working" means.
Does the program print out too many times, instead of printing one time at the end?

it won't work for me

What does the program do? You have not explained what "won't work" means.
What do you want to change about the way it works?

Try playing computer with the code. Look at the order that the statements are executed and write down the values of the variables as they are changed and look at the current value of the variable when it is tested and used.

The while loop is controlled by the value of n. Once inside the loop the only way to exit the loop is to change the value of n.
Look at the code in the loop. Is the value of n changed inside the loop? It must be changed for the execution to exit the loop.


Try working on the steps the code is supposed to do before writing any more code. Make a list of the steps the code should do (pseudo code) before writing any more code.
An example for adding the first numbers and printing the count:
Set counter to 0
begin loop using index (for loop)
add loop index to counter
end loop
print counter

hello again.. I found that this program is a lot more difficult to code than what it seems... I have it finally working now although it's buggy and if i enter -1 i get no output...

import java.util.Scanner;
 
public class main41 {
 
	public static void main(String[] args)
	{
		System.out.print("Enter an int value, the program exits if the input is 0");
 
		System.out.println("\n");
 
		Scanner sin = new Scanner(System.in);
 
		int total=0, numOfPos=0, numOfNeg=0;
		double average = 0.0, numbers = 0.0;
		final int maxLength = 6;
 
 
		int n = 1;
 
 
		while (n!=0 && n<maxLength)
		{
 
			n++;
 
 
				//if the number is less than zero, count it
				if(n<0)
				{
					numOfNeg++;
					if(numbers<=numOfNeg)
					{
						numbers++;
					}
				}
 
				//if the number is greater than zero, count it
				else if(n>0)
				{
					numOfPos++;
					if(numbers<=numOfPos)
					{
						numbers++;
					}
				}	
 
				else
				{
					System.exit(0);
				}
 
 
				n = sin.nextInt();
				total = total + n;
		}
 
				average = total/numbers;
 
	   if (n == 0)
	   {
		   System.out.println("\n\nERROR");
	   }
 
	   else if(total>0 || total<0 && n<maxLength)
	   {
				System.out.print("\nThe number of positives is: " + numOfPos);
				System.out.print("\nThe number of negatives is: " + numOfNeg);
				System.out.print("\nThe total is: " + total);
				System.out.print("\nThe average is: "+ average);
	   }
	}
}

some outputs:

Enter an int value, the program exits if the input is 0

1 2 3 4 5 6

The number of positives is: 6
The number of negatives is: 0
The total is: 21
The average is: 3.5

Enter an int value, the program exits if the input is 0

-2 3 4 5 7

The number of positives is: 4
The number of negatives is: 1
The total is: 17
The average is: 3.4

bugs:

Enter an int value, the program exits if the input is 0

1 4 6 7 8

The number of positives is: 3
The number of negatives is: 0
The total is: 11
The average is: 3.6666666666666665

Enter an int value, the program exits if the input is 0

-1 2 4 6 7
[terminates after enter (i think because n is initially declared as 1 and 1-1=0)]

believe me, you guys giving me tips like that really does not help me at all.. i've tried your advices, and tested 100's of other ways and they do not **** work. The code above was the only way i could get this 'close' to working.. the only way I can really see where i'm going wrong is if someone actually writes a 100% working code to this program. Otherwise I will not learn.

Try debugging the code by adding some println statements that print out the value of n each time its value is changed and each time its value is tested. You need to see what the code you have written is doing so you can understand why the program is doing what it is doing.

Some things to consider and document in your code:
what is the variable n used for? Add a comment describing what values it is supposed to contain.
What is the variable maxLength used for? How does it relate to n?

Why read data from the user into the variable n? Does that destroy what it is used for?