Thread: Creating an array from a string

I am having trouble taking a String type of data, extracting information from it, and then putting that information into an array. I have to extract the integers from the string while ignoring all non-digit characters

Ex: String: "223aiwij233.02 93"
Output: Array {223, 233, 02, 93}

The problem lies in the intParse method. My problem is that when I pull out the integers, the program is 'making up' numbers. Right now, the code breaks if there is more than 1 consecutive non-digit in the string and will run, but incorrectly if the String has only 1 non-digit character between integers. I have posted most of the code. After extracting the numbers, I will have to sort them, but I have already figured that part out.

 
public static void main(String[] args)
{
	Scanner stdIn = new Scanner(System.in);
	System.out.println("Enter a string: ");  
	String s = stdIn.next();  //String s from user
	int[] parsed = new int[10];  //Array parsed extracted from string s
	int[] sorted = new int[10];  //Array sorted from array parsed
 
	//call intParse method
	parsed = intParse(s);
 
	//call intSort method;
	sorted = intSort(parsed);
 
	stdIn.close();	
}
 
public static int[] intParse(String s)
{
	int[] numArray = new int[10];  //creating array to insert elements from string
	int j = 0;  //counter
	String number = "";  //empty string to hold integers from String s
	for (int i=0; i<s.length(); ++i)
	{
		if (Character.isDigit(s.charAt(i)))
		{
			number += s.charAt(i);  //if the current character is a digit, add it to the number string.  if not a digit, run code under else statement.
		}
		else
		{
			System.out.println(number);  //print the current number to screen
			numArray[j] = numToArr(number); //take the current string number and add it to next available array index by running the numToArray method
			++j; //increase j so the next empty array index will be used
			number = ""; //set the number string back to a blank and continue through for loop
		}
	}
	return numArray;
}
 
public static int numToArr(String b)
{
	int realNumber = Integer.parseInt(b);  
	return realNumber;
}

Well, first off, are there any exceptions that are being thrown? If so, please copy-paste the error message into the thread. Second, your intSort(); method is not in your posted code. If you want help, you need to include all methods that are being used. Does intSort(); just sort the array? What does it do?

Exception in thread "main" java.lang.NumberFormatException: For input string: ""
at java.lang.NumberFormatException.forInputString(Unk nown Source)
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at Program10.numToArr(Program10.java:55)
at Program10.intParse(Program10.java:36)
at Program10.main(Program10.java:14)


Below is the entire program:

import java.util.*;
 
public class Program10
{
	public static void main(String[] args)
	{
		Scanner stdIn = new Scanner(System.in);
		System.out.println("Enter a string: ");  
		String s = stdIn.next();  //String s from user
		int[] parsed = new int[10];  //Array parsed extracted from string s
		int[] sorted = new int[10];  //Array sorted from array parsed
 
		//call intParse method
		parsed = intParse(s);
 
		//call intSort method;
		sorted = intSort(parsed);
 
		stdIn.close();	
	}
 
	public static int[] intParse(String s)
	{
		int[] numArray = new int[10];  //creating array to insert elements from string
		int j = 0;  //counter
		String number = "";  //empty string to hold integers from String s
		for (int i=0; i<s.length(); ++i)
		{
			if (Character.isDigit(s.charAt(i)))
			{
				number += s.charAt(i);  //if the current character is a digit, add it to the number string.  if not a digit, run code under else statement.
			}
			else
			{
				System.out.println(number);  //print the current number to screen
				numArray[j] = numToArr(number); //take the current string number and add it to next available array index by running the numToArray method
				++j; //increase j so the next empty array index will be used
				number = ""; //set the number string back to a blank and continue through for loop
			}
		}
		return numArray;
	}
 
 
	public static int[] intSort(int[] s)
	{
		int[] sortArr = s;
		sort(s);
		return sortArr;
	}
 
 
	public static int numToArr(String b)
	{
		int realNumber = Integer.parseInt(b);
		return realNumber;
	}
 
	public static void sort(int[] list)
	{
		int j; // index of smallest value
		for (int i=0; i<list.length-1; i++)
		{
			j = indexOfNextSmallest(list, i);
			swap(list, i, j);
		}
	}
 
	private static int indexOfNextSmallest(int[] list, int startIndex)
	{
		int minIndex = startIndex; // index of smallest value
		for (int i=startIndex+1; i<list.length; i++)
		{
			if (list[i] < list[minIndex])
			{
				minIndex = i;
			}
		}
	return minIndex;
	} 
 
	private static void swap(int[] list, int i, int j)
	{
		int temp; // temporary holder for number
		temp = list[i];
		list[i] = list[j];
		list[j] = temp;
	}
 
}

OK, a NumberFormatException happens when you try to parse a non-number value into a number value.

//this throws a NumberFormatException because bob isn't a number
int x = Integer.parseInt("bob");

In order to fix it, you have to create a method that checks to see if the value you are parsing in a number.

Something like this

public boolean isNum(String num)
{
//Sorry, won't give you answers
//write an algorithm here that checks to see if num is a number
//return false if a non-number is found
//once looped through, return true
}

So, you're numToArr(); method, which is the one getting the exception, would look something like this:

public static int numToArr(String b)
	{
           if(isNum(b))
                return Integer.parseInt(b);
	}

Ok, I see that the problem is that my variable number is not being created the way I intended.

I put a system.out.print in the intParse() method in the if statement and else statement. Depending on the String s input by the user, my method of pulling out numbers is not working correctly.

Can you help me solve that part? There must be an issue with my logic in the If/Else statement. I want to step through the String s character by character. If the character is a digit, then add that digit to a String number. When the next character is no longer a digit, take that string number and parse it to be an integer then add it to the array. Then continue doing that same process until the end of String s. The logic is breaking down when there are consecutive non-digit characters in the string and I am not sure I can fix it without guidance. When the string has those consecutive non-digit characters, the program stops running and the number variable is either blank or never gets created.

public static int[] intParse(String s)
	{
		int[] numArray = new int[10];  //creating array to insert elements from string
		int j = 0;  //counter
		String number = "";  //empty string to hold integers from String s
		for (int i=0; i<s.length(); ++i)
		{
			if (Character.isDigit(s.charAt(i)))
			{
				number += s.charAt(i);  //if the current character is a digit, add it to the number string.  if not a digit, run code under else statement.
			}
			else
			{
				System.out.println(number);  //print the current number to screen
				numArray[j] = numToArr(number); //take the current string number and add it to next available array index by running the numToArray method
				++j; //increase j so the next empty array index will be used
				number = ""; //set the number string back to a blank and continue through for loop
			}
		}
		return numArray;
	}

In your else statement, you need another if/then statement that contains another loop, while/do while/for, that looks for the next digit. Your if then statement could check to see if number.length() == 0, if it does, then blah blah blah, other wise, use your current else statement code.

else
			{
                                if(number.length()==0)
                                {
                                         //code here 
                                }
                                else{
				        System.out.println(number);  //print the current number to screen
				        numArray[j] = numToArr(number); //take the current string number and add it to next available array index by running the numToArray method
				        ++j; //increase j so the next empty array index will be used
				        number = ""; //set the number string back to a blank and continue through for loop
                                }
			}