Help! Help! Help!

**dshainad** · December 19th, 2012, 04:32 AM

Can someone show me how to shorten my codes? Thanks!

package javaPackage;
import javax.swing.*;
import java.util.*;
public class Random
{
public static void main (String[] args)
{
Random input = new Random();
String games = "", roundTwo = "";
int user = 0, comp = 0, result = 0;

games = JOptionPane.showInputDialog(null, "Enter a number: \n1. Rock" +
"\n2. Paper \n3. Scissors: ", "Decision", JOptionPane.INFORMATION_MESSAGE);
user = Integer.parseInt(games);

comp = (int) (Math.random() *3);

JOptionPane.showMessageDialog(null, "The computer's choice is: " +
(comp+1), "Computer", JOptionPane.INFORMATION_MESSAGE);

if (user == 1 && comp == 0)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user ==1 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user ==1 && comp == 2)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user == 2 && comp == 0)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 2 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 2 && comp ==2)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 3 && comp ==0)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 3 && comp == 1)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user==3 && comp == 2)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else
JOptionPane.showMessageDialog(null, "Invalid input.", "Error",
JOptionPane.ERROR_MESSAGE);

roundTwo = JOptionPane.showInputDialog(null, "Another round? 0 if no, 1 if yes ", "Round",
JOptionPane.INFORMATION_MESSAGE);
result = Integer.parseInt(roundTwo);

while (result == 1)
{
games = JOptionPane.showInputDialog(null, "Enter a number: \n1. Rock" +
"\n2. Paper \n3. Scissors: ", "Decision", JOptionPane.INFORMATION_MESSAGE);
user = Integer.parseInt(games);

comp = (int) (Math.random() *3);

JOptionPane.showMessageDialog(null, "The computer's choice is: " +
(comp+1), "Computer", JOptionPane.INFORMATION_MESSAGE);

if (user == 1 && comp == 0)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user ==1 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user ==1 && comp == 2)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user == 2 && comp == 0)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 2 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 2 && comp ==2)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 3 && comp ==0)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if (user == 3 && comp == 1)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else if(user==3 && comp == 2)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}

else
JOptionPane.showMessageDialog(null, "Invalid input.", "Error",
JOptionPane.ERROR_MESSAGE);

roundTwo = JOptionPane.showInputDialog(null, "Another round? 0 if no, 1 if yes ", "Round",
JOptionPane.INFORMATION_MESSAGE);
result = Integer.parseInt(roundTwo);

}
}
}

**Norm** · December 19th, 2012, 07:38 AM

Please edit your post and wrap your code with
[code=java]
<YOUR CODE HERE>
[/code]
to get highlighting and preserve formatting.

**dshainad** · December 19th, 2012, 07:51 AM

Okay.

One more, how can I make it array oriented? Please, help!

package javaPackage;
import javax.swing.*;
import java.util.*;
public class Random 
{
public static void main (String[] args)
{
Random input = new Random();
String games = "", roundTwo = "";
int user = 0, comp = 0, result = 0;
 
games = JOptionPane.showInputDialog(null, "Enter a number: \n1. Rock" +
"\n2. Paper \n3. Scissors: ", "Decision", JOptionPane.INFORMATION_MESSAGE);
user = Integer.parseInt(games);	
 
comp = (int) (Math.random() *3);	
 
JOptionPane.showMessageDialog(null, "The computer's choice is: " +
(comp+1), "Computer", JOptionPane.INFORMATION_MESSAGE);
 
if (user == 1 && comp == 0)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user ==1 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user ==1 && comp == 2)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user == 2 && comp == 0)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 2 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 2 && comp ==2)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 3 && comp ==0)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 3 && comp == 1)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user==3 && comp == 2)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else
JOptionPane.showMessageDialog(null, "Invalid input.", "Error",
JOptionPane.ERROR_MESSAGE);
 
roundTwo = JOptionPane.showInputDialog(null, "Another round? 0 if no, 1 if yes ", "Round",
JOptionPane.INFORMATION_MESSAGE);
result = Integer.parseInt(roundTwo);
 
while (result == 1)
{
games = JOptionPane.showInputDialog(null, "Enter a number: \n1. Rock" +
"\n2. Paper \n3. Scissors: ", "Decision", JOptionPane.INFORMATION_MESSAGE);
user = Integer.parseInt(games);	
 
comp = (int) (Math.random() *3);	
 
JOptionPane.showMessageDialog(null, "The computer's choice is: " +
(comp+1), "Computer", JOptionPane.INFORMATION_MESSAGE);
 
if (user == 1 && comp == 0)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user ==1 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user ==1 && comp == 2)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user == 2 && comp == 0)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 2 && comp == 1)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 2 && comp ==2)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 3 && comp ==0)
{
JOptionPane.showMessageDialog(null, "The computer won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if (user == 3 && comp == 1)
{
JOptionPane.showMessageDialog(null, "You won.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else if(user==3 && comp == 2)
{
JOptionPane.showMessageDialog(null, "The match is draw.", "Result",
JOptionPane.INFORMATION_MESSAGE);
}
 
else
JOptionPane.showMessageDialog(null, "Invalid input.", "Error",
JOptionPane.ERROR_MESSAGE);
 
roundTwo = JOptionPane.showInputDialog(null, "Another round? 0 if no, 1 if yes ", "Round",
JOptionPane.INFORMATION_MESSAGE);
result = Integer.parseInt(roundTwo);
 
}
}
}

**Norm** · December 19th, 2012, 08:10 AM

Please format the code so that the nested statements are properly indented 3-4 spaces. All the statements should NOT start in the first column.
Unformatted code is hard to read and understand.

Instead of repeating the test for the user, have one test for the each user and nest within that if the other ifs:

if (user1) {
   if(comp1) {
   }else if(comp2) {
   }else{}
}else if (user2) {
}

**KevinWorkman** · December 19th, 2012, 08:32 AM

Also, please use more descriptive titles. Something like "Help! Help! Help!" doesn't tell us anything about what you're actually asking, so you're less likely to receive help right away. Norm was nice enough to click on your link, but a more descriptive title makes it clear what you're asking, which makes it more likely more people will try to help. Please see the link in my signature on asking questions the smart way for more information.

**chri** · December 25th, 2012, 05:36 PM

you could use switch statement

switch(user){
case 1:
switch(comp)
case 1:
do whatever
break;
case 2:
...
}

**C++kingKnowledge** · December 25th, 2012, 11:54 PM

to clean the code up you can make your roundTwo variable a showConfirmDialog and change your while statement afterwards to an if statement that runs the game again should the user select yes... instead of repeating the exact code again for roundTwo you should make a method that handles the game results (all those if codes you wrote) so that way all you have to do is refer to the method and it will execute the code again for u if the user wants to play again

**JJeng** · December 27th, 2012, 11:16 AM

if equal

draw

if any of the lose condition

lose

else

win

Thread: Help! Help! Help!

LinkBack

Thread Tools

Display

Help! Help! Help!

Re: Help! Help! Help!

Re: Help! Help! Help!

Re: Help! Help! Help!

Re: Help! Help! Help!

Re: Help! Help! Help!

Re: Help! Help! Help!

Re: Help! Help! Help!