Thread: Help me with my code (im learning Java)

class ifelse {
	public static void main (String args []) {
		String name = "Sammy";
 
		if (name == "Sammy"); {
			System.out.println("Hello "+ name);
		}else{
			System.out.println("Sorry but you are not "+ name);
		}
	}
}

What does this mean? (below)

Syntax error on token "else", delete this token

and how can i fix my code?

Thanks for this, however i tried entering my new code:

import java.util.Scanner;
 
class ifelse {
	public static void main (String args []) {
		String name = "Sammy";
 
		Scanner scanner1 = new Scanner (System.in);
		System.out.println("Hello, What is your name?");
		System.out.println(scanner1.nextLine());
		if (name == "Sammy") {
			System.out.println("Hello "+ name);
		}else{
			System.out.println("Sorry but you are not "+ name);
		}
	}
}

and i want it to be: if the input for the name is not "Sammy" it will message "Sorry but you are not " + name.
But, if the user DOES input the word "Sammy" it will send message "Hello "+ name.

Thanks =)

Hi R0bsterz,

You set a string variable for Sammy, but then you're using the same one for the input and comparison.

also

Don't compare strings with ==. Use .equals()

if (entry.equals(name)) ...

Class names usually start with a capital letter.

Don't forget to 'close' the scanner after use.

Originally Posted by Starstreak

Hi R0bsterz,

You set a string variable for Sammy, but then you're using the same one for the input and comparison.

also

Don't compare strings with ==. Use .equals()

if (entry.equals(name)) ...

Class names usually start with a capital letter.

Don't forget to 'close' the scanner after use.

Thanks for this, so to close the scanner i do

scanner1.close();

--- Update ---

import java.util.Scanner;
 
class ifelse {
	public static void main (String args []) {
		String name = "Sammy";
 
		Scanner scanner1 = new Scanner (System.in);
		System.out.println("Hello, What is your name?");
		System.out.println(scanner1.nextLine());
		if (entry.equals("Sammy")) {
			System.out.println("Hello "+ name);
		}else{
			System.out.println("Sorry but you are not "+ name);
		}
	}
}

Will this code work?

and i want it to be: if the input for the name is not "Sammy" it will message "Sorry but you are not " + name.
But, if the user DOES input the word "Sammy" it will send message "Hello "+ name.

I read your post but how will i create a new variable for the input?

You need one variable for the name you have in the beginning "Sammy" and a separate one that gets input by the user.

Sorry, but i dont understand what you mean by a seperate one input by the user, please could you add the code to my code and show me,

Thanks =]

Ok, so i edited the code a bit and it now looks like this:

import java.util.Scanner;
 
class ifelse {
	public static void main (String args []) {
		String name = "Sammy";
 
		Scanner scanner1 = new Scanner (System.in);
		System.out.println("Hello, What is your name?");
		scanner1.nextLine();
		if (name.equals("Sammy")) {
			System.out.println("Hello "+ name);
		}else{
			System.out.println("Sorry but you are not "+ name);
 
			scanner1.close();
		}
	}
}

But, when i compile and execute the code - it turns out like this:

Hello, What is your name?
Test
Hello Sammy

It should turn out as

"Sorry but you are not "+ name;

Please help me and tell me how to fix it =]

Declare two variables:

use name as the String variable for Sammy

use guest as a variable for the name that gets read in by scanner.

Now compare name to guest in the if/else statement.

Can't be clearer than that ..

At the moment, name will always be "Sammy"

import java.util.Scanner;
 
class ifelse {
	public static void main (String args []) {
		String name = "Sammy";
 
		Scanner guest = new Scanner (System.in);
		System.out.println("Hello, What is your name?");
		guest.nextLine();
		if (name.equals(name)) {
			System.out.println("Hello "+ name);
		}else{
			System.out.println("Sorry but you are not "+ name);
 
			guest.close();
		}
	}
}

How do i do an if/else statement for the Scanner bit?

Originally Posted by Norm

Where does the code save the String that is returned by the nextLine() method?
Here the code saves in guest what is returned by the Scanner class's constructor:

Scanner guest = new Scanner (System.in);

if (name.equals(name))

When would this compare NOT be true? Something should always be equal to itself.
You want to compare what is read in from the user to name.

Sorry but i really dont understand you..
Please add what your saying to my code and i will be eternally grateful.

This is my code at the moment. Sorry Norm, but I do not understand what you are saying when you are trying to help me , please edit my code and 'fix it' and add comments on each line so i can learn e.g //creates a variable to store (name)

Thanks =)

import java.util.Scanner;
 
class ifelse {
	public static void main (String args[]) {
 
		Scanner uinput = new Scanner (System.in);
		String uinputvar = uinput.nextLine();
		String name = "Sammy";
		System.out.println("Hello, What is your name?");
		if (name.equals(name)) {
		System.out.println("Hello Sammy");
		}else{
			System.out.println("Sorry but you are not "+name);
 
			uinput.close();
		}
	}
}

Fix this code instead:

import java.util.Scanner;
 
class ifelse {
	public static void main (String args []) {
		String name = "Sammy";
 
		Scanner guest = new Scanner (System.in);
		System.out.println("Hello, What is your name?");
		guest.nextLine();
		if (name.equals(name)) {
			System.out.println("Hello "+ name);
		}else{
			System.out.println("Sorry but you are not "+ name);
 
			guest.close();
		}
	}
}

I want it to be: if the input for the name is not "Sammy" it will message "Sorry but you are not " + name.
But, if the user DOES input the word "Sammy" it will send message "Hello "+ name.

The console outputs as:

Hello, What is your name?
Test
Hello Sammy //This should be ''Sorry but you are not "" + name;

1. When i ran the code in post #20 it didnt run properly -- looks like i didnt close the scanner or somthing.
2. i didnt understand post #21
3. if (name.equals(name)) {
was meant to mean: if the variable name (which equaled "Sammy") was entered, then it would say "Hello Sammy"
Otherwise, it would say "Sorry but you are not "+name;