Thread: Need help with loop

It is a loop program that counts Yes votes with 'Y', no votes with "N" and to quit is "Q" and after quit is chosen it shows number of yes votes and number of no votes, all in a dialog box. Here it is, when I enter Y, y, N or n it crashes, but Q or q works

import javax.swing.JOptionPane;

public class program05 {

public static void main(String[] args) {

int yes = 0;

int no = 0;

String reply;

char firstChar;

int buttonPressed = 1;

while (buttonPressed != 0) {

reply = JOptionPane.showInputDialog(null,
"Enter 'Y' to vote yes, 'N' to vote no, or 'Q' to quit.");

firstChar = reply.charAt(0);

if (firstChar == 'Y' || firstChar == 'y') {

int yesVotes = Integer.parseInt (reply);

yes += yesVotes;
}

else if (firstChar == 'N' || firstChar == 'n') {

int noVotes = Integer.parseInt (reply);

no += noVotes;

}

else if (firstChar == 'Q' || firstChar == 'q') {

buttonPressed = JOptionPane.showConfirmDialog(null, "Really quit?");
}
}

JOptionPane.showMessageDialog
(null, "Total Yes votes is " + yes + " and total No votes is " + no);
}
}



here is the exception message

Exception in thread "main" java.lang.NumberFormatException: For input string: "y"
at java.lang.NumberFormatException.forInputString(Num berFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:492)
at java.lang.Integer.parseInt(Integer.java:527)
at program05.main(program05.java:26)
Java Result: 1
BUILD SUCCESSFUL (total time: 5 seconds)

The exception message should tell you exactly what the problem is. Please post it in its entirety.

Hint: think about exactly what you're trying to parse into an int.

Also, please have a look at the forum FAQ at some point to learn about use of code tags so that your code will retain its formatting when posted in the forum allowing us to be able to read it better and understand it better.

Here it is:
Exception in thread "main" java.lang.NumberFormatException: For input string: "y"
at java.lang.NumberFormatException.forInputString(Num berFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:492)
at java.lang.Integer.parseInt(Integer.java:527)
at program05.main(program05.java:26)
Java Result: 1
BUILD SUCCESSFUL (total time: 5 seconds)

Yep exactly, what's on line 26 of program05.java?

this:

int yesVotes = Integer.parseInt (reply);

What's the error telling you?
this:

Exception in thread "main" java.lang.NumberFormatException: For input string: "y"

And so the error message makes complete sense. The user is entering "y" for yes, and you're trying to parse that "y" as an integer, which makes no sense at all. The solution, learn from the error message, and don't do this, don't try to parse a non-numeric String as a number. Instead re-consider your logic.

How do I make a non-numeric letter represent an integer value? It can only be "Y" "N" or "Q"

Originally Posted by JohnEliot

How do I make a non-numeric letter represent an integer value? It can only be "Y" "N" or "Q"

You can't and even if you could, why would you want to? All you want to do is add 1 to a counter variable