Thread: Presumably simple fix sets/maps

I have made a good bit of progress with my code and am now stuck on something I believe to be quite simple. I have it printing out the line numbers that the word occurs on in the supplied text file but it is not supposed to count multiple occurances on the same line.
Text file:
string
cat
mouse mouse
phone
phone

//Name: Hal Walters
//Class: SCSC 321
//Date: 3/10/2013
 
import java.io.IOException;
import java.io.BufferedReader;
import java.io.FileReader;
import java.util.*;
 
public class driver1 {
 
	@SuppressWarnings({ "resource", "rawtypes", "unchecked" })
	public static void main(String[] args) {
 
		String fileName = "strings.txt";
		try{
			BufferedReader inFile = new BufferedReader(new FileReader(fileName));
			Map wordMap = new TreeMap();
			String oneLine;
 
			//Read the wortds and add them to the wordMap
			for (int lineNum = 1; (oneLine = inFile.readLine()) != null; lineNum++){
				StringTokenizer st = new StringTokenizer(oneLine);
				while (st.hasMoreTokens()){
					String word = st.nextToken();
					List lines = (List) wordMap.get(word);
					if (lines == null){
						lines = new LinkedList();
						wordMap.put(word, lines);
					}
					lines.add(new Integer(lineNum));
				}
			}
 
			//go through the word map
			Iterator itr = wordMap.entrySet().iterator();
			while (itr.hasNext()){
				printEntry((Map.Entry) itr.next());
			}
		}
			catch(IOException e){
				e.printStackTrace();
			}
	}
 
	//prints everything
	@SuppressWarnings("rawtypes")
	public static void printEntry(Map.Entry entry){
 
		//print the word and line numbers
		Iterator itr = ((List)(entry.getValue())).iterator();
		System.out.print(entry.getKey() + ": " + itr.next());
		while (itr.hasNext()){
			if (itr.equals(itr.next())){
				return;
			}
			else{
				System.out.print(", " + itr.next());
			}
		}
		System.out.println();
	}
}

As always, thanks in advance.

The problem is around the if statement inside the printEntry method.

Output:

I updated the first post.

Edit- Also went back and messed around with my code more and got it to a point where I feel it is even closer. I also added some code for formatting and counting word occurances. This is only the printEntry method.

	//prints id, line numbers, and occurance for the individual entry
	@SuppressWarnings("rawtypes")
	public static void printEntry(Map.Entry entry){
 
		//local occurance variable
		int occurance = 1;
 
		//print the word and the line numbers
		Iterator itr = ((List) entry.getValue()).iterator();
		System.out.print("ID: " + entry.getKey() + "   Lines: " + itr.next());
		while(itr.hasNext()){
			if (itr.toString() != itr.next().toString()){
			System.out.print(", " + itr.next());
			occurance++;
			}
			else{
				return;
			}
		}
		System.out.print("  " + " Occurance: " + occurance);
		System.out.println();
	}

if (itr.toString() != itr.next().toString()){
			System.out.print(", " + itr.next());
			occurance++;
			}
			else{
				return;
			}

well, i know this much already doesn't work. It should be something simple but I have no idea how to do it.

Originally Posted by Norm

Is it ok to have duplicate line numbers in the list?

Not for a single identifier. In other words, any given line number should not appear more than once on a line in the console.

--- Update ---

Originally Posted by helloworld922

String comparison shouldn't be done using comparison operators, rather you should use the .equals() method.

I played around with that a little bit but couldn't get it to work. I will go back and try again. Thanks.

Helloworld, something like this?

if (itr.toString().equals(itr.next()))

			//Read the words and add them to the wordMap
			for (int lineNum = 1; (oneLine = inFile.readLine()) != null; lineNum++){
				StringTokenizer st = new StringTokenizer(oneLine);
				while (st.hasMoreTokens()){
					String word = st.nextToken();
					List lines = (List) wordMap.get(word);
 
					//if list is empty/doesnt exist
					if (lines == null){
						lines = new LinkedList();
						wordMap.put(word, lines);
					}
					//presumably checks for duplicates
					else if (lines.contains(lineNum)){
						System.out.println("inside if statement");
						return;
					}
					//list wasnt empty, lineNum being inserted wasnt a dup
					else{
					lines.add(new Integer(lineNum));
					}
				}
			}

Am I close?

Thanks for the help so far. Let me know if you cannot read the text.

Running.
Exception in thread "main" java.util.NoSuchElementException
at java.util.LinkedList$ListItr.next(Unknown Source)
at driver1.printEntry(driver1.java:67)
at driver1.main(driver1.java:50)

//Name: Hal Walters
//Class: SCSC 321
//Date: 3/10/2013
 
import java.io.IOException;
import java.io.BufferedReader;
import java.io.FileReader;
import java.util.*;
 
public class driver1 {
 
	@SuppressWarnings({ "unchecked", "rawtypes", "resource" })
	public static void main(String[] args) {
 
		int check;
		System.out.println("Running.");
		String fileName = "strings.txt";
		try{
			BufferedReader inFile = new BufferedReader(new FileReader(fileName));
			Map wordMap = new TreeMap();
			String oneLine;
 
			//Read the words and add them to the wordMap
			for (int lineNum = 1; (oneLine = inFile.readLine()) != null; lineNum++){
				StringTokenizer st = new StringTokenizer(oneLine);
				while (st.hasMoreTokens()){
					String word = st.nextToken();
					List lines = (List) wordMap.get(word);
 
					//if list is empty/doesnt exist
					if (lines == null){
						lines = new LinkedList();
						wordMap.put(word, lines);
					}
					//presumably checks for duplicates
					else if (lines.contains(lineNum)){
						System.out.println("inside if statement");
						return;
					}
					//list wasnt empty, lineNum being inserted wasnt a dup
					else{
					lines.add(new Integer(lineNum));
					}
				}
			}
 
			//goes through the word map
			Iterator itr = wordMap.entrySet().iterator();
			while (itr.hasNext()){
				printEntry((Map.Entry) itr.next());
			}
		}
			catch(IOException e){
				e.printStackTrace();
			}
	}
 
	//prints id, line numbers, and occurance for the individual entry
	@SuppressWarnings("rawtypes")
	public static void printEntry(Map.Entry entry){
 
		//local occurance variable
		int occurance = 1;
 
		//print the word and the line numbers
		Iterator itr = ((List) entry.getValue()).iterator();
		System.out.print("ID: " + entry.getKey() + "   Lines: " + itr.next());
		while(itr.hasNext()){
			System.out.print(", " + itr.next());
			occurance++;
			}
		System.out.print("  " + " Occurance: " + occurance);
		System.out.println();
	}
}

So get rid of the elseif statement and put something in around the while loop at the bottom of the main class?

Forgive my ignorance, but where? There is a hasNext() call on line 49 when it runs through the iterator to call the printEntry method.

//Name: Hal Walters
//Class: SCSC 321
//Date: 3/10/2013
 
import java.io.IOException;
import java.io.BufferedReader;
import java.io.FileReader;
import java.util.*;
 
public class driver1 {
 
	@SuppressWarnings({ "unchecked", "rawtypes", "resource" })
	public static void main(String[] args) {
 
		System.out.println("Running.");
		String fileName = "strings.txt";
		try{
			BufferedReader inFile = new BufferedReader(new FileReader(fileName));
			Map wordMap = new TreeMap();
			String oneLine;
 
			//Read the words and add them to the wordMap
			for (int lineNum = 1; (oneLine = inFile.readLine()) != null; lineNum++){
				StringTokenizer st = new StringTokenizer(oneLine);
				while (st.hasMoreTokens()){
					String word = st.nextToken();
					List lines = (List) wordMap.get(word);
 
					//if list is empty/doesnt exist
					if (lines == null){
						lines = new LinkedList();
						wordMap.put(word, lines);
					}
					lines.add(new Integer(lineNum));
 
				}
			}
 
			//goes through the word map
			Iterator itr = wordMap.entrySet().iterator();
			while (itr.hasNext()){
				printEntry((Map.Entry) itr.next());
			}
		}
			catch(IOException e){
				e.printStackTrace();
			}
	}
 
	//prints id, line numbers, and occurance for the individual entry
	@SuppressWarnings("rawtypes")
	public static void printEntry(Map.Entry entry){
 
		//local occurance variable
		int occurance = 1;
 
		//print the word and the line numbers
		Iterator itr = ((List) entry.getValue()).iterator();
		System.out.print("ID: " + entry.getKey() + "   Lines: " + itr.next());
		while(itr.hasNext()){
			if(itr.equals(itr.next()))
			System.out.print(", " + itr.next());
			occurance++;
			}
		System.out.print("  " + " Occurance: " + occurance);
		System.out.println();
	}
}

Its soooooo close.

Output:
Running.
ID: cat Lines: 2 Occurance: 1
ID: mouse Lines: 3 Occurance: 2
ID: phone Lines: 4 Occurance: 2
ID: string Lines: 1 Occurance: 1

Phone should also have 5 listed as a line occurance. The occurance counts are right, and the mouse line occurance is correct. Phone seems to be the last thing.

//Name: Hal Walters
//Class: SCSC 321
//Date: 3/10/2013
 
import java.io.IOException;
import java.io.BufferedReader;
import java.io.FileReader;
import java.util.*;
 
public class driver1 {
 
	@SuppressWarnings({ "unchecked", "rawtypes", "resource" })
	public static void main(String[] args) {
 
		System.out.println("Running.");
		String fileName = "strings.txt";
		try{
			BufferedReader inFile = new BufferedReader(new FileReader(fileName));
			Map wordMap = new TreeMap();
			String oneLine;
 
			//Read the words and add them to the wordMap
			for (int lineNum = 1; (oneLine = inFile.readLine()) != null; lineNum++){
				StringTokenizer st = new StringTokenizer(oneLine);
				while (st.hasMoreTokens()){
					String word = st.nextToken();
					List lines = (List) wordMap.get(word);
 
					//if list is empty/doesnt exist
					if (lines == null){
						lines = new LinkedList();
						wordMap.put(word, lines);
					}
					lines.add(new Integer(lineNum));	
				}
			}
 
			//goes through the word map
			Iterator itr = wordMap.entrySet().iterator();
			while (itr.hasNext()){
				printEntry((Map.Entry) itr.next());
			}
		}
			catch(IOException e){
				e.printStackTrace();
			}
	}
 
	//prints id, line numbers, and occurance for the individual entry
	@SuppressWarnings("rawtypes")
	public static void printEntry(Map.Entry entry){
 
		//local occurance variable
		int occurance = 1;
 
		//print the word and the line numbers as well as test for duplicate line integers on the same key
		Iterator itr = ((List) entry.getValue()).iterator();
		System.out.print("ID: " + entry.getKey() + "   Lines: " + itr.next());
		while(itr.hasNext()){
			if(itr.equals(itr.next())){
				System.out.println("blah");
			}
			else{
			System.out.print(", " + itr.next());
			occurance++;
			}	
		}
		System.out.print("  " + " Occurance: " + occurance);
		System.out.println();
	}
}

I spoke too soon. I am back to my original code. I realized that I need the negative of the if statement in the printEntry method.
It's:

if (!itr.equals(itr.next()))

...right?

if so, its throwing an error:
Running.
ID: cat Lines: 2 Occurance: 1
ID: mouse Lines: 3Exception in thread "main" java.util.NoSuchElementException
at java.util.LinkedList$ListItr.next(Unknown Source)
at driver1.printEntry(driver1.java:64)
at driver1.main(driver1.java:41)

	public static void printEntry(Map.Entry entry){
 
		//local occurance variable
		int occurance = 1;
		System.out.println(entry.getValue().toString());
 
		//print the word and the line numbers as well as test for duplicate line integers on the same key
		Iterator itr = ((List) entry.getValue()).iterator();
		System.out.print("ID: " + entry.getKey() + "   Lines: " + itr.next());
		while(itr.hasNext()){
			if(itr.equals(itr.next())){
			//	System.out.println("blah");
			//}
			//else{
			System.out.print(", " + itr.next());
			occurance++;
			}	
		}
		System.out.print("  " + " Occurance: " + occurance);
		System.out.println();
	}

Output:
Running.
[2]
ID: cat Lines: 2 Occurance: 1
[3, 3]
ID: mouse Lines: 3 Occurance: 1
[4, 5]
ID: phone Lines: 4 Occurance: 1
[1]
ID: string Lines: 1 Occurance: 1

I need the if statement to test for a 'does not' equal value but I am not really sure how.