Thread: Beginner java problem

Hello everyone!

I've been messing around withJava swing for a while now. I'm trying a draw a text in the mouse position everytime a mousebutton is pressed,
but the problem is that everytime you release the mousebutton the string stays on the screen.

package windowtraining;
import javax.swing.SwingUtilities;
import javax.swing.JPanel;
import javax.swing.JFrame;
import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
import java.awt.Color;
 
 
 
 
public class Windowtraining{
 
    public static void main(String[] args)
    {
        SwingUtilities.invokeLater(new Runnable(){
            public void run(){
                createAndShowGUI();
            }
        });
    }    
 
    public static void createAndShowGUI(){
 
        JFrame f = new JFrame("JFrame test!");
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.add(new myPanel());
        f.pack();
        f.setVisible(true);
 
    }
 
}
 
class myPanel extends JPanel{
 
    private int squarex;
    private int squarey;
    private int squarew = 32;
    private int squareh = 32;
    private int switchmouse = 0;
    private int smilex;
    private int smiley;
 
 
    public myPanel(){
 
        addMouseListener(new MouseAdapter(){
            public void mousePressed(MouseEvent e){
            moveSquare(e.getX(),e.getY());
        }
        });
 
        addMouseMotionListener(new MouseAdapter(){
            public void mouseDragged(MouseEvent e){
                switchmouse = 1;
                smilex = e.getX(); smiley = e.getY();
            }
        });
 
        addMouseMotionListener(new MouseAdapter(){
            public void mouseReleased(MouseEvent e){
                switchmouse = 0;
            }
        });
 
 
        addMouseMotionListener(new MouseAdapter(){
            public void mouseDragged(MouseEvent e){
                moveSquare(e.getX(),e.getY());
            }
        });
 
}
 
 
    private void moveSquare(int x, int y){
        int Offset = 1;
        if (squarex != x || squarey != y)
        {
        repaint(squarex,squarey,squarew,squareh);
        squarex = x - 16;
        squarey = y - 16;
        repaint(squarex,squarey,squarew,squareh);
        }
 
    }
 
    /*private void drawSmile(int x, int y){
 
        if (smilex != x || smiley != y){
 
           update(smilex, smiley );
 
        }
 
    }*/
 
 
 
 
 
    public Dimension getPreferredSize(){
 
        return new Dimension(640,480);
 
    }
 
    public void paintComponent(Graphics g){
 
        super.paintComponent(g);
        {
        super.paintComponent(g);
 
        g.setColor(Color.RED);
       g.fillRect(squarex, squarey, squarew, squareh);
 
        //if (dragSwitch == 1)
        g.setColor(Color.WHITE);
        g.fillRect(0,0,640,480);
 
 
        g.setColor(Color.BLUE);
 
        if (switchmouse == 1)
                {g.drawString(":D",smilex,smiley);}
 
 
        }
 
 
 
    }
 
 
 
}

What should I do to draw a string in the mouse position when the player presses a
mouse button but which disappears when you release it?

Originally Posted by Norm

There is a listener for mouse released. Have it tell the paintComponent method not to draw the text.
You need to call the repaint() method so that the jvm will call the paintComponent method to implement the change in what should be displayed.

Make sure to use {}s with if statements to enclose the statements that are controlled by the if statement.

Don't hide the {}s by having code on the same line after a { or before a }

Should I call the repaint component inside the mouseReleased bacets?:

addMouseMotionListener(new MouseAdapter(){
public void mouseReleased(MouseEvent e){
switchmouse = 0;
repaint(smilex, smiley);
}
});

It gives me an error though. I don't really understand... Could you explain a bit further?

I can't find any document where its says how to use repaint :/, or at least no ducument which I understand. I'm very new to Java so I would really appreciate if you could explain where and how I should use repaint. If it isn't too much of a bother.

I think I got it now, The string gets refreshed and does not multiply. But (sorry for being a pain in the ass) the string does not disappear when the mousebutton is released, which I would like it to do. How do I tell the program not to keep drawing the string. I tryed just using if statements to controll the drawings but that didn't work.

Yes! I got it! I added another mouse_listener to change the variable to zero when the mousebutton was released, which worked

The listener that was supposed to change the variabel before was a motion listener so it only worked when it was moving and released, or something like that.
But now the variabel could be changed to zero when the mousebutton was released when not moving.

Thank you so much for your help, I've learnt quite a lot!