Thread: Hangman minor issues

I need to get it to say what letters have already been guessed. And I need it to cut the game off when the user wins. Oh and one last little thing. For some reason, it is printing the correct letters on the hangman dashes at the top of the hangman.


import java.io.*; //for file
import java.util.*; //for scanner

public class Lab65 {
static String userG = "";
public static void main(String[] args)throws FileNotFoundException{

int wrong = 0; // keeps track of user guesses
String word = readwords();
boolean temp = false;

String[] words = new String[word.length()];
String[] words2 = new String[word.length()];

//methods to be used
userGuess(word, words, words2);
printhm(wrong);

//introduce user to game
System.out.println("Welcome to hangman!");
System.out.println("Begin guessing letters!");
System.out.println("These letters have already been guessed!");
userGuess(words);

//keep track of wrong user guesses

while(wrong <6) {
temp = add(words, words2);
userGuess(words);

if(temp == false) {
wrong++;
printhm(wrong);
System.out.println("Incorrect guess!" + (6 - wrong) + " more guesses left!");
System.out.println();
System.out.println(userG);

System.out.println();
System.out.println(" These letters have already been guessed!");
System.out.println("Make another guess!");

}else{ //user guess is correct
printhm(wrong);
System.out.println("Correct guess!");
System.out.println(" These letters have already been guessed!");

System.out.println(userG);
System.out.println("Make another guess!");

}
}
}
//display hangman
public static void printhm(int wrong) {

//hangman display
if(wrong == 0) {
System.out.println(" ------");
System.out.println(" | |");
System.out.println(" |");
System.out.println(" |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 1){
System.out.println(" --------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println(" |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 2) {
System.out.println(" --------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println(" | |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 3) {
System.out.println(" --------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/| |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 4){
System.out.println(" ---------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/|\\ |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 5){
System.out.println(" ---------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/|\\ |");
System.out.println("/ |");
System.out.println(" |");
}
else {

System.out.println(" ---------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/|\\ |");
System.out.println("/ \\ |");
System.out.println(" |");
System.out.println( "You lost! Better luck next time!!" );
}

}
// keep track of wrong guesses
public static String readwords() throws FileNotFoundException {
Scanner input = new Scanner(new File("hangman.txt"));
String[] word = new String[10];
String rword = "";

for(int i = 0; i < word.length; i++){
if (input.hasNext()) {

word[i] = input.next();

}else {
break;

}
}

Random rand = new Random();

int r = rand.nextInt(9);

rword = word[r];
return rword;
}

public static void userGuess(String y, String[] m, String[] words2){
for (int i=0; i < y.length(); i++){
m[i] = "-";
}
for (int x = 0; x < y.length(); x++){
if (x + 1 < y.length())
words2[x] = y.substring(x, x + 1);
else
words2[x] = y.substring(x, y.length());
}
}

public static boolean add(String[] m, String[] ma) { //find if letters are in the word
Scanner console = new Scanner(System.in);
String letters = console.next();
boolean found = false;

for(int i = 0; i < ma.length; i++) {
if(ma [i].equals(letters)){
m[i] = letters;
found = true;
}
}
if(found) {
return true;
}
else {
return false;
}
}

public static void userGuess(String[] m) {
for(int i = 0; i < m.length; i++) {
System.out.print(m[i] );
}

}

}

import java.io.*; //for file
import java.util.*; //for scanner

public class Lab65 {
static String userG = "";
public static void main(String[] args)throws FileNotFoundException{

int wrong = 0; // keeps track of user guesses
String word = readwords();
boolean temp = false;

String[] words = new String[word.length()];
String[] words2 = new String[word.length()];

//methods to be used
userGuess(word, words, words2);
printhm(wrong);

//introduce user to game
System.out.println("Welcome to hangman!");
System.out.println("Begin guessing letters!");
System.out.println("These letters have already been guessed!");
userGuess(words);

//keep track of wrong user guesses

while(wrong <6) {
temp = add(words, words2);
userGuess(words);

if(temp == false) {
wrong++;
printhm(wrong);
System.out.println("Incorrect guess!" + (6 - wrong) + " more guesses left!");
System.out.println();
System.out.println(userG);

System.out.println();
System.out.println(" These letters have already been guessed!");
System.out.println("Make another guess!");

}else{ //user guess is correct
printhm(wrong);
System.out.println("Correct guess!");
System.out.println(" These letters have already been guessed!");

System.out.println(userG);
System.out.println("Make another guess!");

}
}
}
//display hangman
public static void printhm(int wrong) {

//hangman display
if(wrong == 0) {
System.out.println(" ------");
System.out.println(" | |");
System.out.println(" |");
System.out.println(" |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 1){
System.out.println(" --------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println(" |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 2) {
System.out.println(" --------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println(" | |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 3) {
System.out.println(" --------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/| |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 4){
System.out.println(" ---------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/|\\ |");
System.out.println(" |");
System.out.println(" |");
}
else if (wrong == 5){
System.out.println(" ---------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/|\\ |");
System.out.println("/ |");
System.out.println(" |");
}
else {

System.out.println(" ---------");
System.out.println(" | |");
System.out.println(" 0 |");
System.out.println("/|\\ |");
System.out.println("/ \\ |");
System.out.println(" |");
System.out.println( "You lost! Better luck next time!!" );
}

}
// keep track of wrong guesses
public static String readwords() throws FileNotFoundException {
Scanner input = new Scanner(new File("hangman.txt"));
String[] word = new String[10];
String rword = "";

for(int i = 0; i < word.length; i++){
if (input.hasNext()) {

word[i] = input.next();

}else {
break;

}
}

Random rand = new Random();

int r = rand.nextInt(9);

rword = word[r];
return rword;
}

public static void userGuess(String y, String[] m, String[] words2){
for (int i=0; i < y.length(); i++){
m[i] = "-";
}
for (int x = 0; x < y.length(); x++){
if (x + 1 < y.length())
words2[x] = y.substring(x, x + 1);
else
words2[x] = y.substring(x, y.length());
}
}

public static boolean add(String[] m, String[] ma) { //find if letters are in the word
Scanner console = new Scanner(System.in);
String letters = console.next();
boolean found = false;

for(int i = 0; i < ma.length; i++) {
if(ma [i].equals(letters)){
m[i] = letters;
found = true;
}
}
if(found) {
return true;
}
else {
return false;
}
}

public static void userGuess(String[] m) {
for(int i = 0; i < m.length; i++) {
System.out.print(m[i] );
}

}

}

Sorry this is my first post. I hope I did it right this time.

-a--a---- --------
| |
0 |
|
|
|
Correct guess!
These letters have already been guessed!

That is some of the output

--- Update ---

import java.io.*; //for file
import java.util.*; //for scanner
 
public class Lab65 {
    static String userG = "";
    public static void main(String[] args)throws FileNotFoundException{
 
        int wrong = 0; // keeps track of user guesses
        String word = readwords();
        boolean temp = false;
 
        String[] words = new String[word.length()];
        String[] words2 = new String[word.length()];
 
        //methods to be used
        userGuess(word, words, words2);
        printhm(wrong);
 
        //introduce user to game
        System.out.println("Welcome to hangman!");
        System.out.println("Begin guessing letters!");
        System.out.println("These letters have already been guessed!");
        userGuess(words);
 
        //keep track of wrong user guesses  
 
        while(wrong <6) {   
            temp = add(words, words2);
            userGuess(words);
 
            if(temp == false) { 
                wrong++;
                printhm(wrong);
                System.out.println("Incorrect guess!" + (6 - wrong) + " more guesses left!");
                System.out.println();
                System.out.println(userG);
 
                System.out.println();
                System.out.println(" These letters have already been guessed!");
                System.out.println("Make another guess!");
 
            }else{    //user guess is correct
                printhm(wrong);
                System.out.println("Correct guess!");
                System.out.println(" These letters have already been guessed!");
 
                System.out.println(userG);
                System.out.println("Make another guess!");
 
            }
        }
    }
    //display hangman
    public static void printhm(int wrong) {
 
        //hangman display 
        if(wrong == 0) {
            System.out.println("  ------");
            System.out.println(" |      |");
            System.out.println("        |");
            System.out.println("        |");
            System.out.println("        |");
            System.out.println("        |");
        }
        else if (wrong == 1){
            System.out.println("  --------");
            System.out.println(" |        |");
            System.out.println(" 0        |");
            System.out.println("          |");
            System.out.println("          |");
            System.out.println("          |");
        }
        else if (wrong == 2) {
            System.out.println("  --------");
            System.out.println(" |        |");
            System.out.println(" 0        |");
            System.out.println(" |        |");
            System.out.println("          |");
            System.out.println("          |");
        }
        else if (wrong == 3) {
            System.out.println("  --------");
            System.out.println(" |        |");
            System.out.println(" 0        |");
            System.out.println("/|        |");
            System.out.println("          |");
            System.out.println("          |");
        }
        else if (wrong == 4){
            System.out.println("  ---------");
            System.out.println(" |         |");
            System.out.println(" 0         |");
            System.out.println("/|\\       |");
            System.out.println("           |");
            System.out.println("           |");
        }
        else if (wrong == 5){
            System.out.println("  ---------");
            System.out.println(" |         |");
            System.out.println(" 0         |");
            System.out.println("/|\\       |");
            System.out.println("/          |");
            System.out.println("           |");
        }
        else {
 
            System.out.println("  ---------");
            System.out.println(" |         |");
            System.out.println(" 0         |");
            System.out.println("/|\\       |");
            System.out.println("/ \\       |");
            System.out.println("           |");
            System.out.println( "You lost! Better luck next time!!" );
        }
 
    }
    // keep track of wrong guesses
    public static String readwords() throws FileNotFoundException {  
        Scanner input = new Scanner(new File("hangman.txt"));   
        String[] word = new String[10];  
        String rword = "";  
 
        for(int i = 0; i < word.length; i++){  
            if (input.hasNext())  {
 
                word[i] = input.next();    
 
            }else {
                break;  
 
            }
        }        
 
        Random rand = new Random();  
 
        int r = rand.nextInt(9);  
 
        rword = word[r];  
        return rword;  
    } 
 
    public static void userGuess(String y, String[] m, String[] words2){
        for (int i=0; i < y.length(); i++){
            m[i] = "-";
        }
        for (int x = 0; x < y.length(); x++){
            if (x + 1 < y.length())
                words2[x] = y.substring(x, x + 1);
            else
                words2[x] = y.substring(x, y.length());
        }
    }
 
    public static boolean add(String[] m, String[] ma) {  //find if letters are in the word
        Scanner console = new Scanner(System.in);
        String letters = console.next();
        boolean found = false;
 
        for(int i = 0; i < ma.length; i++) {
            if(ma [i].equals(letters)){
                m[i] = letters;
                found = true;
            }
        }
        if(found) {
            return true;
        }
        else {
            return false;
        }
    }
 
    public static void userGuess(String[] m) {
        for(int i = 0; i < m.length; i++) { 
            System.out.print(m[i] );
        }
 
    }
 
}

Sorry, I just figured it out.

Welcome to hangman!
Begin guessing letters!
These letters have already been guessed!
--------- [DrJava Input Box]
--------- --------
| |
0 |
|
|
|
Incorrect guess!5 more guesses left!



These letters have already been guessed!
Make another guess!
[DrJava Input Box]
-a--a---- --------
| |
0 |
|
|
|
Correct guess!
These letters have already been guessed!

Make another guess!

Some output

The output should look like --------
|
|
|
|
------ <-----these should keep track of the letters already guessed.
Also, it needs to stop the program when the user wins the game.
The problem with the current output is that it puts the guessed letters on the hang part of the hangman