Thread: ArrayList in Arralist

I am adding an arraylist "cList" in another arrayList "userList" but "userList" only show's last element i.e. Dell and 8GB. Also it's showing the size of the userList=3 but it should be 2.

Here is the chunk of my code:

if (uList.get(0).equalsIgnoreCase("Apple")
{
Computer cConfig = new Compute("Apple", "4GB");
cList.add(cConfig); // adding cConfig's elements in an arrayList "cList"
userList.addAll(cList); // adding an arrayList "cList" in arrayList "userList"


}

if (uList.get(0).equalsIgnoreCase("Dell")
{
Computer cConfig1 = new Compute("Dell", "8GB");
cList.add(cConfig1); // adding cConfig1's elements in an arrayList "cList"
userList.addAll(cList); // adding an arrayList "cList" in arrayList "userList"

}

System.out.println("UserList Size: " + userList.size()); // here it's showing the size of userList=3 but it should be 2


for (int i = 0; i < userList.size(); i++) {

System.out.println(userList.get(i).brand);
System.out.println(userList.get(i).memory);

}

Output:
UserList Size: 3

Dell
8GB

Dell
8GB

Dell
8GB

Please provide your code without conditional statements (if) and with the information about the initial state of all the variables (particularly contents of lists). It produces ambiguity. And use [code=Java] /* your code here */ [//code] (with one closing slash) to turn highlighting on.

We still have no idea, what uList is. And, hence, can't resolve conditionals in your code. Please, provide SSCCE, so that we can replicate the problem. And please, wrap the code into code tags I've mentioned previously.

thanks. I have edited the above post and removed the if condition. My only question is that why the 'userList' arrayList showing only the last object of cList. Also, showing the size of userList=3 instead of 2. the output should be

output:
userList size = 2

Apple
4GB

Dell
8GB

but its showing only Dell and 8GB

Looking at the code in post #3:

The casts (both of them) in the constructor are not necessary.
The declaration of cConfig1 appears to have a syntax error.

You first add an item to cList and call userList.addAll(cList);
userList now has one element.
You add a second item to cList and call userList.addAll(cList);
userList now has three elements. What makes you think it should have two?

What my program is about that from the menu user will choose the brand, for example "Apple". It will show all the Apple brand computer with technical detail. Then i will ask to narrow down the search, if user choose 4GB memory. It will show all the computer with Apple and 4GB memory.

In this above code, I am creating an arraylist cList that storing all the brand and memory of computer. In first search, when user choose Apple it will show all the apple computer and at the same time I am storing these result in "userList" arrayList. I will use this userList to narrow down search. But this userList only showing the last item. Why is that? Am I doing something wrong?

Originally Posted by techflyer

But this userList only showing the last item. Why is that? Am I doing something wrong?

It is hard to say without seeing code that can compile and show the problem. We can only guess if/when/how many times the methods are being called and what the value(s) of parameters are. Post a SSCCE or be (much) more descriptive about what leads up to the problem.
Print out the full length of the array lists and verify they hold what you think they hold, every step of the way if necessary.
Post the revised version of the code any time you make a change and still have a question. Include the full text of any error messages.