Thread: I cannot find the problem with this code.

// ************************************************** **************
// Rock.java
//
// Play Rock, Paper, Scissors with the user
// ************************************************** **************
import java.util.Scanner;
import java.util.Random;

public class Rock
{
public static void main(String[] args)
{
String personPlay; //User's play -- "R", "P", or "S"
String computerPlay = ""; //Computer's play -- "R", "P", or "S"
int computerInt; //Randomly generated number used to determine
//computer's play

Scanner scan = new Scanner(System.in);
Random generator = new Random();

//Generate computer's play (0,1,2)
computerInt = generator.nextInt(3);


//Translate computer's randomly generated play to string using if
//statements or a switch statement
switch (computerInt)
{
case 0: computerPlay = "R"; break;
case 1: computerPlay = "P"; break;
case 2: computerPlay = "S"; break;

}



//Get player's play from input-- note that this is stored as a string
System.out.println ("Choose: R(Rock), P(Paper), S(Scissor): ");
personPlay = scan.nextLine();


//Make player's play uppercase for ease of comparison
personPlay = personPlay.toUpperCase();


//Print computer's play
System.out.println ("Player1: " + personPlay);


//See who won. Use nested ifs
if (personPlay.equals(computerPlay))
{
System.out.println("It's a tie!");
}

else if (personPlay.equals("R"))
{
if (computerPlay.equals("S"))
{
System.out.println("Rock crushes scissors. You win!!");
}
else
{
System.out.println ("Paper covers rock. You Lose!");
}
}

else if (personPlay.equals("P"))
{
if (computerPlay.equals("R"))
{
System.out.println ("Paper cover rock. You Win!");
}
else
{
System.out.println ("Scissors cut paper. You Lose!");
}
}

// The error is with these statements below. They are executed even if the the conditions are not met.

else if (personPlay.equals("S"));
{
if (computerPlay.equals("R"))
{
System.out.println ("Rock crushes scissor. You Lose!");
}
else
{
System.out.println ("Scissors cut paper. You Win!");
}
}



} // end of method
}// end of class

Welcome LiveH

Please use code tags when posting code. See the Announcements page for help
What seems to be the trouble with the code?
What should it do? What does it do? Where do things seem to go unexpected (line number?)?

// The error is with these statements below. They are executed even if the the conditions are not met.

How do you know the conditions are not met? Print out the values of the interesting conditions before you start the if blocks. This will help with debugging.

I agree with jps - without code formatting it's too hard to follow the logic. (And programmers are unapologetic to the point of being proud of their laziness! Why try and figure out what depends on what when the indentation should make it obvious...?). Have a go at editing/reposting and ask if the instructions are incomprehensible.