Thread: HashSet store duplicated Value

Hello;

as known HashSet store no duplicated values Unlike ArrayList, anyway i tried to make example to store Objects in HashSet and the result show it take Duplicated values

import java.util.Comparator;
 
public class Employee{
 
    private int id;
    private String name;
    private String address;
    private double salary;
 
    public Employee(int id, String name, String address, double salary) {
        this.id = id;
        this.name = name;
        this.address = address;
        this.salary = salary;
    }
 
    public String getAddress() {
        return address;
    }
 
    public void setAddress(String address) {
        this.address = address;
    }
 
    public int getId() {
        return id;
    }
 
    public void setId(int id) {
        this.id = id;
    }
 
    public String getName() {
        return name;
    }
 
    public void setName(String name) {
        this.name = name;
    }
 
    public double getSalary() {
        return salary;
    }
 
    public void setSalary(double salary) {
        this.salary = salary;
    }
 
    public String toString(){
        return "ID:" + getId() + ", Name:" + getName() + ", Address:" + getAddress() + ", Salary:" + getSalary();
    }
            }

create Objects and add them to Set and List

import java.util.ArrayList;
import java.util.HashSet;
import java.util.Set;
 
 
public class Main {
 
    public static void main(String args[]) {
        Employee ts1 = new Employee (10, "Sam", "Paris", 200.0);
        Employee ts2 = new Employee (11, "Amal", "Berlin", 600.0);
        Employee ts3 = new Employee (12, "Nik", "London", 250.0);
        Employee ts4 = new Employee (10, "Sam", "Paris", 200.0);
        Employee ts5 = new Employee (14, "Jasmin", "Damas", 210.0);
 
        ArrayList<Employee> list = new ArrayList<Employee>();
 
        list.add(ts1);
        list.add(ts2);
        list.add(ts3);
        list.add(ts4);
        list.add(ts5);
 
        System.out.println("List");
        System.out.println("===================================================");
        for (int i = 0; i < list.size(); i++){
            System.out.println(list.get(i));
        }
 
        Set<Employee> set = new HashSet<Employee>();
 
        set.add(ts1);
        set.add(ts2);
        set.add(ts3);
        set.add(ts4);
        set.add(ts5);
 
        System.out.println("");
        System.out.println("Set");
        System.out.println("===================================================");
    for(Employee item: set){
         System.out.println(item);
    }
    }
}

Output:

List
===================================================
ID:10, Name:Sam, Address:Paris, Salary:200.0
ID:11, Name:Amal, Address:Berlin, Salary:600.0
ID:12, Name:Nik, Address:Lndon, Salary:250.0
ID:10, Name:Sam, Address:Paris, Salary:200.0
ID:14, Name:Jasmin, Address:Damas, Salary:210.0
 
Set
===================================================
ID:12, Name:Nik, Address:London, Salary:250.0
ID:10, Name:Sam, Address:Paris, Salary:200.0
ID:14, Name:Jasmin, Address:Damas, Salary:210.0
ID:10, Name:Sam, Address:Paris, Salary:200.0
ID:11, Name:Amal, Address:Berlin, Salary:600.0

The same result but not the same Order, anyway how to make Hashset in this code be able to not take any duplicated Value??

i added this part in Employee.java Class and it works

    @Override
   public boolean equals(Object obj){  
 
        if(!(obj instanceof Employee))  
            return false;  
 
        return (id == ((Employee) obj).getId());   
    }  
 
 
    @Override
    public int hashCode(){  
 
        return  id;    
    }

But i have another question, how to make it compre not just up on one element suche id or name but more elements, such id and name and adrees for exsample, sow how to modify the equal method to do that

You will have to write the body of the method to compare each field individually and return the overall results

i know that i must do so, but i don't know how

How did you compare one field?
Do the same thing on each field you want compared. Looks like the method already makes two comparisons, what is the problem in adding a third or fourth?
Give it a try and see what you come up with or explain exactly what you are stuck on

ok for example i want to make compare as the following: if the ID or name is Duplicate in any object dann must not be added

    @Override
   public boolean equals(Object obj1){  
 
        if(!(obj1 instanceof Employee))  
            return false;  
 
        return (id == ((Employee) obj1).getId() || name.equals(((Employee) obj1).getName()));   
    }  
 
 
    @Override
    public int hashCode(){  
 
        return  id ^ name.hashCode();    
    }

but some how it don't work correctly

That would depend on how you define "correctly"

|| (or) returns true if either this or that are true.
The desired result is probably to return true if this and that are both true

return (id == ((Employee) obj1).getId() || name.equals(((Employee) obj1).getName()));

means if, either id or name are duplicated in any object then don't add them in the HashSet

On this basis, I wrote it.

is that correct??

I think that the use of the .equals method, in terms of comparing two objects, should return true if and only if all considered fields match in value
It looks more like what you need here is to determine either the name or id are a match. Is this right?
If so I suggest not using the .equals method, as it is normally used as described above in this post.

Originally Posted by vector_ever

if, either id or name are duplicated in any object then don't add them in the HashSet

For clarity, "any object" here, realize this only checks the object receiving the message with the given object (obj1 in the sample), and not against a collection of objects (those in the hash set)

and how you suggest to use equal() method to give me the desired result, what should i add in my equal and Hashcode methods?

Hello.
Even though in your fist posted code some objects have same values but their hashcodes are different.
So for Set, these are distinct objects. If a same object is added several times then the set ignores duplicates.
So you will have to tell the JVM when are two objects same. Either one field is same or all fields are same or some fields are same.
Based on your requirement check for the equality of corresponding fields in the two objects.
And return true/false appropriately.
Also make sure you use AND and OR operators rightly.
If you are still confused then just put your requirements for two objects to be same.
Then we can help you write the condition.

Syed.

I put it

    @Override
   public boolean equals(Object obj1){  
 
        if(!(obj1 instanceof Employee))  
            return false;  
 
        return (id == ((Employee) obj1).getId() || name.equals(((Employee) obj1).getName()));   
    }  
 
 
    @Override
    public int hashCode(){  
 
        return  id ^ name.hashCode();    
    }

and again if, either id or name are duplicated in any object then don't add them in the HashSet

return (id == ((Employee) obj1).getId() || name.equals(((Employee) obj1).getName()));

it will be return true if there any id "or" name, so it must not add it in the HashSet, so where the error?????

@syedbhai
We strive to help people in solving their problems, without providing solutions, and we thank you to do the same.
Please read: The problem with spoonfeeding.

jps,
I have already read your post "The Problem with Spoonfeeding" earlier.
After that I am trying my best to avoid spoonfeeding.

If you see my recent posts I am hardly providing any code these days. I am indeed just giving hints to the people to solve their problems.

But for this guy I believed it is not spoonfeeding anymore.
Because i thought he really tried a lot. He even posted his code.
I did not provide any full solution from my side. I just helped him come up with correct if condition.
Sometimes a person may try his best but may not be able to come up with the exact logic.
Then how can we help him?

Syed.

Originally Posted by syedbhai

Sometimes a person may try his best but may not be able to come up with the exact logic.
Then how can we help him?
Syed.

Suggest search keywords
Provide links to tutorials and/or documentation
Explain functionality of incorrectly used keywords/symbols

Much help can be provided without resorting to providing functional code. Ultimately the goal is not to be sure they get the code working, it is to get them to understand why it doesn't work so that they can start working on a solution of their own, to develop problem solving skills, not just to learn the syntax of a given language

Now what the next, any advanced help??

Looking over the code, I do not see where the equals method was overridden, nor do I see where it is being called. (yes I saw the snippet, but I do not see the method in the code in the OP)
If you want to compare two fields of an object with the same two fields of a group of objects, you will have to do exactly that. Dumping them into a collection will not automatically sort out objects with a duplicated value in this or that field.
Iterate the collection and make the comparisons you wish to make.

I still always incapable to to improve it or understand your ideas

 return (id == ((Employee) obj1).getId() || name.equals(((Employee) obj1).getName()))

I thought it is enough since whatever if any operand return true, the method will return true, but i know it is not the correct method because it is not working correctly

Sorry but i can't bring any new i just tried and read tutorial and in Google

Looking at the code in the first post, which seems to be the only "complete" collection of code, I do not see a call to the equals method, nor do I see the method. Post the version of the code you are currently working with, I fear I may be causing more confusion for you at this point.
As a side note it looks like the method would return what you are expecting (among the two objects involved anyway), so I suspect there is a different issue