Thread: Please help me with my String variable and switch statement problem.

Here is an example of my code:

import java.util.Random;
 
public class cards {
public void Dimonds(){
	int Rnumber; 
	Random rng = new Random();
	String SN;
 
	Rnumber = rng.nextInt(51);
 
		switch(Rnumber){
		case 0:
		SN = "Ace of Dimonds";
		break;
 
		case 1:
		SN = "2 of Dimonds";
		break;
 
		case 2:
		SN = "3 of Dimonds";
		break;
 
		case 3:
		SN = "4 of Dimonds";
		break;
...

I know that the switch statement is right (I did finish it off at the bottom it was just to long full deck of cards worth.). My problem here is that the variable SN that I made is not storing. When I try to print it via a println it says "The local varriable SN may not have been initialised. If you need any more information please feel free to let my know.

just one question. Why don't you just put all these cards in, say, an arrayList and use the randomly generated number as the index?


The warning that it may not be initialized just means that it is null when you start working with it and could cause a NPE if done wrongly.
Also the reason it won't print is probably because you are declaring it locally, in stead try something like this:

public class cards {
 
public String SN; //or private with a getter if you want it to be safe :)
 
private ArrayList<String> cards;
 
public cards()
{
  cards = new ArrayList<String>();
 
  cards.add("Ace of Dimons");
  cards.add("2 of Dimonds");
  ... etc.
}
 
public void Dimonds()
{
   SN = ""; //to initialize it
 
  // do other stuff here
 
  SN = cards.get(randomNumber);
}

then whenever you call it, it should hold a value.

The problem I have with doing that is I don't know how to work with arrays as well as switch statements, but I will jump ahead in my totorials to check them out. I'm trying to learn java (at least) before I go to college. Either way Thanks. Oh and what do you mean by I am declaring locally?

The error is because not all possible code paths initialize SN. Giving SN a value when it is declared, (even null), will take care of that, but the most important thing is to be sure that SN does get a valid value through all possible code paths.
Without seeing the full body of the switch, it is hard to say for sure, but the compiler probably worries that no switch case will be met, and SN will never be initialized.
Post the full body of the method if you still need help with it

Thanks that did work!

--- Update ---

Thanks for the help. Is there a way for me to mark the thread as "solved" or "finished"?

You can mark the thread as solved from the Thread Tools just above the first post.
Thread marked as solved.