Thread: Problem with Multi-Dimensional Arrays

I can get the Tic Tac Toe game board to print, but not the other game boards.

I get ArrayIndexOutOfBoundsException: 6
which is the second array's row.

If I edit the Board(), I can get the other boards to print but the columns end up being the same number as the rows.

My question is where do the columns mirror the rows? And/Or What other method do I need to run to get the 3 boards to print?

package boardgametester;
import games.board.*;    
 
/**
 *
 * @author Gorgo
 */
 
public class BoardGameTester {
 
 
 
 
    public static void main(String[] args) {
 
         // 3x3 board for Tic Tac Toe
       Board tttgameboard = new Board (3,3);
 
        // 6x7 board for Connect Four
       Board cfgameboard = new Board (6,7);
 
       // 5x8 board for Mastermind; blue mark
       Board mmgameboard = new Board (5,8);    
 
 
        System.out.println (" Tic Tac Toe game board ");
        tttgameboard.setCell(Mark.NOUGHT,1,1);
        System.out.println(tttgameboard.toString());
 
        System.out.println(" Connect Four game board ");
        cfgameboard.setCell(Mark.YELLOW,0,0);
        System.out.println(cfgameboard.toString());
 
        System.out.println (" Mastermind game board ");
        mmgameboard.setCell(Mark.BLUE,0,0);
        System.out.println(mmgameboard.toString());
 
 
 
 
    }
}

Board Class

package games.board;
 
public class Board {
          private Cell[][] cells;
 
        public Board(int rows, int columns) {
            cells = new Cell[rows][columns];
            for (int r = 0; r < cells[0].length; r++) {              //I can get the other game boards to print if I take out: [0]
                for (int c = 0; c < cells[1].length; c++) {        // and [1]
                   cells [r][c] = new Cell (r,c);
 
                }
            }
         }
 
 
         public void setCell (Mark mark, int row, int column) throws
                IllegalArgumentException {
                    if (cells[row][column].getContent() == Mark.EMPTY)
                        cells[row][column].setContent(mark);
                    else throw new IllegalArgumentException ("Player already there!");
        }
        public Cell getCell(int row, int column) {
 
            return cells[row][column];
        }
 
 
        public String toString() {
            StringBuilder str = new StringBuilder();
 
            for (int r = 0; r < cells.length; r++) {
                str.append("|");
                for (int c = 0; c < cells.length; c++) {
                    switch (cells[r][c].getContent()) {
                        case NOUGHT:
                            str.append("O");
                            break;
                        case CROSS:
                            str.append("X");
                            break;
                        case YELLOW:
                            str.append("Y");
                            break;
                        case RED:
                            str.append("R");
                            break;
                        case BLUE:
                            str.append("B");
                            break;
                        case GREEN:
                            str.append("G");
                            break;
                        case MAGENTA:
                            str.append("M");
                            break;
                        case ORANGE:
                            str.append("N");
                            break;
                        default:            //Empty
                            str.append(" ");
                    }
                    str.append("|");
                }
                str.append("\n");
            }
            return str.toString();
        }
    }

And the Cell class

public class Cell {
    private Mark content;
    private int row, column;
 
    public Cell(int row, int column) {
        this.row = row;
        this.column = column;
    content = Mark.EMPTY;
    }
 
    public Mark getContent() { return content;}
 
    public void setContent (Mark content) { this.content = content; }
 
    public int getRow() { return row; }
 
    public int getColumn() { return column; }
}

Try:

      for (int r = 0; r < cells.length; r++) {              //I can get the other game boards to print if I take out: [0]
          for (int c = 0; c < cells[r].length; c++) {        // and [1]

If it works and you'd like me to explain it, let me know.

That was the first thing I tried and I get rows = columns. So the 6x7 Connect Four board comes out 6x6.

It was a guess, because the code you had there was suspect, but I can't do better because you haven't given us code that we can run (missing something called 'Mark' and maybe others), and you haven't explained your problem very well.

That was the first thing I tried . . .

That's not what your post said. You said you took out the [0] and the [1]. It's important that you take out the [0] and replace the [1] with an [r].

As the error message says, if you're creating a board of 6 rows by 7 columns, the max index for rows should be 5 and for columns 6. The code I suggested should work for all board dimensions.

If you want help with an error message, copy and paste the error message into your post EXACTLY as it appears at your end, and point to the line numbers it refers to in code you've posted. Don't interpret or excerpt it.

Ok, you are right, I need to be more specific:

Here is all of the code that you need to run the program:

1. the BoardGameTester class

import games.board.*;    
 
/**
 *
 * @author Gorgo
 */
 
public class BoardGameTester {
 
    public static void main(String[] args) {
 
         // 3x3 board for Tic Tac Toe
       Board tttgameboard = new Board (3,3);
 
        // 6x7 board for Connect Four
       Board cfgameboard = new Board (6,7);      // LINE 25: ERROR
 
       // 5x8 board for Mastermind; blue mark
       Board mmgameboard = new Board (5,8);    
 
 
        System.out.println (" Tic Tac Toe game board ");
        tttgameboard.setCell(Mark.NOUGHT,1,1);
        System.out.println(tttgameboard.toString());
 
        System.out.println(" Connect Four game board ");
        cfgameboard.setCell(Mark.YELLOW,0,0);
        System.out.println(cfgameboard.toString());
 
        System.out.println (" Mastermind game board ");
        mmgameboard.setCell(Mark.BLUE,0,0);
        System.out.println(mmgameboard.toString());
 
 
 
 
    }
}

2. the Board class

package games.board;
 
public class Board {
          private Cell[][] cells;
 
        public Board(int rows, int columns) {
            cells = new Cell[rows][columns];
            for (int r = 0; r < cells[0].length; r++) { 
                for (int c = 0; c < cells[1].length; c++) {  
                   cells [r][c] = new Cell (r,c);                               //LINE 10: ERROR
 
                }
            }
         }
 
 
         public void setCell (Mark mark, int row, int column) throws
                IllegalArgumentException {
                    if (cells[row][column].getContent() == Mark.EMPTY)
                        cells[row][column].setContent(mark);
                    else throw new IllegalArgumentException ("Player already there!");
        }
        public Cell getCell(int row, int column) {
 
            return cells[row][column];
        }
 
 
        public String toString() {
            StringBuilder str = new StringBuilder();
 
            for (int r = 0; r < cells.length; r++) {
                str.append("|");
                for (int c = 0; c < cells.length; c++) {
                    switch (cells[r][c].getContent()) {
                        case NOUGHT:
                            str.append("O");
                            break;
                        case CROSS:
                            str.append("X");
                            break;
                        case YELLOW:
                            str.append("Y");
                            break;
                        case RED:
                            str.append("R");
                            break;
                        case BLUE:
                            str.append("B");
                            break;
                        case GREEN:
                            str.append("G");
                            break;
                        case MAGENTA:
                            str.append("M");
                            break;
                        case ORANGE:
                            str.append("N");
                            break;
                        default:            //Empty
                            str.append(" ");
                    }
                    str.append("|");
                }
                str.append("\n");
            }
            return str.toString();
        }
    }

3. the Cell class

 
package games.board;
 
public class Cell {
    private Mark content;
    private int row, column;
 
    public Cell(int row, int column) {
        this.row = row;
        this.column = column;
    content = Mark.EMPTY;
    }
 
    public Mark getContent() { return content;}
 
    public void setContent (Mark content) { this.content = content; }
 
    public int getRow() { return row; }
 
    public int getColumn() { return column; }
}

4. the Mark class

package games.board;
 
//Result when game is completed
public enum Mark {EMPTY, NOUGHT, CROSS, YELLOW, RED, BLUE, GREEN, MAGENTA, ORANGE}

And here is the error code:
run:
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 6
at games.board.Board.<init>(Board.java:10)
at boardgametester.BoardGameTester.main(BoardGameTest er.java:25)
Java Result: 1
BUILD SUCCESSFUL (total time: 0 seconds)

So, I have tried fixing the Board() to not get an OutOfBounds error:

public class Board {
          private Cell[][] cells;
 
        public Board(int rows, int columns) {
            cells = new Cell[rows][columns];
            for (int r = 0; r < cells[0].length; r++) {       // taking out [0]; replacing [0] w/ [c]
                for (int c = 0; c < cells[1].length; c++) {  //taking out [1]; replacing [1] w/ [r]
                   cells [r][c] = new Cell (r,c);
 
                }
            }
         }

I have also tried this to see where the error was:

System.out.println("Rows" + rows);
System.out.println("Columns"+ columns);

In various places (before Board(), after Board(), before and after each line in Board()) and it prints out the correct numbers of array size (3x3, 6x7, 5x8), but the end game boards do not print with these sizes.

When I run these corrections, I don't get any errors, but my arrays are 3x3 (Tic Tac Toe), 6x6 (Connect Four) instead of 6x7 and 5x5 (Mastermind) instead of 5x8.

My question is: How do I get my arrays to print out the correct sizes? = 3x3, 6x7, and 5x8

Did you try the change I suggested? I've tried it, and it works fine IF you correct both the Board() constructor AND the toString() method.

Thank you! I wasn't changing it in the toString()!!