Thread: getting input from the user and give him some chances

Hi,

I try to write piece of code that get input from the user and in case of wrong input give the user anoter chance (total of 3 tries) to type input again.
what is the problem with it?

this is the piece of code:

while (tries < 5)
{
	try{
		System.out.println("Enter height: ");
		inp = Double.parseDouble(b.readLine());
  	        crr=1;
		if(crr>=1)
			break;
	}
	catch (Exception e){			
		System.out.println("wrong input, try again");
		continue;
        }
	finally {
		tries ++;
	}
}
if (tries  == 3)
	throw new Exception();
 
catch (Exception e)
     System.out.println("exiting program");

Originally Posted by felixb

what is the problem with it?

...What is wrong with it?
Does it compile? Does it run? Does it give incorrect output?

it run, but incorrect.
if i give 5 incorrect input - it run good, give 5 tries and exiting program after the 5 th attemp.
if i give 4 incorrect and the last is correct - it give 4 tries, i the 5 th try i enter correct input but it still exiting program...

The finally block will always run wether the try block passes or fails. What your program is doing is adding one to each tries variable.

So when its at 4 at the end of the loop it adds 1 more. If I am not mistaken your tries starts at 0 so this is whats happening:

tries = 0;
while (0 < 5) (1st Iteration)
... Execute code
... tries++; (1)
while (1 < 5) (2nd Iteration)
... Execute code
... tries++; (2)
...etc
while (4 < 5) (5th Iteration)
... Execute code with correct input
... tries++; (5)

By modifying your finally block you can see this happening

	finally {
		tries ++;
                          // Display tries
                          System.out.println(tries);
	}

You will have to find a way to only add to tries while input is incorrect since it seems somewhere else in your code it takes tries into account.

ok, i moved it to the catch section.
now it sees to be good.
thnk you