Thread: Basic Java Problem

Hello all,

Currently studying java in college for first time and cannot see where my error is in the following code, could some one with a lot more experience help me out?

import javax.swing.JOptionPane;
public class Week7Q1
{
public static void main(String [] agrs)
{
String word = JOptionPane.showInputDialog(null, "Please enter a word");
String vowels = "a,e,i,o,u";
String consonant = "b,c,d,f,g,h,j,k,l,m,n,p,q,r,s,t,v,w,x,y,z";
String aChar;
int length = word.length();
int i = 0;
int vc = 0;
int cc = 0;
String wordCopy = word;
word = word.toLowerCase();
for (i=0;i<length;i=i+1)
{
aChar = word.substring(i,i=i+1);
if (vowels.indexOf(aChar)!=-1)
vc++;
else
if(consonant.indexOf(aChar) !=-1)
cc++;
}
JOptionPane.showMessageDialog(null, "There are " + vc + " vowel(s) and " + cc + " consonant(s) in " + wordCopy);
}
}

Please read the Announcement topic at the top of the sub-forum to learn how to post code correctly and other useful items for new comers.

What error? Please describe what is happening or not happening that you need help with.

Thanks, I will go through the announcement topic now.

On this code, I am not getting the correct output for this program, for example, if I enter the word "Today", I get a response telling me there are 0 vowel(s) and 3 consonant(s) in Today. It looks like the program is not counting the vowels in the word entered.

--- Update ---

figured out myself where my error was, code below seems to be working for me. thanks

[highlight=Java]

import javax.swing.JOptionPane;
public class Week7Q1
{
public static void main(String [] agrs)
{
String word = JOptionPane.showInputDialog(null, "Please enter a word");
String vowels = "a,e,i,o,u";
String consonant = "b,c,d,f,g,h,j,k,l,m,n,p,q,r,s,t,v,w,x,y,z";
String aChar;
int length = word.length();
int i = 0;
int vc = 0;
int cc = 0;
String wordCopy = word;
word = word.toLowerCase();
for (i=0;i<length;i=i+1)
{
aChar = word.substring(i,i+1);
if (vowels.indexOf(aChar)!=-1)
vc++;
else
if(consonant.indexOf(aChar) !=-1)
cc++;
}
JOptionPane.showMessageDialog(null, "There are " + vc + " vowel(s) and " + cc + " consonant(s) in " + wordCopy);
}
}

[/highlight

Thanks for your help, realised my error shortly after I posted it.

ur welcome.