Thread: Movement Error

I know there may be a forum particularly for this below, but this is sort of urgent for me. I am creating a game in Eclipse and have came across a glitch which I cannot figure out how to solve at all, I am a beginner here so I've probably missed something that a more experienced user can find. I have implemented movement into my game, however it can only move sideways regardless of pressing W, S or turning around. I am positive that I've filled it out properly, I've looked on the tutorial for movement and I cannot find any error I've made with this. Here's the code:

'Game'

package base.dragonlord;
 
import java.awt.event.KeyEvent;
 
public class Game {
	public int time;
	public Controller controls;
 
	public Game() {
		controls = new Controller();
 
	}
 
	public void tick(boolean[] key) {
		time++;
		boolean forward = key[KeyEvent.VK_W];
		boolean back = key[KeyEvent.VK_S];
		boolean left = key[KeyEvent.VK_A];
		boolean right = key[KeyEvent.VK_D];
 
		controls.tick(forward, back, left, right);
	}
 
 
}

'Input Handler'

package base.dragonlord;
 
import java.awt.event.FocusEvent;
import java.awt.event.FocusListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.event.MouseMotionListener;
 
public class InputHandler implements KeyListener, FocusListener, MouseListener, MouseMotionListener {
 
	public boolean[] key = new boolean[68836];
	public static int MouseX;
	public static int MouseY;
 
	@Override
	public void keyPressed(KeyEvent e) {
		int keyCode = e.getKeyCode();
		if (keyCode > 0 && keyCode < key.length) {
			key[keyCode] = true;
		}
	}
 
	@Override
	public void keyReleased(KeyEvent e) {
		int keyCode = e.getKeyCode();
		if (keyCode > 0 && keyCode < key.length) {
			key[keyCode] = false;
		}
	}
 
	@Override
	public void keyTyped(KeyEvent e) {
	}
 
	@Override
	public void focusGained(FocusEvent e) {
	}
 
	@Override
	public void focusLost(FocusEvent e) {
		for (int i = 0; i < key.length; i++) {
			key[i] = false;
		}
	}
 
	@Override
	public void mouseClicked(MouseEvent e) {
	}
 
	@Override
	public void mouseEntered(MouseEvent e) {
	}
 
	@Override
	public void mouseExited(MouseEvent e) {
	}
 
	@Override
	public void mousePressed(MouseEvent e) {
	}
 
	@Override
	public void mouseReleased(MouseEvent e) {
	}
 
	@Override
	public void mouseDragged(MouseEvent e) {
	}
 
	@Override
	public void mouseMoved(MouseEvent e) {
		MouseX = e.getX();
		MouseY = e.getY();
	}
 
}

'Controller'

package base.dragonlord;
 
public class Controller {
 
	public double x, z, rotation, xa, za, rotationa;
	public static boolean turnLeft = false;
	public static boolean turnRight = false;
 
	public void tick(boolean forward, boolean back, boolean left, boolean right) {
		double rotationSpeed = 0.025;
		double walkSpeed = 1;
		double xMove = 0;
		double zMove = 0;
 
		if (forward) {
			zMove++;
		}
 
		if (back) {
			zMove--;
		}
 
		if (left) {
			xMove--;
		}
 
		if (right) {
			xMove++;
 
		}
 
		if (turnLeft) {
			rotationa -= rotationSpeed;
 
		}
 
		if (turnRight) {
			rotationa += rotationSpeed;
 
		}
 
		xa += (xMove * Math.cos (rotation) + zMove * Math.sin (rotation)) * walkSpeed;
		za += (zMove * Math.cos (rotation) - xMove * Math.sin (rotation)) * walkSpeed;		
 
		x += xa;
		x += za;
		xa *= 0.1;
		za *= 0.1;
		rotation += rotationa;
		rotationa *= 0.5;
 
	}
 
}

Please help me out here !

How are these parts wired together? Where is the class with the main() method that gets the ball rolling?

I wasn't sure if I had to post that, I am sure it's an error contained in the other pieces of code I pasted - I just can't find it. Here's the class that contains the main() method:

package base.dragonlord;
 
import java.awt.Canvas;
import java.awt.Cursor;
import java.awt.Dimension;
import java.awt.Graphics;
import java.awt.Point;
import java.awt.Toolkit;
import java.awt.image.BufferStrategy;
import java.awt.image.BufferedImage;
import java.awt.image.DataBufferInt;
 
import javax.swing.JFrame;
 
public class Display extends Canvas implements Runnable {
 
	public static final int WIDTH = 800;
	public static final int HEIGHT = 600;
	public static final String TITLE = "Dragonlord - Pre-Alpha - Version 0.02";
 
	private Thread thread;
	private Screen screen;
	private Game game;
	private BufferedImage img;
	private boolean running = false;
	private int[] pixels;
	private InputHandler input;
	private int oldX = 0;
	private int newX = 0;
	private int oldY = 0;
 
	public Display() {
		Dimension size = new Dimension(WIDTH, HEIGHT);
		setPreferredSize(size);
		setMinimumSize(size);
		setMaximumSize(size);
		screen = new Screen(WIDTH, HEIGHT);
		game = new Game();
		img = new BufferedImage (WIDTH, HEIGHT, BufferedImage.TYPE_INT_RGB);
		pixels = ((DataBufferInt)img.getRaster().getDataBuffer()).getData();
 
		input = new InputHandler();
		addKeyListener(input);
		addFocusListener(input);
		addMouseListener(input);
		addMouseMotionListener(input);
 
	}
 
	private void start() {
		if (running)
			return;
		running = true;
		thread = new Thread(this);
		thread.start();	
 
		System.out.print("Working!");
 
	}
 
	private void stop() {
		if (running)
			return;
		running = false;
		try {
		thread.join();
		} catch (Exception e) {
			e.printStackTrace();
			System.exit(0);
		}
	}
 
	public void run() {
		int frames = 0;
		double unprocessedSeconds = 0;
		long previousTime = System.nanoTime();
		double secondsPerTick = 1 / 60.0;
		int tickCount = 0;
		boolean ticked = false;
 
		while (running) {
			long currentTime = System.nanoTime();
			long passedTime = currentTime - previousTime;
			previousTime = currentTime;
			unprocessedSeconds += passedTime / 1000000000.0;
 
			while (unprocessedSeconds > secondsPerTick) {
				tick();
				unprocessedSeconds -= secondsPerTick;
				ticked = true;
				tickCount++;
				if (tickCount % 60 == 0) {
					System.out.println(frames + "FPS");
					previousTime += 1000;
					frames = 0;
				}
			}
			if (ticked) {
				render();
				frames++;
			}
			render();
			frames++;
 
			newX = InputHandler.MouseX;
			if (newX > oldX) {
				System.out.println ("Right");
				Controller.turnRight = true;
			}
 
			newX = InputHandler.MouseX;
			if (newX < oldX) {
				System.out.println ("Left");
				Controller.turnLeft = true;
			}
			if (newX == oldX) {
				Controller.turnLeft = false;
				Controller.turnRight = false;
			}
			oldX = newX;
		}
	}
 
	private void tick() {
		game.tick(input.key);
 
	}
 
	private void render() {
		BufferStrategy bs = this.getBufferStrategy();
		if (bs == null) {
			createBufferStrategy(3);
			return;
		}
 
		screen.render(game);
 
		for (int i = 0; i <WIDTH * HEIGHT; i++) {
			pixels[i] = screen.pixels[i];
		}
 
		Graphics g = bs.getDrawGraphics();
		g.drawImage(img, 0, 0, WIDTH + 10, HEIGHT + 10, null);
		g.dispose();
		bs.show();
	}
 
	public static void main(String[] args) {
		BufferedImage cursor = new BufferedImage (16, 16, BufferedImage.TYPE_INT_ARGB);
		Cursor blank = Toolkit.getDefaultToolkit().createCustomCursor(cursor, new Point(0,0), "blank");
		Display game = new Display();
		JFrame frame = new JFrame();
		frame.add(game);
		frame.pack();
		frame.getContentPane().setCursor(blank);
		frame.setTitle(TITLE);
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		//frame.setSize(WIDTH, HEIGHT);
		frame.setLocationRelativeTo(null);
		frame.setResizable(false);
		frame.setVisible(true);
 
		System.out.println("Running...");
 
		game.start();
	}
 
}

Let's trade places . . .

If someone handed you this mass of code and said "Things don't move when they're supposed to. Help me fix it." What would you say? At a minimum, you'd probably say, "Show me."

Seriously. There isn't one comment, not one clue what this program does, how it's supposed to do what it does (except that it doesn't do it), how the classes are related, how they work together, nothing. AND, it's not even runnable to give us the "show me" experience and a chance at figuring those things out, because we don't have all of the code. We're not psychic.

We like to help others, solve puzzles, give new programmers insight from our many years of combined experience, but we're not miracle workers. Give us the info we need to help you.

Originally Posted by GregBrannon

Let's trade places . . .

If someone handed you this mass of code and said "Things don't move when they're supposed to. Help me fix it." What would you say? At a minimum, you'd probably say, "Show me."

Seriously. There isn't one comment, not one clue what this program does, how it's supposed to do what it does (except that it doesn't do it), how the classes are related, how they work together, nothing. AND, it's not even runnable to give us the "show me" experience and a chance at figuring those things out, because we don't have all of the code. We're not psychic.

We like to help others, solve puzzles, give new programmers insight from our many years of combined experience, but we're not miracle workers. Give us the info we need to help you.

I figured pasting the code for the parts that execute movement were enough. Should I give you the whole thing?

Ok, here it is.

Which code do you want me to post? I posted the full code for the classes that involve movement, what more?

The problem with your suggestion is that when I attempt to move forward it will say it's moving forward when it's not, it will be moving sideways only.

I've given you the whole program as one of you asked and that still wasn't enough for any of you, println()'s isn't efficient enough for me.

Is there a way to delete this thread?

Thought you'd given up. I haven't figured out why, but if you add a print statement to the Game.tick() method, something like:

public void tick(boolean[] key)
{
    time++;
    boolean forward = key[KeyEvent.VK_W];
    boolean back = key[KeyEvent.VK_S];
    boolean left = key[KeyEvent.VK_A];
    boolean right = key[KeyEvent.VK_D];
 
    System.out.println( "forward = " + forward + "\nback = " + back );
    System.out.println( "left = " + left + "\nright = " + right );
 
    controls.tick(forward, back, left, right);
}

the forward and back movement will occur with key presses. Again, not sure why, but the miles of uncommented code is unpleasant to unravel.