Thread: What's wrong?!

Why doesn't my printLinked() work after the invert() ??
And why doesn't my printLinked "System.out.println();" work? It doesn't give me a blank line...

And extra credits to anyone who can give me a hint on what I need to make my delrep() deleate all duplicates not only the first one I refer to, a loop to do ref = ref.link and continue until ref.link = null.

import java.util.Scanner;
 
public class LinkedList
{
	public static void main(String []args)
	{
		Scanner keyboard = new Scanner(System.in);
		ListNode head = new ListNode();
		head.link = null;
		ListNode tail = head;
		System.out.print("Enter integers, seperated with blanks, to put into a linked list (type zero (0) to end): ");
		int in;
		in = keyboard.nextInt();
		while (in != 0)
		{
			ListNode x = new ListNode(); 
			x.link = null;
			x.data = in;
			tail.link = x;
			tail = x;
			in = keyboard.nextInt();
		}
		printLinked(head.link);
		delrep(head.link);
		printLinked(head.link);
		invert(head);
		printLinked(head.link);	
	}
	/** The printLinked() method prints out, in order, the integers stored in the linked list.
	 */
	public static void printLinked(ListNode head)
	{
		while (head != null)
		{
			System.out.print(head.data + " ");
			head = head.link;
		}
		System.out.println();
	}
	public static void delrep(ListNode head)
	{
		ListNode seek = head.link;
		ListNode ref = head;
		ListNode c = ref;
		while (seek != null)
		{
			if (seek.data == ref.data)
			{
				seek = seek.link;
				c.link = c.link.link;
			}
			else
			{
				seek = seek.link;
				c = c.link;
			}		
		}
	}
	public static void invert (ListNode head)
	{
		ListNode lead = head.link.link;
		ListNode trail = head.link;
		ListNode secondtrail = head;
		head.link = null;
		trail.link = null;
		while (lead.link != null)
		{
			secondtrail = trail;
			trail = lead;
			lead = lead.link;
			trail.link = secondtrail;
		}
		head.link = lead;
 
	}
 
}

I'm guessing you have a singly linked list? You need to make sure that you are modifying your links in the correct order, or else all references to parts or even all of the list can be lost.

A simple O(n^2) algorithm for deleting all duplicates:

1. Take the first value of you list and call that your "holding" value.
2. Iterate through the entire list. If any of the other values match your holding value, remove it.
3. Take the item after holding as your new holding value. Repeat step 2 until you reach the end of the list.

Well, you just need some way to distinguish the end of the list. This can either be that the link of the last node returns null, or you can put a special end-of-list node to the end of your list. Iterating through a linked list is as simple as creating a node to point to the head, then simply update that node to be node.link

// iterate through the list, printing out the data
ListNode iterator = head;
while (head.link != null)
{
     System.out.println(iterator.data);
     iterator = iterator.link;
}

If you haven't done so already, implement a equals() method to whatever data it is you're putting into your nodes. Then modify the above code to have an if statement that will check if iterator's data is equal to a held node's data.

Once you have this figured out, changing the held node is as simple as duplicating the above loop code, except move the held node's reference rather than the iterator's, and put everything for the iterator inside of this new bigger loop.