Thread: Size of stroke is updating for all shapes in array.Why?

Hello everyone,
i have a problem with the code below.Basically what we have is a simple program for drawing shapes (line,rectangle,ellipse) and the issue i have is that the stroke size is updating dynamically for all the shapes that are drawn (added to the Shapes array) and not only for the current shape being drawn.

If you draw a line for example with stroke size 2 and then draw another line with say stroke size 6 both lines will update to stroke size 6 instead of just the second line.This is valid for all the other shapes as well.

The following line: graphSettings.setStroke(new BasicStroke(strokeparentVal));

sets the stroke size from the strokeparentVal which can be dynamically changed with the slider.

So,i want to change the stroke size only for the shape currently being drawn.Will appreciate any help!

import javax.swing.*;
import javax.swing.event.ChangeEvent;
import javax.swing.event.ChangeListener;
 
import java.awt.event.*;
import java.awt.*;
import java.awt.geom.*;
import java.text.DecimalFormat;
import java.text.NumberFormat;
import java.util.*;
 
public class PaintExample extends JFrame
{
 
		JButton brushBut, lineBut, ellipseBut, rectBut, strokeBut, fillBut;
 
		Graphics2D graphSettings;
 
		int currentAction = 1;
 
		Color strokeColor=Color.BLACK, fillColor=Color.BLACK;
 
		JSlider strokeSlider;
 
		JLabel strokeLabel;
 
		public float strokeparentVal =1;
 
        public static void main(String [] args)
        {
                new PaintExample();
        }
 
        public PaintExample()
        {
 
            this.setSize(800, 600);
            this.setTitle("Java Paint");
            this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
 
            JPanel buttonPanel = new JPanel(); 
 
            Box theBox = Box.createHorizontalBox();
 
            brushBut = makeMeButtons("./src/brush.png", 1);
            lineBut = makeMeButtons("./src/Line.png", 2);
            ellipseBut = makeMeButtons("./src/Ellipse.png", 3);
            rectBut = makeMeButtons("./src/Rectangle.png", 4);  
 
            strokeBut = makeMeColorButton("./src/Stroke.png", 5, true);
            fillBut = makeMeColorButton("./src/Fill.png", 6, false);
 
            theBox.add(brushBut);
            theBox.add(lineBut);
            theBox.add(ellipseBut);
            theBox.add(rectBut);
            theBox.add(strokeBut);
            theBox.add(fillBut); 
 
            strokeLabel = new JLabel("Stroke: 1");
 
            strokeSlider = new JSlider(1,25,1);
 
            ListenForSlider sForSlider = new ListenForSlider();
 
            theBox.add(strokeLabel);
            theBox.add(strokeSlider);
 
            strokeSlider.addChangeListener(sForSlider);
 
            buttonPanel.add(theBox);
 
            this.add(buttonPanel, BorderLayout.SOUTH);
 
            this.add(new DrawingBoard(), BorderLayout.CENTER);
 
            this.setVisible(true);
        } 
 
        public JButton makeMeButtons(String iconFile, final int actionNum){
        	JButton theBut = new JButton();
            Icon butIcon = new ImageIcon(iconFile);
            theBut.setIcon(butIcon);
 
            theBut.addActionListener(new ActionListener() {
 
				public void actionPerformed(ActionEvent e) {
					currentAction = actionNum;
 
				}
            });
 
            return theBut;  
        }
 
        public JButton makeMeColorButton(String iconFile, final int actionNum, final boolean stroke){
        	JButton theBut = new JButton();
            Icon butIcon = new ImageIcon(iconFile);
            theBut.setIcon(butIcon);
 
            theBut.addActionListener(new ActionListener() {
 
				public void actionPerformed(ActionEvent e) {
 
					if(stroke){
 
						strokeColor = JColorChooser.showDialog(null,  "Pick a Stroke", Color.BLACK);
					} else {
						fillColor = JColorChooser.showDialog(null,  "Pick a Fill", Color.BLACK);
					}
 
				}
            });
 
            return theBut;  
        }
 
        private class DrawingBoard extends JComponent
        {
 
                ArrayList<Shape> shapes = new ArrayList<Shape>();
                ArrayList<Color> shapeFill = new ArrayList<Color>();
                ArrayList<Color> shapeStroke = new ArrayList<Color>();
                Point drawStart, drawEnd;
 
                public DrawingBoard()
                {
 
                        this.addMouseListener(new MouseAdapter()
                          {
 
                            public void mousePressed(MouseEvent e)
                            {
 
                            	if(currentAction != 1){
 
                            	drawStart = new Point(e.getX(), e.getY());
                            	drawEnd = drawStart;
                                repaint();
 
                            	}
 
 
                                }
 
                            public void mouseReleased(MouseEvent e)
                                {
 
                            	if(currentAction != 1){
 
                            	Shape aShape = null;
 
                            	if (currentAction == 2){
                            		aShape = drawLine(drawStart.x, drawStart.y,
                            				e.getX(), e.getY());
                            	} else 
 
                            	if (currentAction == 3){
                            		aShape = drawEllipse(drawStart.x, drawStart.y,
                            				e.getX(), e.getY());
                            	} else 
 
                            	if (currentAction == 4) {
 
                                    aShape = drawRectangle(drawStart.x, drawStart.y,
                                    		e.getX(), e.getY());
                            	}
 
 
                                  shapes.add(aShape);
                                  shapeFill.add(fillColor);
                                  shapeStroke.add(strokeColor);
 
                                  drawStart = null;
                                  drawEnd = null;
 
                                  repaint();
 
                            	}
                                }
                          } );
 
                        this.addMouseMotionListener(new MouseMotionAdapter()
                        {
 
                          public void mouseDragged(MouseEvent e)
                          {
 
                        	  if(currentAction == 1){
 
                      			int x = e.getX();
                      			int y = e.getY();
 
                      			Shape aShape = null;
 
                      			strokeColor = fillColor;
 
                      			aShape = drawBrush(x,y,5,5);
 
                      			  shapes.add(aShape);
                                  shapeFill.add(fillColor);
                                  shapeStroke.add(strokeColor);
 
                      		} 
 
                        	drawEnd = new Point(e.getX(), e.getY());
                            repaint();
                          }
                        } );
                }
 
 
                public void paint(Graphics g)
                {
 
                        graphSettings = (Graphics2D)g;
 
                        graphSettings.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
                                RenderingHints.VALUE_ANTIALIAS_ON);
 
                        Iterator<Color> strokeCounter = shapeStroke.iterator();
                        Iterator<Color> fillCounter = shapeFill.iterator();
 
                        for (Shape s : shapes)
                        {
 
                        	graphSettings.setPaint(strokeCounter.next());
                        	graphSettings.setStroke(new BasicStroke(strokeparentVal));
                        	graphSettings.draw(s);
 
                        	graphSettings.setPaint(fillCounter.next());
 
                        	graphSettings.fill(s);
                        }
 
                        if (drawStart != null && drawEnd != null)
                        {
 
                            graphSettings.setComposite(AlphaComposite.getInstance(
                                    AlphaComposite.SRC_OVER, 0.40f));
 
                        	graphSettings.setPaint(Color.LIGHT_GRAY);
 
                        	Shape aShape = null;
 
                        	if (currentAction == 2){
                        		aShape = drawLine(drawStart.x, drawStart.y,
                                		drawEnd.x, drawEnd.y);
                        	} else 
 
                        	if (currentAction == 3){
                        		aShape = drawEllipse(drawStart.x, drawStart.y,
                                		drawEnd.x, drawEnd.y);
                        	} else 
 
                        	if (currentAction == 4) {
 
                                aShape = drawRectangle(drawStart.x, drawStart.y,
                                		drawEnd.x, drawEnd.y);
                        	}
 
 
                                graphSettings.draw(aShape);
                        }
                }
 
                private Rectangle2D.Float drawRectangle(
                        int x1, int y1, int x2, int y2)
                {
 
                        int x = Math.min(x1, x2);
                        int y = Math.min(y1, y2);
 
 
                        int width = Math.abs(x1 - x2);
                        int height = Math.abs(y1 - y2);
 
                        return new Rectangle2D.Float(
                                x, y, width, height);
                }
 
 
                private Ellipse2D.Float drawEllipse(
                        int x1, int y1, int x2, int y2)
                {
                        int x = Math.min(x1, x2);
                        int y = Math.min(y1, y2);
                        int width = Math.abs(x1 - x2);
                        int height = Math.abs(y1 - y2);
 
                        return new Ellipse2D.Float(
                                x, y, width, height);
                }
 
                private Line2D.Float drawLine(
                        int x1, int y1, int x2, int y2)
                {
 
                        return new Line2D.Float(
                                x1, y1, x2, y2);
                }
 
                private Ellipse2D.Float drawBrush(
                        int x1, int y1, int brushStrokeWidth, int brushStrokeHeight)
                {
 
                	return new Ellipse2D.Float(
                            x1, y1, brushStrokeWidth, brushStrokeHeight);
 
                }
 
        }
 
 
private class ListenForSlider implements ChangeListener{
 
 
        	public void stateChanged(ChangeEvent e) {
 
        		if(e.getSource() == strokeSlider){
 
 
        			strokeLabel.setText("Stroke: " + strokeSlider.getValue() );
 
 
        			strokeparentVal = (float) (strokeSlider.getValue());
 
        		}
 
        	}
 
        }
}

So,
for a better design i will have to create one main class that contains all the properties of the shapes such as inner color (shapefill),border color (strokefill) and stroke size and make all the other classes (shapes) inherit those properties from that base class.

"Returning to the problem you have explained, it's easy: the "stroke" property of Graphics2D is set from strokeparentVal which is not a property of each figure but is a variable directly controller by the slider."

Yeah,exactly.The problem is that every time there is call with new BasicStroke,so is there a way this to be fixed in the code the way it is right now ?

Thanks!