Thread: Problem with String Array for Deck of Cards

I am new to Java and trying to write a BlackJack game. The first time I create the deck of cards everything works fine. When a start a second hand and recreate the deck that's when I am having problems. I print the cards when I create the deck in the class array cards (a [52][2] array) and get the correct results but when I reprint the contents of the deck again right after the array is populated I get a number of King of Hearts represented by "h13". The number of h13's in the deck depends on how many cards were dealt the hand before. How can the two prints of the same array be different when one is printed right after the other? I am printing the array index with each card.

public static void createDeck(){
 
		int s, n, i, j, cardIndex=0;
		String temp[][]= new String[1][2]; 	// Array used as temp storage 
		Random rCard= new Random();			// Use to shuffle the deck
 
		for (s=0; s<4; s++){			//Create the suits
			for(n=1; n<=13; n++){		//Create each card value
			    switch(s)
			    {
			    case 0:
			    	cards[cardIndex][0]=("s");
			    	cards[cardIndex][1]=(Integer.toString(n));
			      	break;
			    case 1:
			    	cards[cardIndex][0]=("c");
			    	cards[cardIndex][1]=(Integer.toString(n));
			      	break;
			    case 2:
			    	cards[cardIndex][0]=("d");
			    	cards[cardIndex][1]=(Integer.toString(n));	
			      	break;
			    case 3:                 // Hearts Section
		       	              cards[cardIndex][0]=("h");
			    	cards[cardIndex][1]=(Integer.toString(n));
			    	System.out.println(cardIndex + " " + cards[cardIndex][0] +cards[cardIndex][1]);
			    	break;
			    }
			   cardIndex++;
			 }
		}
 
		for(i=0; i<52; i++)
			System.out.println(i+ " " +cards[i][0]+cards[i][1]);
 
		// Shuffle Cards.
 
		for(i=0; i<52; i++){
			j=rCard.nextInt(52);
			temp[0]=cards[i];
			cards[i]=cards[j];
			cards[j]=temp[0];
		}
 
	}
 
	public static String[][] dealCard(){
 
		int i;
		String tcard[][] = new String [1][2];
		tcard[0] = cards[0];		 		// get the top card
		for(i=0; i<numCards-1; i++){	  	// Shift cards to the left by 1
			cards[i]=cards[i+1];
		}
		numCards=numCards-1;				// Reduce the number of cards by 1
		return tcard;
	}

Output of the hearts section of the case statement
39 h1
40 h2
41 h3
42 h4
43 h5
44 h6
45 h7
46 h8
47 h9
48 h10
49 h11
50 h12
51 h13
Output after Switch Statement - Prints full array
0 s1
1 s2
2 s3
3 s4
4 s5
5 s6
6 s7
7 s8
8 s9
9 s10
10 s11
11 s12
12 s13
13 c1
14 c2
15 c3
16 c4
17 c5
18 c6
19 c7
20 c8
21 c9
22 c10
23 c11
24 c12
25 c13
26 d1
27 d2
28 d3
29 d4
30 d5
31 d6
32 d7
33 d8
34 d9
35 d10
36 d11
37 d12
38 d13
39 h1
40 h2
41 h3
42 h4
43 h5
44 h6
45 h7
46 h13 Problem Area from here down
47 h13
48 h13
49 h13
50 h13
51 h13

You've shown an interesting approach to managing 52 different cards that will have numerous chances for errors and constant confusion. I can't imagine how this approach will adjust when the cards are shuffled or dealt. I recommend you either develop a Card class (preferred) or if you must stick with parallel arrays, then store the cards as complete string objects rather than matching the suits to ranks on the fly.

Thanks for the tip Norm.

--- Update ---

Norm, I get the same output as you show the first time I run the game. When a start the second hand and call createDeck() for the second time and from then on in a get the output that I have posted. I can't understand how the array contents can be correct when output in case 3 of the switch and different when printed in the for loop that executes right after that.

Quoting myself:

You've shown an interesting approach to managing 52 different cards that will have numerous chances for errors and constant confusion. I can't imagine how this approach will adjust when the cards are shuffled or dealt.