Thread: Creating a new variable from two others

Hello, very new... I've just been playing around with a program that's meant to ask the user for their name and age...

Here's the code :

import java.util.Scanner;
 
public class Noerng {
 
	public static void main(String[] args) {
 
		Scanner name1 = new Scanner(System.in);
 
		System.out.println("Enter your first name :");
 
		String firstName = name1.nextLine();
 
		Scanner name2 = new Scanner(System.in);
 
		System.out.println("Enter your second name :");
 
		String secondName = name2.nextLine();
 
		System.out.println("hello there " + firstName + " " + secondName);
 
		String fullName = firstName + " " + secondName;
 
		Scanner age = new Scanner(System.in);
 
		System.out.println("How old are you?");
 
		int userAge = age.nextInt();
 
		System.out.println("You're " + fullName + ", and you are " + userAge
				+ " years old.");
 
		if (userAge < 21) {
			System.out
					.println("I don't think you're old enough to drink in America");
		}
 
		else {
			System.out.println("I think you're old enough to drink in America");
		}
 
		name1.close();
		name2.close();
		age.close();
 
	}
 
}

Would be great to have feedback to anything that's a bit off / not the done thing...

Is there a way to close all of the scanners at once?

cheers

--- Update ---

not sure why eclipse is formatting line 33 to a different one...

Is there a way to close all of the scanners at once?

You only need one.

Ah right - so all the lines that I've written that create new scanners are wrong... And I should just write

Scanner age = (System.in)

?

Hmmm, not exactly. Create one Scanner instance with a name that makes sense to you. Something like:

Scanner input = new Scanner( System.in );

But looking at the code in my first post - I've created a new scanner for each one, name1, name2, age.....

Is there a better way that I should have done this?

cheers

I thought we covered that already. You only need ONE that you can then use for each item input by the user:

Scanner input = new Scanner( System.in );
String name = input.nextLine();
int age = input.nextInt();
input.nextLine(); // why did I do this? Try it with/without and see why.
String address = input.nextLine();

etc.

Ah makes sense and I instantly feel a bit silly, cheers greg.

No worries, glad to help.

hii...
Instead of using multiple scanners use only one scanner to read all the input values of different formats...
for example..
//create Scanner
Scanner s = new Scanner(System.in);
//so you can close the scanner once by usnig close() method in Scanner class
Scanner.close();

Originally Posted by KotiChowdary

hii...
Instead of using multiple scanners use only one scanner to read all the input values of different formats...
for example..
//create Scanner
Scanner s = new Scanner(System.in);
//so you can close the scanner once by usnig close() method in Scanner class
Scanner.close();

Cheers Koti - would it not be

s.close();

in that instance?