Thread: What is best loop sequence?

What is the most efficient code?


Writen like this:

 if(vehicle.Branch.UWCompanyCode==typekey.UWCompanyCode.TC_CGIC){
 
    if( vehicle.CollisionAPRateGroup_CG==-1  and (vehicle.CostNew_CG==null or vehicle.CurrentValue_CG==null)){
 
      throwError(displaykey.Web.PolicyLine.Vehicle.NoVRGMessage)
    }
  }
 
  if(vehicle.Branch.UWCompanyCode==typekey.UWCompanyCode.TC_FA){
    if( vehicle.CollisionAPRateGroup_CG==-1  and vehicle.CurrentValue_CG==null){
 
      throwError(displaykey.Web.PolicyLine.Vehicle.NoVRGMessageFA)
    }
  }

or like this one?

if( vehicle.CollisionAPRateGroup_CG==-1){  
    if(vehicle.Branch.UWCompanyCode==typekey.UWCompanyCode.TC_CGIC and ( vehicle.CostNew_CG==null or vehicle.CurrentValue_CG==null)){ 
        throwError(displaykey.Web.PolicyLine.Vehicle.NoVRGMessage)
     }
    if(vehicle.Branch.UWCompanyCode==typekey.UWCompanyCode.TC_FA  and vehicle.CurrentValue_CG==null){  
          throwError(displaykey.Web.PolicyLine.Vehicle.NoVRGMessageFA)
    }
  }

I think that is the same thing

It doesn't matter which is more efficient. For something as simple as conditional logic you would need to be executing it thousands of times per seconds *and* have the performance issues *and* perform extensive profiling *and* identify this logic as problematic to throughput before you even consider optimization.

A more practical concern is correctness, readability and maintainability so the 'better' code is the one which is easier to understand so personally I think neither example hit's the mark. At a glance I can't easily tell which conditions which throw an exception and it even appears to have syntax errors.

I'll try to simplify:

 
if(vehicle.Company==G){
 
    if( vehicle.Collisions==-1  and (vehicle.Cost==null or vehicle.CurrentValue==null)){
 
      throwError(GMessage)
    }
  }
 
  if(vehicle.Company==F){
    if( vehicle.Collisions==-1  and vehicle.CurrentValue==null){
 
      throwError(FMessage)
    }
  }

or

 
if( vehicle.Collisions==-1){  
    if(vehicle.Company==G and ( vehicle.Cost==null or vehicle.CurrentValue==null)){ 
        throwError(GMessage)
     }
    if(vehicle.Company==F  and vehicle.CurrentValue==null){  
          throwError(FMessage)
    }
  }

In the first one I have two if related to the vehicle company then nested in each I verify at the same time the 2 conditions to send an error: collissions -1 and if there are specific null fields.

In the second one
I verify in only one if first if collisions is -1 if yes I verify the conditions for the 2 companies G and F

--- Update ---

For each vehicle company we have diferent conditions to throw error and each company have their own error message:
For G there are 2 fields that can not be null
For F there are only one of them

But for both collisions must be -1 to throw error

Thanks, I coded the first one and I was asked to change to the second by lead programmer (according to him that shoul simplify my code?!) I coded like that because as you said vehicle.Company is almost always G but vehicle.Collisions is almost never -1. And I wanted to be sure I was right thinking in the environment.