Thread: CounterTester.java Not Decreasing in the counter????

I believe I have this program CounterTester.java down but in my output the program is increasing the way I want it to but it is not decreasing the way I want it to.



Would someone point me in the right direction?

Thank you in advance.

public class CounterTester
{
	static int myCount;
	static int myCount2;
 
public CounterTester(int inti) {
    myCount = 1;
    myCount2 = 10;
}
 
public static void main(String[] args)
{
 
    CounterTester counter = new CounterTester(myCount);  //create a new counter with a step value of 1
 
    counter.increase(myCount); //add 1
    System.out.println("Expected Count: 1 -----> Actual Count: " + counter.getValue());
 
    counter.increase(myCount++); //add 1
    System.out.println("Expected Count: 2 -----> Actual Count: " + counter.getValue());
 
    counter.decrease(myCount--); //subtract 1
    System.out.println("Expected Count: 1 -----> Actual Count: " + counter.getValue());
 
    CounterTester counter1 = new CounterTester(myCount2); //create a new counter with a step value of 10
    System.out.println("Expected Count: 0 -----> Actual Count: " + counter1.getValue());
 
    counter1.increase(myCount2(10)); //add 10
    System.out.println("Expected Count: 10 ----> Actual Count: " + counter1.getValue());
 
    counter1.decrease(myCount2(myCount2)); //subtract 10
    System.out.println("Expected Count: 0 -----> Actual Count: " + counter1.getValue());
 
    counter1.decrease(myCount2(myCount2)); //subtract 10
    System.out.println("Expected Count: -10 -----> Actual Count: " + counter1.getValue());
 
}
 
private static int myCount2(int i) {
	return 0;
}
 
private void decrease(int i) {
 
}
 
public int getValue() {
	return myCount;
}
 
private void decrease() {
    myCount--;
}
 
private void increase(int i) {
    myCount++;
 
}
 
public String toString() {
	return ""+myCount;
}
 
public void reset() {
 
}
 
}

Ok. so I just added

int i

inside the (). I actually looking at it not I already had it once as a method. My output after making the change looks like this:

Expected Count: 1 -----> Actual Count: 2
Expected Count: 2 -----> Actual Count: 4
Expected Count: 1 -----> Actual Count: 2
Expected Count: 0 -----> Actual Count: 1
Expected Count: 10 ----> Actual Count: 2
Expected Count: 0 -----> Actual Count: 1
Expected Count: -10 -----> Actual Count: 0

Still not working as expected.

Though very simple, the way you've set this up is bizarre and confusing - mostly confusing to you and those who do not understand the difference between static/class variables and instance variables. But still confusing to the rest of us who are wondering what you're trying to do.

myCount and myCount2 are static or class variables (two names for the same thing), but you're treating them as though they were instance variables.

Try rewriting your code so that the variables are declared thusly:

private int myCount;
private int myCount2;

You'll get errors at first. Those errors can be overcome, and I hope you'll learn something in the process. If you can't figure out how to do what I'm asking or if you don't understand why, then come back.

Ok GregBrannon, Thank you for your response. I made the changes but the errors that pop up is that the system wants to make them 'static'. Is that right?

Don't let "the system" or the IDE be the boss of you or your code. You need to learn the whys and hows of doing it correctly.

Instead of using static variables as you posted, use instance variables as I suggested, then DON'T use those variables in the main method. Either use other variables local to main() OR use constants. Using local variables is preferred, because that will allow you to change the program's behavior by changing the value of a variable rather than changing every constant, remembering why/what the constant should change to, etc.

Start simple. Comment out most of your main() method and reduce it to a couple working lines. Something like:

    public static void main( String[] args )
    {
        int firstStepValue = 1;
        int secondStepValue = 10;
 
         //create a new counter with a step value of 1
        CounterTester counter = new CounterTester( firstStepValue );
        counter.increase( firstStepValue ); //add 1
        System.out.println( "Expected Count: 1 -----> Actual Count: " +
                            counter.getValue() );
/*                            
        counter.increase( 1 ); //add 1
        System.out.println( "Expected Count: 2 -----> Actual Count: " +
                            counter.getValue() );
        counter.decrease( -1 ); //subtract 1
        System.out.println( "Expected Count: 1 -----> Actual Count: " +
                            counter.getValue() );
        CounterTester counter1 = new CounterTester(
            10 ); //create a new counter with a step value of 10
        System.out.println( "Expected Count: 0 -----> Actual Count: " +
                            counter1.getValue() );
        counter1.increase( 10 ); //add 10
        System.out.println( "Expected Count: 10 ----> Actual Count: " +
                            counter1.getValue() );
        counter1.decrease( -10 ); //subtract 10
        System.out.println( "Expected Count: 0 -----> Actual Count: " +
                            counter1.getValue() );
        counter1.decrease( -10 ); //subtract 10
        System.out.println( "Expected Count: -10 -----> Actual Count: " +
                            counter1.getValue() );
*/
    }

If that little bit or working code doesn't work as expected, figure out why and fix it. (It actually does work as it should, but your expectations are wrong. Your expectations may be what you have to fix.)

BTW - Understanding this may be your first step (one of many) in understanding a most basic Object Oriented Programming principle, what objects are and a little bit about how to use them.